diff mbox

[v2] trace-cmd : new package

Message ID 1375425135-4301-1-git-send-email-p.floury@gmail.com
State Superseded
Headers show

Commit Message

pierre Aug. 2, 2013, 6:32 a.m. UTC
From: pierre <pierre.floury@gmail.com>

This commit adds a new package for the trace-cmd tool.
This tool is a command line front end of ftrace.
It collects traces on your target.
You can analyse these traces on the target or on the host via
the gui "kernel shark".

http://git.kernel.org/cgit/linux/kernel/git/rostedt/trace-cmd.git

Signed-off-by: pierre <pierre.floury@gmail.com>

---
Change since v1 :
- added suggestions by Thomas De Schampheleire and Thomas Petazzoni
- set good license
- set good license files
- change name in the .mk from TRACECMD to TRACE_CMD
- change comment on the Config.in
- use a tag git instead of a commit number for the reference of the version
---
 package/Config.in              |    1 +
 package/trace-cmd/Config.in    |    9 +++++++++
 package/trace-cmd/trace-cmd.mk |   23 +++++++++++++++++++++++
 3 files changed, 33 insertions(+)
 create mode 100644 package/trace-cmd/Config.in
 create mode 100644 package/trace-cmd/trace-cmd.mk

Comments

Thomas De Schampheleire Aug. 2, 2013, 7:20 a.m. UTC | #1
Hi Pierre,

On Fri, Aug 2, 2013 at 8:32 AM,  <p.floury@gmail.com> wrote:
> From: pierre <pierre.floury@gmail.com>
>
> This commit adds a new package for the trace-cmd tool.
> This tool is a command line front end of ftrace.
> It collects traces on your target.
> You can analyse these traces on the target or on the host via
> the gui "kernel shark".
>
> http://git.kernel.org/cgit/linux/kernel/git/rostedt/trace-cmd.git
>
> Signed-off-by: pierre <pierre.floury@gmail.com>

Please use your full name here, like:
Signed-off-by: Pierre Floury <pierre.floury@gmail.com>

This name ends up in the git log, so we want a uniform and clean overview.

>
> ---
> Change since v1 :
> - added suggestions by Thomas De Schampheleire and Thomas Petazzoni
> - set good license
> - set good license files
> - change name in the .mk from TRACECMD to TRACE_CMD
> - change comment on the Config.in
> - use a tag git instead of a commit number for the reference of the version
> ---
>  package/Config.in              |    1 +
>  package/trace-cmd/Config.in    |    9 +++++++++
>  package/trace-cmd/trace-cmd.mk |   23 +++++++++++++++++++++++
>  3 files changed, 33 insertions(+)
>  create mode 100644 package/trace-cmd/Config.in
>  create mode 100644 package/trace-cmd/trace-cmd.mk
>
> diff --git a/package/Config.in b/package/Config.in
> index 7069d77..a97753c 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -41,6 +41,7 @@ source "package/netperf/Config.in"
>  source "package/oprofile/Config.in"
>  source "package/pax-utils/Config.in"
>  source "package/perf/Config.in"
> +source "package/trace-cmd/Config.in"
>  source "package/ramspeed/Config.in"
>  source "package/ramsmp/Config.in"
>  source "package/rt-tests/Config.in"

Please use alphabetical ordering here. trace-cmd should come after
tinymembench, not after perf.

> diff --git a/package/trace-cmd/Config.in b/package/trace-cmd/Config.in
> new file mode 100644
> index 0000000..5ef8bc3
> --- /dev/null
> +++ b/package/trace-cmd/Config.in
> @@ -0,0 +1,9 @@
> +config BR2_PACKAGE_TRACE_CMD
> +       bool "trace-cmd"
> +       help
> +         Command line reader for ftrace
> +         To use this profiling tool, you should enable ftrace in your kernel configuration.
> +         This command collect traces on your target.
> +         You can analyse these traces on the target or on the host via the gui "kernel shark"
> +
> +         http://git.kernel.org/cgit/linux/kernel/git/rostedt/trace-cmd.git
> diff --git a/package/trace-cmd/trace-cmd.mk b/package/trace-cmd/trace-cmd.mk
> new file mode 100644
> index 0000000..1f81124
> --- /dev/null
> +++ b/package/trace-cmd/trace-cmd.mk
> @@ -0,0 +1,23 @@
> +#############################################################
> +#
> +# trace-cmd
> +#
> +#############################################################

Please use exactly 80 # characters for this header. Alexandre Belloni
recently fixed all packages in this way, probably you took an example
from before that.

> +
> +TRACE_CMD_VERSION = trace-cmd-v2.2.1
> +TRACE_CMD_SITE = http://git.kernel.org/cgit/linux/kernel/git/rostedt/trace-cmd.git
> +TRACE_CMD_SITE_METHOD = git
> +TRACE_CMD_INSTALL_STAGING = YES
> +TRACE_CMD_LICENSE = GPLv2 LGPLv2.1
> +TRACE_CMD_LICENSE_FILES = COPYING COPYING.LIB
> +define TRACE_CMD_BUILD_CMDS
> +     $(MAKE) CC="$(TARGET_CC)" LD="$(TARGET_LD)" -C $(@D) all
> +endef
> +
> +define TRACE_CMD_INSTALL_TARGET_CMDS
> +       $(INSTALL) -D -m 0755 $(@D)/trace-cmd $(TARGET_DIR)/usr/bin
> +       $(INSTALL) -d -m 0755 $(TARGET_DIR)/usr/lib/trace-cmd/plugins
> +       $(INSTALL) -D -m 0755 $(@D)/plugin_*.so $(TARGET_DIR)/usr/lib/trace-cmd/plugins
> +endef
> +
> +$(eval $(generic-package))

Best regards,
Thomas
diff mbox

Patch

diff --git a/package/Config.in b/package/Config.in
index 7069d77..a97753c 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -41,6 +41,7 @@  source "package/netperf/Config.in"
 source "package/oprofile/Config.in"
 source "package/pax-utils/Config.in"
 source "package/perf/Config.in"
+source "package/trace-cmd/Config.in"
 source "package/ramspeed/Config.in"
 source "package/ramsmp/Config.in"
 source "package/rt-tests/Config.in"
diff --git a/package/trace-cmd/Config.in b/package/trace-cmd/Config.in
new file mode 100644
index 0000000..5ef8bc3
--- /dev/null
+++ b/package/trace-cmd/Config.in
@@ -0,0 +1,9 @@ 
+config BR2_PACKAGE_TRACE_CMD
+	bool "trace-cmd"
+	help
+	  Command line reader for ftrace
+	  To use this profiling tool, you should enable ftrace in your kernel configuration.
+	  This command collect traces on your target.
+	  You can analyse these traces on the target or on the host via the gui "kernel shark"
+
+	  http://git.kernel.org/cgit/linux/kernel/git/rostedt/trace-cmd.git
diff --git a/package/trace-cmd/trace-cmd.mk b/package/trace-cmd/trace-cmd.mk
new file mode 100644
index 0000000..1f81124
--- /dev/null
+++ b/package/trace-cmd/trace-cmd.mk
@@ -0,0 +1,23 @@ 
+#############################################################
+#
+# trace-cmd
+#
+#############################################################
+
+TRACE_CMD_VERSION = trace-cmd-v2.2.1
+TRACE_CMD_SITE = http://git.kernel.org/cgit/linux/kernel/git/rostedt/trace-cmd.git
+TRACE_CMD_SITE_METHOD = git
+TRACE_CMD_INSTALL_STAGING = YES
+TRACE_CMD_LICENSE = GPLv2 LGPLv2.1
+TRACE_CMD_LICENSE_FILES = COPYING COPYING.LIB
+define TRACE_CMD_BUILD_CMDS
+     $(MAKE) CC="$(TARGET_CC)" LD="$(TARGET_LD)" -C $(@D) all
+endef
+
+define TRACE_CMD_INSTALL_TARGET_CMDS
+	$(INSTALL) -D -m 0755 $(@D)/trace-cmd $(TARGET_DIR)/usr/bin
+	$(INSTALL) -d -m 0755 $(TARGET_DIR)/usr/lib/trace-cmd/plugins
+	$(INSTALL) -D -m 0755 $(@D)/plugin_*.so $(TARGET_DIR)/usr/lib/trace-cmd/plugins
+endef
+
+$(eval $(generic-package))