Patchwork [libnftables] table: add nft_table_list_del function

login
register
mail settings
Submitter Arturo Borrero
Date Aug. 1, 2013, 12:45 p.m.
Message ID <20130801124546.13382.18859.stgit@nfdev.cica.es>
Download mbox | patch
Permalink /patch/263991/
State Changes Requested
Headers show

Comments

Arturo Borrero - Aug. 1, 2013, 12:45 p.m.
This patch adds the function nft_table_list_del(), that allows to delete
elements from a struct nft_table_list.

Signed-off-by: Arturo Borrero Gonzalez <arturo.borrero.glez@gmail.com>
---
 0 files changed


--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Pablo Neira - Aug. 7, 2013, 9:44 a.m.
Hi Arturo,

On Thu, Aug 01, 2013 at 02:45:46PM +0200, Arturo Borrero Gonzalez wrote:
> This patch adds the function nft_table_list_del(), that allows to delete
> elements from a struct nft_table_list.

Do you need this? Otherwise, you know that I'm reticent to add
new interfaces that we don't need at this moment.

If you indeed need it, please add it to other objects as well. Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Arturo Borrero - Aug. 7, 2013, 9:55 a.m.
On 7 August 2013 11:44, Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> Hi Arturo,
>
> On Thu, Aug 01, 2013 at 02:45:46PM +0200, Arturo Borrero Gonzalez wrote:
>> This patch adds the function nft_table_list_del(), that allows to delete
>> elements from a struct nft_table_list.
>
> Do you need this? Otherwise, you know that I'm reticent to add
> new interfaces that we don't need at this moment.
>
> If you indeed need it, please add it to other objects as well. Thanks.

Yes, I'm using this in an incoming example for libnftables.

Patch

diff --git a/include/libnftables/table.h b/include/libnftables/table.h
index 24ca374..a2882c2 100644
--- a/include/libnftables/table.h
+++ b/include/libnftables/table.h
@@ -59,6 +59,7 @@  int nft_table_list_foreach(struct nft_table_list *table_list, int (*cb)(struct n
 
 void nft_table_list_add(struct nft_table *r, struct nft_table_list *list);
 void nft_table_list_add_tail(struct nft_table *r, struct nft_table_list *list);
+void nft_table_list_del(struct nft_table *t);
 
 struct nft_table_list_iter;
 
diff --git a/src/libnftables.map b/src/libnftables.map
index 614c705..012184e 100644
--- a/src/libnftables.map
+++ b/src/libnftables.map
@@ -21,6 +21,7 @@  global:
   nft_table_list_foreach;
   nft_table_list_add;
   nft_table_list_add_tail;
+  nft_table_list_del;
   nft_table_list_iter_create;
   nft_table_list_iter_next;
   nft_table_list_iter_destroy;
diff --git a/src/table.c b/src/table.c
index 1d17d3b..30ca0c0 100644
--- a/src/table.c
+++ b/src/table.c
@@ -486,6 +486,12 @@  void nft_table_list_add_tail(struct nft_table *r, struct nft_table_list *list)
 }
 EXPORT_SYMBOL(nft_table_list_add_tail);
 
+void nft_table_list_del(struct nft_table *t)
+{
+	list_del(&t->head);
+}
+EXPORT_SYMBOL(nft_table_list_del);
+
 int nft_table_list_foreach(struct nft_table_list *table_list,
 			   int (*cb)(struct nft_table *t, void *data),
 			   void *data)