From patchwork Wed Jul 31 21:20:26 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: "Richard W.M. Jones" X-Patchwork-Id: 263803 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 91A332C00A4 for ; Thu, 1 Aug 2013 07:21:13 +1000 (EST) Received: from localhost ([::1]:54691 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V4dpU-0007xZ-IN for incoming@patchwork.ozlabs.org; Wed, 31 Jul 2013 17:21:08 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50120) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V4dp8-0007tT-L6 for qemu-devel@nongnu.org; Wed, 31 Jul 2013 17:20:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V4dot-0004gq-Up for qemu-devel@nongnu.org; Wed, 31 Jul 2013 17:20:46 -0400 Received: from mail.ukfsn.org ([5.9.116.23]:39003) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V4dot-0004ga-Fj for qemu-devel@nongnu.org; Wed, 31 Jul 2013 17:20:31 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.ukfsn.org (Postfix) with SMTP id ED935DC1959 for ; Wed, 31 Jul 2013 22:20:29 +0100 (BST) Received: from crme.home.annexia.org (87-127-78-49.static.enta.net [87.127.78.49]) by mail.ukfsn.org (Postfix) with ESMTPA id 1C038DC03A8; Wed, 31 Jul 2013 22:20:28 +0100 (BST) From: "Richard W.M. Jones" To: qemu-devel@nongnu.org Date: Wed, 31 Jul 2013 22:20:26 +0100 Message-Id: <1375305626-26972-1-git-send-email-rjones@redhat.com> X-Mailer: git-send-email 1.8.3.1 MIME-Version: 1.0 X-DSPAM-Result: Innocent X-DSPAM-Processed: Wed Jul 31 22:20:29 2013 X-DSPAM-Confidence: 1.0000 X-DSPAM-Probability: 0.0023 X-DSPAM-Signature: 51f97f9d207511300214638 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 5.9.116.23 Cc: qemu-trivial@nongnu.org, sw@weilnetz.de, afaerber@suse.de Subject: [Qemu-devel] [PATCH v3] block/iscsi.c: Fix printf format error. X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: "Richard W.M. Jones" The error on armv7hl was: block/iscsi.c: In function ‘is_request_lun_aligned’: block/iscsi.c:251:26: error: format ‘%ld’ expects argument of type ‘long int’, but argument 3 has type ‘int64_t’ [-Werror=format=] iscsilun->block_size, sector_num, nb_sectors); ^ This also splits the long line to comply with qemu coding guidelines. Signed-off-by: Richard W.M. Jones Reviewed-by: Stefan Weil Reviewed-by: Stefan Hajnoczi --- block/iscsi.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/block/iscsi.c b/block/iscsi.c index 5f28c6a..e7c1c2b 100644 --- a/block/iscsi.c +++ b/block/iscsi.c @@ -247,7 +247,9 @@ static bool is_request_lun_aligned(int64_t sector_num, int nb_sectors, { if ((sector_num * BDRV_SECTOR_SIZE) % iscsilun->block_size || (nb_sectors * BDRV_SECTOR_SIZE) % iscsilun->block_size) { - error_report("iSCSI misaligned request: iscsilun->block_size %u, sector_num %ld, nb_sectors %d", + error_report("iSCSI misaligned request: " + "iscsilun->block_size %u, sector_num %" PRIi64 + ", nb_sectors %d", iscsilun->block_size, sector_num, nb_sectors); return 0; }