From patchwork Wed Jul 31 18:09:26 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Whitcroft X-Patchwork-Id: 263787 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) by ozlabs.org (Postfix) with ESMTP id E4E052C00B9 for ; Thu, 1 Aug 2013 04:23:05 +1000 (EST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.76) (envelope-from ) id 1V4b2j-0000MF-P3; Wed, 31 Jul 2013 18:22:37 +0000 Received: from mail-wi0-f182.google.com ([209.85.212.182]) by huckleberry.canonical.com with esmtp (Exim 4.76) (envelope-from ) id 1V4aq6-0007Vj-Qx for kernel-team@lists.ubuntu.com; Wed, 31 Jul 2013 18:09:34 +0000 Received: by mail-wi0-f182.google.com with SMTP id hi8so972030wib.3 for ; Wed, 31 Jul 2013 11:09:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references :x-gm-message-state; bh=tbJ4DZBb5skezaCyMEcoYEpub4CwfDadJIKIPfp8ezo=; b=A0mPT2P9KzGm4+U0mkFhk2Ak7o4hnkfCGOrS7Knavf8l/ep/TJiWEG53WtYZ+AOQDS v8l/0+rBYVgxJV7L1g6KwZtZlAMyn9k9phDNonieq552isiz02oatXMUiYsb0Gmx/OcP 1U47T7xiNgvZQA4dwLEprYcNWVjk1TgdOl88UY4aTYJ9M083PXmrdKaJ+8iuSJYg4rxz JN5SO70KKmtkdHMNBrffUB6PFTocnSNUekwn19GwaMf4LlZv87YBPD5mXADPkUP1mF+V A5UwZlKie9/w2Gl8AhH0go/DPT202aYGU/fPZ9ontzudRDZ0T6MysKjqoVuTbmgThggz CCmQ== X-Received: by 10.180.183.180 with SMTP id en20mr5109827wic.18.1375294174698; Wed, 31 Jul 2013 11:09:34 -0700 (PDT) Received: from localhost ([2001:470:6973:2:221:70ff:fe81:b177]) by mx.google.com with ESMTPSA id mb7sm3934498wic.10.2013.07.31.11.09.33 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Wed, 31 Jul 2013 11:09:33 -0700 (PDT) From: Andy Whitcroft To: kernel-team@lists.ubuntu.com Subject: [lucid CVE 1/1] UBUNTU: [Packaging] supply perf with appropriate prefix to ensure use of local config Date: Wed, 31 Jul 2013 19:09:26 +0100 Message-Id: <1375294169-9567-2-git-send-email-apw@canonical.com> X-Mailer: git-send-email 1.8.1.2 In-Reply-To: <1375294169-9567-1-git-send-email-apw@canonical.com> References: <1375294169-9567-1-git-send-email-apw@canonical.com> X-Gm-Message-State: ALoCoQluGORiejJIqNX7buVdHYKOH/MqpKEPPUguXcl0x5R5Z5KWn82arxVKKPPmHYeQZH8yLTqY Cc: Andy Whitcroft X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.14 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: kernel-team-bounces@lists.ubuntu.com If we do not supply an installation prefix when we are building perf it will assume it is designed to run relative to the builders HOME. This means that as built on a buildd we will check for the system configuration relative to the buildd users home rather than in /etc. This implies a local user could use this to compromise other users _if_ there is a buildd user installed on the system and they have access to it. CVE-2013-1060 BugLink: http://bugs.launchpad.net/bugs/1206200 Signed-off-by: Andy Whitcroft --- debian/rules.d/2-binary-arch.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/debian/rules.d/2-binary-arch.mk b/debian/rules.d/2-binary-arch.mk index 18b4401..7b62a57 100644 --- a/debian/rules.d/2-binary-arch.mk +++ b/debian/rules.d/2-binary-arch.mk @@ -348,7 +348,7 @@ endif $(stampdir)/stamp-build-perarch: $(stampdir)/stamp-prepare-perarch ifeq ($(do_tools),true) - cd $(builddirpa)/tools-$*/tools/perf && make HAVE_CPLUS_DEMANGLE=1 $(conc_level) + cd $(builddirpa)/tools-$*/tools/perf && make prefix=/usr HAVE_CPLUS_DEMANGLE=1 $(conc_level) endif @touch $@