diff mbox

[1/2,v2] igb: Add macro for size of RETA indirection table

Message ID 1375271273-20122-1-git-send-email-laura.vasilescu@rosedu.org
State Awaiting Upstream, archived
Delegated to: David Miller
Headers show

Commit Message

laura.vasilescu@rosedu.org July 31, 2013, 11:47 a.m. UTC
RETA indirection table is used to assign the received data to a CPU
in order to maintain an efficient distribution of network receive
processing accross multiple CPUs.

This patch removes the hard-coded value for the size of the indirection
table and defines a new macro.

Signed-off-by: Laura Mihaela Vasilescu <laura.vasilescu@rosedu.org>
---
Changes since v1:
	* enhance commit description

 drivers/net/ethernet/intel/igb/igb.h      |    2 ++
 drivers/net/ethernet/intel/igb/igb_main.c |    2 +-
 2 files changed, 3 insertions(+), 1 deletion(-)

Comments

Kirsher, Jeffrey T July 31, 2013, 12:12 p.m. UTC | #1
On Wed, 2013-07-31 at 14:47 +0300, Laura Mihaela Vasilescu wrote:
> 
> RETA indirection table is used to assign the received data to a CPU
> in order to maintain an efficient distribution of network receive
> processing accross multiple CPUs.
> 
> This patch removes the hard-coded value for the size of the
> indirection
> table and defines a new macro.
> 
> Signed-off-by: Laura Mihaela Vasilescu <laura.vasilescu@rosedu.org>
> ---
> Changes since v1:
>         * enhance commit description
> 
>  drivers/net/ethernet/intel/igb/igb.h      |    2 ++
>  drivers/net/ethernet/intel/igb/igb_main.c |    2 +-
>  2 files changed, 3 insertions(+), 1 deletion(-) 

Added to my queue, thank you Laura!
diff mbox

Patch

diff --git a/drivers/net/ethernet/intel/igb/igb.h b/drivers/net/ethernet/intel/igb/igb.h
index 15ea8dc..5a2659b 100644
--- a/drivers/net/ethernet/intel/igb/igb.h
+++ b/drivers/net/ethernet/intel/igb/igb.h
@@ -343,6 +343,8 @@  struct hwmon_buff {
 	};
 #endif
 
+#define IGB_RETA_SIZE	128
+
 /* board specific private data structure */
 struct igb_adapter {
 	unsigned long active_vlans[BITS_TO_LONGS(VLAN_N_VID)];
diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c
index 6a0c1b6..00f5d96 100644
--- a/drivers/net/ethernet/intel/igb/igb_main.c
+++ b/drivers/net/ethernet/intel/igb/igb_main.c
@@ -3127,7 +3127,7 @@  static void igb_setup_mrqc(struct igb_adapter *adapter)
 	 * we are generating the results for n and n+2 and then interleaving
 	 * those with the results with n+1 and n+3.
 	 */
-	for (j = 0; j < 32; j++) {
+	for (j = 0; j < IGB_RETA_SIZE / 4; j++) {
 		/* first pass generates n and n+2 */
 		u32 base = ((j * 0x00040004) + 0x00020000) * num_rx_queues;
 		u32 reta = (base & 0x07800780) >> (7 - shift);