Patchwork [v3,1/7] vvfat: use bdrv_new() to allocate BlockDriverState

login
register
mail settings
Submitter Fam Zheng
Date July 31, 2013, 10:13 a.m.
Message ID <1375265640-27307-2-git-send-email-famz@redhat.com>
Download mbox | patch
Permalink /patch/263667/
State New
Headers show

Comments

Fam Zheng - July 31, 2013, 10:13 a.m.
we need bdrv_new() to properly initialize BDS, don't allocate memory
manually.

Signed-off-by: Fam Zheng <famz@redhat.com>
---
 block/vvfat.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Wayne Xia - Aug. 2, 2013, 7:23 a.m.
Reviewed-by: Wenchao Xia <xiawenc@linux.vnet.ibm.com>

> we need bdrv_new() to properly initialize BDS, don't allocate memory
> manually.
> 
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
>   block/vvfat.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/block/vvfat.c b/block/vvfat.c
> index cd3b8ed..a827d91 100644
> --- a/block/vvfat.c
> +++ b/block/vvfat.c
> @@ -2943,7 +2943,7 @@ static int enable_write_target(BDRVVVFATState *s)
>       unlink(s->qcow_filename);
>   #endif
> 
> -    s->bs->backing_hd = calloc(sizeof(BlockDriverState), 1);
> +    s->bs->backing_hd = bdrv_new("");
>       s->bs->backing_hd->drv = &vvfat_write_target;
>       s->bs->backing_hd->opaque = g_malloc(sizeof(void*));
>       *(void**)s->bs->backing_hd->opaque = s;
>

Patch

diff --git a/block/vvfat.c b/block/vvfat.c
index cd3b8ed..a827d91 100644
--- a/block/vvfat.c
+++ b/block/vvfat.c
@@ -2943,7 +2943,7 @@  static int enable_write_target(BDRVVVFATState *s)
     unlink(s->qcow_filename);
 #endif
 
-    s->bs->backing_hd = calloc(sizeof(BlockDriverState), 1);
+    s->bs->backing_hd = bdrv_new("");
     s->bs->backing_hd->drv = &vvfat_write_target;
     s->bs->backing_hd->opaque = g_malloc(sizeof(void*));
     *(void**)s->bs->backing_hd->opaque = s;