Patchwork [1/2] raw: add license header

login
register
mail settings
Submitter Paolo Bonzini
Date July 31, 2013, 6:19 a.m.
Message ID <1375251592-2537-2-git-send-email-pbonzini@redhat.com>
Download mbox | patch
Permalink /patch/263588/
State New
Headers show

Comments

Paolo Bonzini - July 31, 2013, 6:19 a.m.
Most of the block layer is under the BSD license, thus it is reasonable
to license block/raw.c the same way.  CCed people should ACK by replying
with a Signed-off-by line.

Cc: Christoph Hellwig <hch@lst.de>
Cc: Kevin Wolf <kwolf@redhat.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>
Cc: Markus Armbruster <armbru@redhat.com>
Cc: Stefan Hajnoczi <stefanha@redhat.com>
Cc: Luiz Capitulino <lcapitulino@redhat.com>
Cc: Jeff Cody <jcody@redhat.com>
Cc: Peter Lieven <pl@kamp.de>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 block/raw.c | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)
Kevin Wolf - July 31, 2013, 7:52 a.m.
Am 31.07.2013 um 08:19 hat Paolo Bonzini geschrieben:
> Most of the block layer is under the BSD license, thus it is reasonable
> to license block/raw.c the same way.  CCed people should ACK by replying
> with a Signed-off-by line.
> 
> Cc: Christoph Hellwig <hch@lst.de>
> Cc: Kevin Wolf <kwolf@redhat.com>
> Cc: Anthony Liguori <aliguori@us.ibm.com>
> Cc: Markus Armbruster <armbru@redhat.com>
> Cc: Stefan Hajnoczi <stefanha@redhat.com>
> Cc: Luiz Capitulino <lcapitulino@redhat.com>
> Cc: Jeff Cody <jcody@redhat.com>
> Cc: Peter Lieven <pl@kamp.de>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

Thanks, Paolo, for taking the effort to clarify the license.

Signed-off-by: Kevin Wolf <kwolf@redhat.com>

>  block/raw.c | 23 +++++++++++++++++++++++
>  1 file changed, 23 insertions(+)
> 
> diff --git a/block/raw.c b/block/raw.c
> index f1682d4..4751825 100644
> --- a/block/raw.c
> +++ b/block/raw.c
> @@ -1,3 +1,26 @@
> +/*
> + * Block driver for RAW format
> + *
> + * Copyright (c) 2006 Fabrice Bellard

This part of the code is actually something that Fabrice never touched
(and consequently you didn't CC him either). This should probably refer
to Christoph instead or include all of the people who contributed to the
file.

Kevin
Markus Armbruster - July 31, 2013, 8:01 a.m.
Paolo Bonzini <pbonzini@redhat.com> writes:

> Most of the block layer is under the BSD license, thus it is reasonable
> to license block/raw.c the same way.  CCed people should ACK by replying
> with a Signed-off-by line.
>
> Cc: Christoph Hellwig <hch@lst.de>
> Cc: Kevin Wolf <kwolf@redhat.com>
> Cc: Anthony Liguori <aliguori@us.ibm.com>
> Cc: Markus Armbruster <armbru@redhat.com>
> Cc: Stefan Hajnoczi <stefanha@redhat.com>
> Cc: Luiz Capitulino <lcapitulino@redhat.com>
> Cc: Jeff Cody <jcody@redhat.com>
> Cc: Peter Lieven <pl@kamp.de>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

In general, I very much prefer to protect my work with a strong copyleft
license like the GPLv2+.  However, my contributions to raw.c are
trivial, so I choose to go with the flow in this case.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Stefan Hajnoczi - July 31, 2013, 10:49 a.m.
On Wed, Jul 31, 2013 at 08:19:51AM +0200, Paolo Bonzini wrote:
> Most of the block layer is under the BSD license, thus it is reasonable
> to license block/raw.c the same way.  CCed people should ACK by replying
> with a Signed-off-by line.
> 
> Cc: Christoph Hellwig <hch@lst.de>
> Cc: Kevin Wolf <kwolf@redhat.com>
> Cc: Anthony Liguori <aliguori@us.ibm.com>
> Cc: Markus Armbruster <armbru@redhat.com>
> Cc: Stefan Hajnoczi <stefanha@redhat.com>

I switched employers since my block/raw.c contributions, but FWIW:

Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Jeff Cody - July 31, 2013, 12:24 p.m.
On Wed, Jul 31, 2013 at 08:19:51AM +0200, Paolo Bonzini wrote:
> Most of the block layer is under the BSD license, thus it is reasonable
> to license block/raw.c the same way.  CCed people should ACK by replying
> with a Signed-off-by line.
> 
> Cc: Christoph Hellwig <hch@lst.de>
> Cc: Kevin Wolf <kwolf@redhat.com>
> Cc: Anthony Liguori <aliguori@us.ibm.com>
> Cc: Markus Armbruster <armbru@redhat.com>
> Cc: Stefan Hajnoczi <stefanha@redhat.com>
> Cc: Luiz Capitulino <lcapitulino@redhat.com>
> Cc: Jeff Cody <jcody@redhat.com>

Signed-off-by: Jeff Cody <jcody@redhat.com>


> Cc: Peter Lieven <pl@kamp.de>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  block/raw.c | 23 +++++++++++++++++++++++
>  1 file changed, 23 insertions(+)
> 
> diff --git a/block/raw.c b/block/raw.c
> index f1682d4..4751825 100644
> --- a/block/raw.c
> +++ b/block/raw.c
> @@ -1,3 +1,26 @@
> +/*
> + * Block driver for RAW format
> + *
> + * Copyright (c) 2006 Fabrice Bellard
> + *
> + * Permission is hereby granted, free of charge, to any person obtaining a copy
> + * of this software and associated documentation files (the "Software"), to deal
> + * in the Software without restriction, including without limitation the rights
> + * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
> + * copies of the Software, and to permit persons to whom the Software is
> + * furnished to do so, subject to the following conditions:
> + *
> + * The above copyright notice and this permission notice shall be included in
> + * all copies or substantial portions of the Software.
> + *
> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
> + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
> + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
> + * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
> + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
> + * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
> + * THE SOFTWARE.
> + */
>  
>  #include "qemu-common.h"
>  #include "block/block_int.h"
> -- 
> 1.8.1.4
> 
> 
>
Luiz Capitulino - July 31, 2013, 1:04 p.m.
On Wed, 31 Jul 2013 08:19:51 +0200
Paolo Bonzini <pbonzini@redhat.com> wrote:

> Most of the block layer is under the BSD license, thus it is reasonable
> to license block/raw.c the same way.  CCed people should ACK by replying
> with a Signed-off-by line.
> 
> Cc: Christoph Hellwig <hch@lst.de>
> Cc: Kevin Wolf <kwolf@redhat.com>
> Cc: Anthony Liguori <aliguori@us.ibm.com>
> Cc: Markus Armbruster <armbru@redhat.com>
> Cc: Stefan Hajnoczi <stefanha@redhat.com>
> Cc: Luiz Capitulino <lcapitulino@redhat.com>
> Cc: Jeff Cody <jcody@redhat.com>
> Cc: Peter Lieven <pl@kamp.de>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  block/raw.c | 23 +++++++++++++++++++++++
>  1 file changed, 23 insertions(+)

Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>

> 
> diff --git a/block/raw.c b/block/raw.c
> index f1682d4..4751825 100644
> --- a/block/raw.c
> +++ b/block/raw.c
> @@ -1,3 +1,26 @@
> +/*
> + * Block driver for RAW format
> + *
> + * Copyright (c) 2006 Fabrice Bellard
> + *
> + * Permission is hereby granted, free of charge, to any person obtaining a copy
> + * of this software and associated documentation files (the "Software"), to deal
> + * in the Software without restriction, including without limitation the rights
> + * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
> + * copies of the Software, and to permit persons to whom the Software is
> + * furnished to do so, subject to the following conditions:
> + *
> + * The above copyright notice and this permission notice shall be included in
> + * all copies or substantial portions of the Software.
> + *
> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
> + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
> + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
> + * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
> + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
> + * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
> + * THE SOFTWARE.
> + */
>  
>  #include "qemu-common.h"
>  #include "block/block_int.h"
Christoph Hellwig - Aug. 1, 2013, 8:13 a.m.
On Wed, Jul 31, 2013 at 08:19:51AM +0200, Paolo Bonzini wrote:
> Most of the block layer is under the BSD license, thus it is reasonable
> to license block/raw.c the same way.  CCed people should ACK by replying
> with a Signed-off-by line.

The coded was intended to be GPLv2.
Paolo Bonzini - Aug. 1, 2013, 8:38 a.m.
> On Wed, Jul 31, 2013 at 08:19:51AM +0200, Paolo Bonzini wrote:
> > Most of the block layer is under the BSD license, thus it is reasonable
> > to license block/raw.c the same way.  CCed people should ACK by replying
> > with a Signed-off-by line.
> 
> The coded was intended to be GPLv2.

I guess some day we'll rewrite it, perhaps when libqblock is closer to
being merged.

Paolo
Peter Lieven - Aug. 2, 2013, 7:01 a.m.
On 31.07.2013 10:01, Markus Armbruster wrote:
> Paolo Bonzini <pbonzini@redhat.com> writes:
>
>> Most of the block layer is under the BSD license, thus it is reasonable
>> to license block/raw.c the same way.  CCed people should ACK by replying
>> with a Signed-off-by line.
>>
>> Cc: Christoph Hellwig <hch@lst.de>
>> Cc: Kevin Wolf <kwolf@redhat.com>
>> Cc: Anthony Liguori <aliguori@us.ibm.com>
>> Cc: Markus Armbruster <armbru@redhat.com>
>> Cc: Stefan Hajnoczi <stefanha@redhat.com>
>> Cc: Luiz Capitulino <lcapitulino@redhat.com>
>> Cc: Jeff Cody <jcody@redhat.com>
>> Cc: Peter Lieven <pl@kamp.de>
>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> In general, I very much prefer to protect my work with a strong copyleft
> license like the GPLv2+.  However, my contributions to raw.c are
> trivial, so I choose to go with the flow in this case.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
same applies for me.

Signed-off-by: Peter Lieven <pl@kamp.de>
Anthony Liguori - Aug. 15, 2013, 1:16 p.m.
Christoph Hellwig <hch@lst.de> writes:

> On Wed, Jul 31, 2013 at 08:19:51AM +0200, Paolo Bonzini wrote:
>> Most of the block layer is under the BSD license, thus it is reasonable
>> to license block/raw.c the same way.  CCed people should ACK by replying
>> with a Signed-off-by line.
>
> The coded was intended to be GPLv2.

Can you send a patch to add your copyright to this file?  I added the
BSD license that most folks Signed-off-by but you should add your GPLv2
copyright (making the file effectively GPLv2).

Regards,

Anthony Liguori

Patch

diff --git a/block/raw.c b/block/raw.c
index f1682d4..4751825 100644
--- a/block/raw.c
+++ b/block/raw.c
@@ -1,3 +1,26 @@ 
+/*
+ * Block driver for RAW format
+ *
+ * Copyright (c) 2006 Fabrice Bellard
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a copy
+ * of this software and associated documentation files (the "Software"), to deal
+ * in the Software without restriction, including without limitation the rights
+ * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+ * copies of the Software, and to permit persons to whom the Software is
+ * furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice shall be included in
+ * all copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
+ * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
+ * THE SOFTWARE.
+ */
 
 #include "qemu-common.h"
 #include "block/block_int.h"