Patchwork [google,gcc-4_8] Force cmd-line match for option -ansi in LIPO use

login
register
mail settings
Submitter Rong Xu
Date July 30, 2013, 8:44 p.m.
Message ID <CAF1bQ=Sd+YOAF55Tvp8Sytjm-qYER6SYadiB5QEq2K+kq30M2Q@mail.gmail.com>
Download mbox | patch
Permalink /patch/263521/
State New
Headers show

Comments

Rong Xu - July 30, 2013, 8:44 p.m.
The following patch forces the command line match for -ansi option
in LIPO use build. Otherwise, it gets various undefined symbol errors.
This is exposed in LIPO random grouping test.

Tested with google internal benchmarks and gcc regression test.

2013-07-30  Rong Xu  <xur@google.com>

        * gcc/coverage.c (force_matching_cg_opts): require
        cmd line match on -ansi option in LIPO use build.
Xinliang David Li - July 30, 2013, 9:16 p.m.
On Tue, Jul 30, 2013 at 1:44 PM, Rong Xu <xur@google.com> wrote:
> The following patch forces the command line match for -ansi option
> in LIPO use build. Otherwise, it gets various undefined symbol errors.

Parsing error as you have clarified.

> This is exposed in LIPO random grouping test.
>
> Tested with google internal benchmarks and gcc regression test.
>
> 2013-07-30  Rong Xu  <xur@google.com>
>
>         * gcc/coverage.c (force_matching_cg_opts): require
>         cmd line match on -ansi option in LIPO use build.
>
> Index: gcc/coverage.c
> ===================================================================
> --- gcc/coverage.c      (revision 201219)
> +++ gcc/coverage.c      (working copy)
> @@ -263,6 +263,7 @@ static struct opt_desc force_matching_cg_opts[] =
>      { "-fsized-delete", "-fno-sized-delete", false },
>      { "-frtti", "-fno-rtti", true },
>      { "-fstrict-aliasing", "-fno-strict-aliasing", true },
> +    { "-ansi", "", false },
>      { NULL, NULL, false }
>    };

Ok for google branch.

David

Patch

Index: gcc/coverage.c
===================================================================
--- gcc/coverage.c      (revision 201219)
+++ gcc/coverage.c      (working copy)
@@ -263,6 +263,7 @@  static struct opt_desc force_matching_cg_opts[] =
     { "-fsized-delete", "-fno-sized-delete", false },
     { "-frtti", "-fno-rtti", true },
     { "-fstrict-aliasing", "-fno-strict-aliasing", true },
+    { "-ansi", "", false },
     { NULL, NULL, false }
   };