From patchwork Tue Jul 30 15:17:29 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Genoud X-Patchwork-Id: 263403 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from casper.infradead.org (unknown [IPv6:2001:770:15f::2]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id D674D2C00A7 for ; Wed, 31 Jul 2013 01:18:23 +1000 (EST) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1V4Bgh-0000oP-Oa; Tue, 30 Jul 2013 15:18:12 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1V4Bgg-00024W-33; Tue, 30 Jul 2013 15:18:10 +0000 Received: from mail-wg0-x230.google.com ([2a00:1450:400c:c00::230]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1V4Bge-000234-0o for linux-mtd@lists.infradead.org; Tue, 30 Jul 2013 15:18:08 +0000 Received: by mail-wg0-f48.google.com with SMTP id f12so5537047wgh.27 for ; Tue, 30 Jul 2013 08:17:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer; bh=GyMDjHP5Oz7emfHSUVRymPPEOCj7LMU+9hlVsJimu4E=; b=opxxEJw47a5twTmYWset9VfAh4RL4Ds3GbL/VuZEfHxrp2bFSXjmLWkbW4YNwtA2CR aKhJ2l5yk+1/s9taue9y4dj3mwnFSeeFhRCVaiXshk7ctwMZtj1TPEjfnxhEj2ZCtE1k K/xSral3aNLcH98MHIKh9icY0nk8OYXGyx02fMW+lKHJnwSqaEItfyQJwM/4Q2bgf9RW Upgbx0fIwkWlPvRYekyZSnkyplRwPJToTSsjNqtscxdjMe6d/m2LTPLkNGYCGu1s+/KA hn/lyk5uZ87KsPn4TXLczcG9Erw9gN5ekKVuo3hi6/cwbJi5KmSTecWxNKm7Lr3qaxII A5qQ== X-Received: by 10.180.77.164 with SMTP id t4mr1268770wiw.58.1375197464685; Tue, 30 Jul 2013 08:17:44 -0700 (PDT) Received: from lnx-rg.pr (lyon.paratronic.fr. [213.41.177.106]) by mx.google.com with ESMTPSA id li9sm29235374wic.2.2013.07.30.08.17.42 for (version=TLSv1.2 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 30 Jul 2013 08:17:43 -0700 (PDT) From: Richard Genoud To: David Woodhouse , Artem Bityutskiy Subject: [PATCH resend] MTD: atmel_nand: using a stronger ECC is not dangerous Date: Tue, 30 Jul 2013 17:17:29 +0200 Message-Id: <1375197449-32370-1-git-send-email-richard.genoud@gmail.com> X-Mailer: git-send-email 1.7.10.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20130730_111808_206469_52AC1C5D X-CRM114-Status: GOOD ( 10.93 ) X-Spam-Score: -2.0 (--) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-2.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (richard.genoud[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature Cc: Richard Genoud , Josh Wu , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org We don't have to issue a warning when a stronger error correting capability is chosen. Signed-off-by: Richard Genoud Acked-by: Josh Wu --- It seems that this patch has been forgotten (even by me) for some months. (was already acked by Josh then) Reference of the discussion leading to this patch: http://comments.gmane.org/gmane.linux.drivers.mtd/46342 drivers/mtd/nand/atmel_nand.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mtd/nand/atmel_nand.c b/drivers/mtd/nand/atmel_nand.c index 2d23d29..2415cdc 100644 --- a/drivers/mtd/nand/atmel_nand.c +++ b/drivers/mtd/nand/atmel_nand.c @@ -1002,7 +1002,7 @@ static int __init atmel_pmecc_nand_init_params(struct platform_device *pdev, return err_no; } - if (cap != host->pmecc_corr_cap || + if (cap > host->pmecc_corr_cap || sector_size != host->pmecc_sector_size) dev_info(host->dev, "WARNING: Be Caution! Using different PMECC parameters from Nand ONFI ECC reqirement.\n");