Patchwork [resend] MTD: atmel_nand: using a stronger ECC is not dangerous

login
register
mail settings
Submitter Richard Genoud
Date July 30, 2013, 3:17 p.m.
Message ID <1375197449-32370-1-git-send-email-richard.genoud@gmail.com>
Download mbox | patch
Permalink /patch/263403/
State New
Headers show

Comments

Richard Genoud - July 30, 2013, 3:17 p.m.
We don't have to issue a warning when a stronger error correting
capability is chosen.

Signed-off-by: Richard Genoud <richard.genoud@gmail.com>
Acked-by: Josh Wu <josh.wu@atmel.com>
---
It seems that this patch has been forgotten (even by me)
for some months. (was already acked by Josh then)
Reference of the discussion leading to this patch:
http://comments.gmane.org/gmane.linux.drivers.mtd/46342

 drivers/mtd/nand/atmel_nand.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Artem Bityutskiy - Aug. 2, 2013, 2:51 p.m.
On Tue, 2013-07-30 at 17:17 +0200, Richard Genoud wrote:
> We don't have to issue a warning when a stronger error correting
> capability is chosen.
> 
> Signed-off-by: Richard Genoud <richard.genoud@gmail.com>
> Acked-by: Josh Wu <josh.wu@atmel.com>

Pushed to l2-mtd.git, thanks!

Patch

diff --git a/drivers/mtd/nand/atmel_nand.c b/drivers/mtd/nand/atmel_nand.c
index 2d23d29..2415cdc 100644
--- a/drivers/mtd/nand/atmel_nand.c
+++ b/drivers/mtd/nand/atmel_nand.c
@@ -1002,7 +1002,7 @@  static int __init atmel_pmecc_nand_init_params(struct platform_device *pdev,
 		return err_no;
 	}
 
-	if (cap != host->pmecc_corr_cap ||
+	if (cap > host->pmecc_corr_cap ||
 			sector_size != host->pmecc_sector_size)
 		dev_info(host->dev, "WARNING: Be Caution! Using different PMECC parameters from Nand ONFI ECC reqirement.\n");