| Message ID | ce2c57e3c0ffd169b943fefd7421930ad910ea0e.1375195925.git.minovotn@redhat.com |
|---|---|
| State | New |
| Headers | show |
Michal Novotny <minovotn@redhat.com> writes: > Output error message when user provides the invalid machine type > on the command line. This also saves time to find what issue is > when you upgrade from one version of qemu to another version that > doesn't support required machine type any longer. Text from here > > The patch is checked using ./scripts/checkpatch.pl script and > also is_help_option() function is being used. > > Michal to here belongs below the '---' line, so it's ommitted from the commit message. > > Signed-off-by: Michal Novotny <minovotn@redhat.com> > --- > vl.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/vl.c b/vl.c > index 25b8f2f..563ae67 100644 > --- a/vl.c > +++ b/vl.c > @@ -2671,6 +2671,11 @@ static QEMUMachine *machine_parse(const char *name) > if (machine) { > return machine; > } > + > + if (name && !is_help_option(name)) { > + printf("Error: Unsupported machine type '%s'\n", name); > + } > + > printf("Supported machines are:\n"); > for (m = first_machine; m != NULL; m = m->next) { > if (m->alias) {
Hi Markus, should I rebase it or no need and can maintainer do it before push? Michal On 07/30/2013 05:17 PM, Markus Armbruster wrote: > Michal Novotny <minovotn@redhat.com> writes: > >> Output error message when user provides the invalid machine type >> on the command line. This also saves time to find what issue is >> when you upgrade from one version of qemu to another version that >> doesn't support required machine type any longer. > Text from here > >> The patch is checked using ./scripts/checkpatch.pl script and >> also is_help_option() function is being used. >> >> Michal > to here belongs below the '---' line, so it's ommitted from the commit > message. > >> Signed-off-by: Michal Novotny <minovotn@redhat.com> >> --- >> vl.c | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/vl.c b/vl.c >> index 25b8f2f..563ae67 100644 >> --- a/vl.c >> +++ b/vl.c >> @@ -2671,6 +2671,11 @@ static QEMUMachine *machine_parse(const char *name) >> if (machine) { >> return machine; >> } >> + >> + if (name && !is_help_option(name)) { >> + printf("Error: Unsupported machine type '%s'\n", name); >> + } >> + >> printf("Supported machines are:\n"); >> for (m = first_machine; m != NULL; m = m->next) { >> if (m->alias) {
Michal Novotny <minovotn@redhat.com> writes: > Hi Markus, > should I rebase it or no need and can maintainer do it before push? Depends on the maintainer :) I'd respin.
Hi Markus, thanks, v3 sent. Michal On 07/30/2013 09:05 PM, Markus Armbruster wrote: > Michal Novotny <minovotn@redhat.com> writes: > >> Hi Markus, >> should I rebase it or no need and can maintainer do it before push? > Depends on the maintainer :) > > I'd respin. >
diff --git a/vl.c b/vl.c index 25b8f2f..563ae67 100644 --- a/vl.c +++ b/vl.c @@ -2671,6 +2671,11 @@ static QEMUMachine *machine_parse(const char *name) if (machine) { return machine; } + + if (name && !is_help_option(name)) { + printf("Error: Unsupported machine type '%s'\n", name); + } + printf("Supported machines are:\n"); for (m = first_machine; m != NULL; m = m->next) { if (m->alias) {
Output error message when user provides the invalid machine type on the command line. This also saves time to find what issue is when you upgrade from one version of qemu to another version that doesn't support required machine type any longer. The patch is checked using ./scripts/checkpatch.pl script and also is_help_option() function is being used. Michal Signed-off-by: Michal Novotny <minovotn@redhat.com> --- vl.c | 5 +++++ 1 file changed, 5 insertions(+)