From patchwork Tue Apr 21 19:04:37 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Bartlomiej Zolnierkiewicz X-Patchwork-Id: 26280 X-Patchwork-Delegate: paulus@samba.org Return-Path: X-Original-To: patchwork-incoming@bilbo.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from ozlabs.org (ozlabs.org [203.10.76.45]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mx.ozlabs.org", Issuer "CA Cert Signing Authority" (verified OK)) by bilbo.ozlabs.org (Postfix) with ESMTPS id 2B0E2B6F44 for ; Wed, 22 Apr 2009 05:30:53 +1000 (EST) Received: by ozlabs.org (Postfix) id A118ADEB55; Wed, 22 Apr 2009 05:17:11 +1000 (EST) Delivered-To: patchwork-incoming@ozlabs.org Received: from ozlabs.org (localhost [127.0.0.1]) by ozlabs.org (Postfix) with ESMTP id 9B573DFEC9 for ; Wed, 22 Apr 2009 05:17:11 +1000 (EST) X-Original-To: Linuxppc-dev@ozlabs.org Delivered-To: Linuxppc-dev@ozlabs.org Received: from mu-out-0910.google.com (mu-out-0910.google.com [209.85.134.189]) by ozlabs.org (Postfix) with ESMTP id 539B0DE368 for ; Wed, 22 Apr 2009 05:00:54 +1000 (EST) Received: by mu-out-0910.google.com with SMTP id w9so1378383mue.9 for ; Tue, 21 Apr 2009 12:00:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:subject:date :user-agent:cc:references:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:message-id; bh=hNNmb95T+WLTfLPGFzrWaAetmjes/v8jT+hGWt8ey3c=; b=BoGgkPM8UBt2sxAG+qgcrvpB0or1Xco/0hZc/zorCFsqv3cfpdaxRFdK/1njGY5ZhY cQmj28uCs/er1T7+HnIX2Kwd23P9jyRGo3lYrFW5kVDM0+Tay66FV0YzMjoaEP9n50WJ S7WWYtT4VnKtazozX1r70cgQAZLhG7X+jQ5bY= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:subject:date:user-agent:cc:references:in-reply-to :mime-version:content-type:content-transfer-encoding :content-disposition:message-id; b=IMBfiOQ0HnL+rm71QAfmBXqBXHb6VxK8QQUTuL7D6og0mrNtdFFqNS8kRF4pbV0sIl aKcGHIezjTaua0YADQypvA/snO8I9llk6NYp3Jd/YgouTz77VBF5hJ7BMKL7RRqqdPP9 a0Bqv0AYMFt0sQ19uFH1ImBK6QFhTDJNpapU4= Received: by 10.103.222.1 with SMTP id z1mr3993301muq.100.1240340452906; Tue, 21 Apr 2009 12:00:52 -0700 (PDT) Received: from localhost.localdomain (chello089077051219.chello.pl [89.77.51.219]) by mx.google.com with ESMTPS id 7sm17999986mup.28.2009.04.21.12.00.51 (version=TLSv1/SSLv3 cipher=RC4-MD5); Tue, 21 Apr 2009 12:00:51 -0700 (PDT) From: Bartlomiej Zolnierkiewicz To: subrata@linux.vnet.ibm.com Subject: Re: [BUILD FAILURE 07/12] Next April 14 : PPC64 randconfig [drivers/ide/pmac.c] Date: Tue, 21 Apr 2009 21:04:37 +0200 User-Agent: KMail/1.11.1 (Linux/2.6.29-next-20090403; KDE/4.2.1; i686; ; ) References: <1239733759.5344.79.camel@subratamodak.linux.ibm.com> In-Reply-To: <1239733759.5344.79.camel@subratamodak.linux.ibm.com> MIME-Version: 1.0 Content-Disposition: inline Message-Id: <200904212104.38664.bzolnier@gmail.com> Cc: sachinp , Stephen Rothwell , IDE/ATA development list , Greg KH , linux-kernel , "Rafael J. Wysocki" , Linuxppc-dev , linux-next , Paul Mackerras , Alexander Beregalov X-BeenThere: linuxppc-dev@ozlabs.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@ozlabs.org Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@ozlabs.org On Tuesday 14 April 2009 20:29:19 Subrata Modak wrote: > Observed the following build error: > --- > CC [M] drivers/ide/pmac.o > drivers/ide/pmac.c: In function ‘pmac_ide_init_dev’: > drivers/ide/pmac.c:955: error: implicit declaration of function > ‘check_media_bay_by_base’ > drivers/ide/pmac.c: In function ‘pmac_ide_setup_device’: > drivers/ide/pmac.c:1090: error: implicit declaration of function > ‘media_bay_set_ide_infos’ > make[2]: *** [drivers/ide/pmac.o] Error 1 > make[1]: *** [drivers/ide] Error 2 > make: *** [drivers] Error 2 > --- Should be fixed by: From: Bartlomiej Zolnierkiewicz Subject: [PATCH] ide-pmac: fix modular build for CONFIG_PMAC_MEDIABAY=y On Tuesday 14 April 2009 20:29:19 Subrata Modak wrote: > Observed the following build error: > --- > CC [M] drivers/ide/pmac.o > drivers/ide/pmac.c: In function ‘pmac_ide_init_dev’: > drivers/ide/pmac.c:955: error: implicit declaration of function > ‘check_media_bay_by_base’ > drivers/ide/pmac.c: In function ‘pmac_ide_setup_device’: > drivers/ide/pmac.c:1090: error: implicit declaration of function > ‘media_bay_set_ide_infos’ > make[2]: *** [drivers/ide/pmac.o] Error 1 > make[1]: *** [drivers/ide] Error 2 > make: *** [drivers] Error 2 > --- IDE PMAC host driver can be modular now so we need to export check_media_bay_by_base() and media_bay_set_ide_infos(). Reported-by: Subrata Modak Cc: Paul Mackerras Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/macintosh/mediabay.c | 2 ++ 1 file changed, 2 insertions(+) Index: b/drivers/macintosh/mediabay.c =================================================================== --- a/drivers/macintosh/mediabay.c +++ b/drivers/macintosh/mediabay.c @@ -447,6 +447,7 @@ int check_media_bay_by_base(unsigned lon return -ENODEV; } +EXPORT_SYMBOL_GPL(check_media_bay_by_base); int media_bay_set_ide_infos(struct device_node* which_bay, unsigned long base, int irq, ide_hwif_t *hwif) @@ -486,6 +487,7 @@ int media_bay_set_ide_infos(struct devic return -ENODEV; } +EXPORT_SYMBOL_GPL(media_bay_set_ide_infos); #endif /* CONFIG_BLK_DEV_IDE_PMAC */ static void media_bay_step(int i)