Patchwork [for-1.6] linux-user: Return success from m68k set_thread_area syscall

login
register
mail settings
Submitter Peter Maydell
Date July 29, 2013, 10:31 a.m.
Message ID <1375093909-13653-1-git-send-email-peter.maydell@linaro.org>
Download mbox | patch
Permalink /patch/262709/
State New
Headers show

Comments

Peter Maydell - July 29, 2013, 10:31 a.m.
The m68k set_thread_area syscall implementation failed to set the
return value. Correctly set it zero, since this syscall will always
succeed.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
Oops. Spotted by clang.

 linux-user/syscall.c |    1 +
 1 file changed, 1 insertion(+)
Anthony Liguori - Aug. 2, 2013, 12:35 p.m.
Applied.  Thanks.

Regards,

Anthony Liguori

Patch

diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 3f6db4b..f986548 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -8523,6 +8523,7 @@  abi_long do_syscall(void *cpu_env, int num, abi_long arg1,
       {
           TaskState *ts = ((CPUArchState *)cpu_env)->opaque;
           ts->tp_value = arg1;
+          ret = 0;
           break;
       }
 #else