diff mbox

[v2] ser2net: bump to 2.9

Message ID 1375013588-2666-1-git-send-email-yegorslists@googlemail.com
State Accepted
Headers show

Commit Message

Yegor Yefremov July 28, 2013, 12:13 p.m. UTC
SER2NET_AUTORECONF is needed because of libtool version mismatch.
See error message bellow:

/bin/bash ./libtool --tag=CC   --mode=link gcc -Wall -g -O2   -o
ser2net controller.o dataxfer.o devcfg.o readconfig.o selector.o
ser2net.o utils.o telnet.o buffer.o  -lnsl
libtool: Version mismatch error.  This is libtool 2.4.2
Debian-2.4.2-1ubuntu1, but the
libtool: definition of this LT_INIT comes from libtool 2.2.6b.
libtool: You should recreate aclocal.m4 with macros from libtool 2.4.2
Debian-2.4.2-1ubuntu1
libtool: and run autoconf again.
make: *** [ser2net] Error 63

Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
---
Changes since v1: added reason for autoreconf

 package/ser2net/ser2net.mk | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

--
1.8.1.2

Comments

Baruch Siach July 28, 2013, 12:23 p.m. UTC | #1
Hi Yegor,

On Sun, Jul 28, 2013 at 02:13:08PM +0200, Yegor Yefremov wrote:
> SER2NET_AUTORECONF is needed because of libtool version mismatch.
> See error message bellow:
> 
> /bin/bash ./libtool --tag=CC   --mode=link gcc -Wall -g -O2   -o
> ser2net controller.o dataxfer.o devcfg.o readconfig.o selector.o
> ser2net.o utils.o telnet.o buffer.o  -lnsl
> libtool: Version mismatch error.  This is libtool 2.4.2
> Debian-2.4.2-1ubuntu1, but the
> libtool: definition of this LT_INIT comes from libtool 2.2.6b.
> libtool: You should recreate aclocal.m4 with macros from libtool 2.4.2
> Debian-2.4.2-1ubuntu1
> libtool: and run autoconf again.
> make: *** [ser2net] Error 63

Having a detailed commit log is good. But IMO a comment should also appear in 
the .mk file itself for the next bumper to see.

baruch

> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
> ---
> Changes since v1: added reason for autoreconf
> 
>  package/ser2net/ser2net.mk | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/package/ser2net/ser2net.mk b/package/ser2net/ser2net.mk
> index 588571c..cc728a6 100644
> --- a/package/ser2net/ser2net.mk
> +++ b/package/ser2net/ser2net.mk
> @@ -4,8 +4,9 @@
>  #
>  ################################################################################
> 
> -SER2NET_VERSION = 2.8
> +SER2NET_VERSION = 2.9
>  SER2NET_SITE = http://downloads.sourceforge.net/project/ser2net/ser2net
> +SER2NET_AUTORECONF = YES
>  SER2NET_LICENSE = GPLv2+
>  SER2NET_LICENSE_FILES = COPYING
> 
> --
> 1.8.1.2
Thomas Petazzoni July 28, 2013, 2:35 p.m. UTC | #2
Dear Yegor Yefremov,

On Sun, 28 Jul 2013 14:13:08 +0200, Yegor Yefremov wrote:

> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
> ---
> Changes since v1: added reason for autoreconf
> 
>  package/ser2net/ser2net.mk | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Applied, thanks. As suggested by Baruch, I've added a comment inside
the .mk file itself for the autoreconf line.

Thomas
Yegor Yefremov July 28, 2013, 3:03 p.m. UTC | #3
On Sun, Jul 28, 2013 at 4:35 PM, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
> Dear Yegor Yefremov,
>
> On Sun, 28 Jul 2013 14:13:08 +0200, Yegor Yefremov wrote:
>
>> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
>> ---
>> Changes since v1: added reason for autoreconf
>>
>>  package/ser2net/ser2net.mk | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> Applied, thanks. As suggested by Baruch, I've added a comment inside
> the .mk file itself for the autoreconf line.

Thanks. So ignore v3.

Yegor
diff mbox

Patch

diff --git a/package/ser2net/ser2net.mk b/package/ser2net/ser2net.mk
index 588571c..cc728a6 100644
--- a/package/ser2net/ser2net.mk
+++ b/package/ser2net/ser2net.mk
@@ -4,8 +4,9 @@ 
 #
 ################################################################################

-SER2NET_VERSION = 2.8
+SER2NET_VERSION = 2.9
 SER2NET_SITE = http://downloads.sourceforge.net/project/ser2net/ser2net
+SER2NET_AUTORECONF = YES
 SER2NET_LICENSE = GPLv2+
 SER2NET_LICENSE_FILES = COPYING