musicpal: Fix typo in name of local function

The misspelling was spotted by Andreas Färber.

Signed-off-by: Stefan Weil <sw@weilnetz.de>
---
 hw/arm/musicpal.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

On 2013-07-28 07:54, Stefan Weil wrote:
> The misspelling was spotted by Andreas Färber.
> 
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
>  hw/arm/musicpal.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/hw/arm/musicpal.c b/hw/arm/musicpal.c
> index b06d442..ddddd27 100644
> --- a/hw/arm/musicpal.c
> +++ b/hw/arm/musicpal.c
> @@ -534,7 +534,7 @@ static void lcd_invalidate(void *opaque)
>  {
>  }
>  
> -static void musicpal_lcd_gpio_brigthness_in(void *opaque, int irq, int level)
> +static void musicpal_lcd_gpio_brightness_in(void *opaque, int irq, int level)
>  {
>      musicpal_lcd_state *s = opaque;
>      s->brightness &= ~(1 << irq);
> @@ -619,7 +619,7 @@ static int musicpal_lcd_init(SysBusDevice *dev)
>      s->con = graphic_console_init(DEVICE(dev), &musicpal_gfx_ops, s);
>      qemu_console_resize(s->con, 128*3, 64*3);
>  
> -    qdev_init_gpio_in(&dev->qdev, musicpal_lcd_gpio_brigthness_in, 3);
> +    qdev_init_gpio_in(&dev->qdev, musicpal_lcd_gpio_brightness_in, 3);
>  
>      return 0;
>  }
> 

Reviewed-by: Jan Kiszka <jan.kiszka@web.de>

Am 28.07.2013 07:54, schrieb Stefan Weil:
> The misspelling was spotted by Andreas Färber.
> 
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
>  hw/arm/musicpal.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/hw/arm/musicpal.c b/hw/arm/musicpal.c
> index b06d442..ddddd27 100644
> --- a/hw/arm/musicpal.c
> +++ b/hw/arm/musicpal.c
> @@ -534,7 +534,7 @@ static void lcd_invalidate(void *opaque)
>  {
>  }
>  
> -static void musicpal_lcd_gpio_brigthness_in(void *opaque, int irq, int level)
> +static void musicpal_lcd_gpio_brightness_in(void *opaque, int irq, int level)
>  {
>      musicpal_lcd_state *s = opaque;
>      s->brightness &= ~(1 << irq);
> @@ -619,7 +619,7 @@ static int musicpal_lcd_init(SysBusDevice *dev)
>      s->con = graphic_console_init(DEVICE(dev), &musicpal_gfx_ops, s);
>      qemu_console_resize(s->con, 128*3, 64*3);
>  
> -    qdev_init_gpio_in(&dev->qdev, musicpal_lcd_gpio_brigthness_in, 3);
> +    qdev_init_gpio_in(&dev->qdev, musicpal_lcd_gpio_brightness_in, 3);
>  
>      return 0;
>  }

Reviewed-by: Andreas Färber <afaerber@suse.de>

but to clarify: I had notified you not to send this small patch, which
now conflicts with my argument cleanup, but to add this typo to your
blacklist to check the whole codebase for similar typos. Are there none?

But since this is a sensible cleanup anyway, I'll just put a copy into
my queue before the refactoring, to avoid merge conflicts with -trivial.

Thanks,
Andreas

Am 28.07.2013 11:46, schrieb Andreas Färber:
> Am 28.07.2013 07:54, schrieb Stefan Weil:
>> The misspelling was spotted by Andreas Färber.
>>
>> Signed-off-by: Stefan Weil <sw@weilnetz.de>
>> ---
>>  hw/arm/musicpal.c |    4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
[...]
>> Reviewed-by: Andreas Färber <afaerber@suse.de>
>>
>> but to clarify: I had notified you not to send this small patch, which
>> now conflicts with my argument cleanup, but to add this typo to your
>> blacklist to check the whole codebase for similar typos. Are there none?
>>
>> But since this is a sensible cleanup anyway, I'll just put a copy into
>> my queue before the refactoring, to avoid merge conflicts with -trivial.
>>
>> Thanks,
>> Andreas

Codespell uses a list of common misspellings which is an enhanced versionof
https://en.wikipedia.org/wiki/Wikipedia:Lists_of_common_misspellings/For_machines.

"Brigthness" was not among those words. Even if it were, codespell would not
detect it in a composed word like musicpal_lcd_gpio_brigthness_in.

With some small modifications (split words at [-_]), codespell detects more
misspellings in QEMU: bandwith, issueing, propietary, threshhold.

Even more could be detected by analysing composed words.

Regards,
Stefan