Patchwork Zynq clk fixes

login
register
mail settings
Submitter Michal Simek
Date July 26, 2013, 12:09 p.m.
Message ID <51F26716.6030701@monstr.eu>
Download mbox
Permalink /patch/262137/
State New
Headers show

Pull-request

git://git.xilinx.com/linux-xlnx.git tags/zynq-clk-fixes-for-3.11

Comments

Michal Simek - July 26, 2013, 12:09 p.m.
Hi Mike, [cc: Arnd and Olof]

Soren has found two bug fixes in zynq clk code.
Can you please add these two patches to your tree?
Will be great if you can add them to v3.11.

Arnd, Olof: I expect that all these clock changes should go through Mike.
If I am wrong please let me know.

Thanks,
Michal


The following changes since commit ad81f0545ef01ea651886dddac4bef6cec930092:

  Linux 3.11-rc1 (2013-07-14 15:18:27 -0700)

are available in the git repository at:

  git://git.xilinx.com/linux-xlnx.git tags/zynq-clk-fixes-for-3.11

for you to fetch changes up to 97d58aef394831f6f0583653de29e03886a0e09e:

  clk/zynq/clkc: Add CLK_SET_RATE_PARENT flag to ethernet muxes (2013-07-17 08:36:53 +0200)

----------------------------------------------------------------
arm: Xilinx Zynq clock fixes for v3.11

- Fix watchdog clock registration
- Fix gem clock propagation

----------------------------------------------------------------
Soren Brinkmann (2):
      clk/zynq/clkc: Add dedicated spinlock for the SWDT
      clk/zynq/clkc: Add CLK_SET_RATE_PARENT flag to ethernet muxes

 drivers/clk/zynq/clkc.c | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)
Mike Turquette - July 26, 2013, 8:07 p.m.
Quoting Michal Simek (2013-07-26 05:09:58)
> Hi Mike, [cc: Arnd and Olof]
> 
> Soren has found two bug fixes in zynq clk code.
> Can you please add these two patches to your tree?
> Will be great if you can add them to v3.11.
> 
> Arnd, Olof: I expect that all these clock changes should go through Mike.
> If I am wrong please let me know.

Looks right to me. Do these fix regressions in the current -rc cycle?

Regards,
Mike

> 
> Thanks,
> Michal
> 
> 
> The following changes since commit ad81f0545ef01ea651886dddac4bef6cec930092:
> 
>   Linux 3.11-rc1 (2013-07-14 15:18:27 -0700)
> 
> are available in the git repository at:
> 
>   git://git.xilinx.com/linux-xlnx.git tags/zynq-clk-fixes-for-3.11
> 
> for you to fetch changes up to 97d58aef394831f6f0583653de29e03886a0e09e:
> 
>   clk/zynq/clkc: Add CLK_SET_RATE_PARENT flag to ethernet muxes (2013-07-17 08:36:53 +0200)
> 
> ----------------------------------------------------------------
> arm: Xilinx Zynq clock fixes for v3.11
> 
> - Fix watchdog clock registration
> - Fix gem clock propagation
> 
> ----------------------------------------------------------------
> Soren Brinkmann (2):
>       clk/zynq/clkc: Add dedicated spinlock for the SWDT
>       clk/zynq/clkc: Add CLK_SET_RATE_PARENT flag to ethernet muxes
> 
>  drivers/clk/zynq/clkc.c | 13 ++++++++-----
>  1 file changed, 8 insertions(+), 5 deletions(-)
> 
> -- 
> Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
> w: www.monstr.eu p: +42-0-721842854
> Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
> Maintainer of Linux kernel - Xilinx Zynq ARM architecture
> Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform
Soren Brinkmann - July 26, 2013, 9:11 p.m.
On Fri, Jul 26, 2013 at 01:07:03PM -0700, Mike Turquette wrote:
> Quoting Michal Simek (2013-07-26 05:09:58)
> > Hi Mike, [cc: Arnd and Olof]
> > 
> > Soren has found two bug fixes in zynq clk code.
> > Can you please add these two patches to your tree?
> > Will be great if you can add them to v3.11.
> > 
> > Arnd, Olof: I expect that all these clock changes should go through Mike.
> > If I am wrong please let me know.
> 
> Looks right to me. Do these fix regressions in the current -rc cycle?

I doubt there are real regressions. But since it's still early in
the release cycle and the driver was added in this merge window, I'd prefer
having it hit a release kernel with these fixes included.

	Sören
Mike Turquette - July 26, 2013, 10:25 p.m.
Quoting Sören Brinkmann (2013-07-26 14:11:52)
> On Fri, Jul 26, 2013 at 01:07:03PM -0700, Mike Turquette wrote:
> > Quoting Michal Simek (2013-07-26 05:09:58)
> > > Hi Mike, [cc: Arnd and Olof]
> > > 
> > > Soren has found two bug fixes in zynq clk code.
> > > Can you please add these two patches to your tree?
> > > Will be great if you can add them to v3.11.
> > > 
> > > Arnd, Olof: I expect that all these clock changes should go through Mike.
> > > If I am wrong please let me know.
> > 
> > Looks right to me. Do these fix regressions in the current -rc cycle?
> 
> I doubt there are real regressions. But since it's still early in
> the release cycle and the driver was added in this merge window, I'd prefer
> having it hit a release kernel with these fixes included.

I've taken these into clk-fixes and added the following to the changelog
for each patch:

"This does not fix a specific regression but the clock driver was merged
for 3.11-rc1, so best to fix the known bugs before the release."

Regards,
Mike

> 
>         Sören
Soren Brinkmann - July 26, 2013, 10:26 p.m.
On Fri, Jul 26, 2013 at 03:25:01PM -0700, Mike Turquette wrote:
> Quoting Sören Brinkmann (2013-07-26 14:11:52)
> > On Fri, Jul 26, 2013 at 01:07:03PM -0700, Mike Turquette wrote:
> > > Quoting Michal Simek (2013-07-26 05:09:58)
> > > > Hi Mike, [cc: Arnd and Olof]
> > > > 
> > > > Soren has found two bug fixes in zynq clk code.
> > > > Can you please add these two patches to your tree?
> > > > Will be great if you can add them to v3.11.
> > > > 
> > > > Arnd, Olof: I expect that all these clock changes should go through Mike.
> > > > If I am wrong please let me know.
> > > 
> > > Looks right to me. Do these fix regressions in the current -rc cycle?
> > 
> > I doubt there are real regressions. But since it's still early in
> > the release cycle and the driver was added in this merge window, I'd prefer
> > having it hit a release kernel with these fixes included.
> 
> I've taken these into clk-fixes and added the following to the changelog
> for each patch:
> 
> "This does not fix a specific regression but the clock driver was merged
> for 3.11-rc1, so best to fix the known bugs before the release."

Thanks.

	Sören
Michal Simek - Aug. 13, 2013, 2:30 p.m.
Hi Mike,

On 07/27/2013 12:25 AM, Mike Turquette wrote:
> Quoting Sören Brinkmann (2013-07-26 14:11:52)
>> On Fri, Jul 26, 2013 at 01:07:03PM -0700, Mike Turquette wrote:
>>> Quoting Michal Simek (2013-07-26 05:09:58)
>>>> Hi Mike, [cc: Arnd and Olof]
>>>>
>>>> Soren has found two bug fixes in zynq clk code.
>>>> Can you please add these two patches to your tree?
>>>> Will be great if you can add them to v3.11.
>>>>
>>>> Arnd, Olof: I expect that all these clock changes should go through Mike.
>>>> If I am wrong please let me know.
>>>
>>> Looks right to me. Do these fix regressions in the current -rc cycle?
>>
>> I doubt there are real regressions. But since it's still early in
>> the release cycle and the driver was added in this merge window, I'd prefer
>> having it hit a release kernel with these fixes included.
> 
> I've taken these into clk-fixes and added the following to the changelog
> for each patch:
> 
> "This does not fix a specific regression but the clock driver was merged
> for 3.11-rc1, so best to fix the known bugs before the release."

Can you please tell me where you have added these two patches?
      clk/zynq/clkc: Add dedicated spinlock for the SWDT
      clk/zynq/clkc: Add CLK_SET_RATE_PARENT flag to ethernet muxes

I can't see them in clk-fixes branch (this branch is pretty obsolete).
http://git.linaro.org/gitweb?p=people/mturquette/linux.git;a=summary

Thanks,
Michal
Mike Turquette - Aug. 15, 2013, 5:58 p.m.
Quoting Michal Simek (2013-08-13 07:30:16)
> Hi Mike,
> 
> On 07/27/2013 12:25 AM, Mike Turquette wrote:
> > Quoting Sören Brinkmann (2013-07-26 14:11:52)
> >> On Fri, Jul 26, 2013 at 01:07:03PM -0700, Mike Turquette wrote:
> >>> Quoting Michal Simek (2013-07-26 05:09:58)
> >>>> Hi Mike, [cc: Arnd and Olof]
> >>>>
> >>>> Soren has found two bug fixes in zynq clk code.
> >>>> Can you please add these two patches to your tree?
> >>>> Will be great if you can add them to v3.11.
> >>>>
> >>>> Arnd, Olof: I expect that all these clock changes should go through Mike.
> >>>> If I am wrong please let me know.
> >>>
> >>> Looks right to me. Do these fix regressions in the current -rc cycle?
> >>
> >> I doubt there are real regressions. But since it's still early in
> >> the release cycle and the driver was added in this merge window, I'd prefer
> >> having it hit a release kernel with these fixes included.
> > 
> > I've taken these into clk-fixes and added the following to the changelog
> > for each patch:
> > 
> > "This does not fix a specific regression but the clock driver was merged
> > for 3.11-rc1, so best to fix the known bugs before the release."
> 
> Can you please tell me where you have added these two patches?
>       clk/zynq/clkc: Add dedicated spinlock for the SWDT
>       clk/zynq/clkc: Add CLK_SET_RATE_PARENT flag to ethernet muxes
> 
> I can't see them in clk-fixes branch (this branch is pretty obsolete).
> http://git.linaro.org/gitweb?p=people/mturquette/linux.git;a=summary

Those have been sent off to Linus in the clk-fixes-for-linus tag.

Regards,
Mike

> 
> Thanks,
> Michal
> 
> 
> -- 
> Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
> w: www.monstr.eu p: +42-0-721842854
> Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
> Maintainer of Linux kernel - Xilinx Zynq ARM architecture
> Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform