From patchwork Fri Jul 26 10:30:56 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Robert Yang X-Patchwork-Id: 262118 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id BC4C92C00BD for ; Fri, 26 Jul 2013 20:33:17 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758531Ab3GZKdN (ORCPT ); Fri, 26 Jul 2013 06:33:13 -0400 Received: from mail1.windriver.com ([147.11.146.13]:56206 "EHLO mail1.windriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758510Ab3GZKdL (ORCPT ); Fri, 26 Jul 2013 06:33:11 -0400 Received: from ALA-HCB.corp.ad.wrs.com (ala-hcb.corp.ad.wrs.com [147.11.189.41]) by mail1.windriver.com (8.14.5/8.14.3) with ESMTP id r6QAX89Z029283 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=FAIL); Fri, 26 Jul 2013 03:33:08 -0700 (PDT) Received: from pek-hostel-vm06.wrs.com (128.224.153.176) by ALA-HCB.corp.ad.wrs.com (147.11.189.41) with Microsoft SMTP Server id 14.2.342.3; Fri, 26 Jul 2013 03:33:06 -0700 From: Robert Yang To: CC: , , Subject: [PATCH 1/2] debugfs.c: the max length of debugfs argument is too short Date: Fri, 26 Jul 2013 18:30:56 +0800 Message-ID: <1374834657-17091-2-git-send-email-liezhi.yang@windriver.com> X-Mailer: git-send-email 1.8.1.2 In-Reply-To: <1374834657-17091-1-git-send-email-liezhi.yang@windriver.com> References: <1374834657-17091-1-git-send-email-liezhi.yang@windriver.com> MIME-Version: 1.0 Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org The max length of debugfs argument is 256 which is too short, the arguments are two paths, the PATH_MAX is 4096 according to /usr/include/linux/limits.h, use 2048 (4096 / 2) is a reasonable value. Signed-off-by: Robert Yang Acked-by: Darren Hart --- debugfs/debugfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/debugfs/debugfs.c b/debugfs/debugfs.c index dcf16e2..b77d0b5 100644 --- a/debugfs/debugfs.c +++ b/debugfs/debugfs.c @@ -2300,7 +2300,7 @@ void do_dump_mmp(int argc EXT2FS_ATTR((unused)), char *argv[]) static int source_file(const char *cmd_file, int ss_idx) { FILE *f; - char buf[256]; + char buf[2048]; char *cp; int exit_status = 0; int retval;