Patchwork powerpc/QE: move QE_GPIO Kconfig symbol into the platforms/Kconfig

login
register
mail settings
Submitter Anton Vorontsov
Date Oct. 3, 2008, 7:40 p.m.
Message ID <20081003194036.GA9323@oksana.dev.rtsoft.ru>
Download mbox | patch
Permalink /patch/2620/
State Accepted, archived
Commit 5c091193e4a12e88930a0bb3ed3632c51e926a76
Delegated to: Kumar Gala
Headers show

Comments

Anton Vorontsov - Oct. 3, 2008, 7:40 p.m.
Specifying user-selectable option in the qe_lib/Kconfig was a bad idea
because the qe_lib/Kconfig is included into the top level Kconfig, and
thus the QE_GPIO option appears at the top level menu.

This patch effectively moves the QE_GPIO option under the platform menu
instead.

Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
---

On Fri, Oct 03, 2008 at 12:48:31PM -0500, Kumar Gala wrote:
[...]
> I want to leave the "hidden" options in qe_lib/Kconfig.. just move the  
> user selectable one (QE_GPIO) in to platforms/Kconfig

Here it is.

 arch/powerpc/platforms/Kconfig     |    9 +++++++++
 arch/powerpc/sysdev/qe_lib/Kconfig |    9 ---------
 2 files changed, 9 insertions(+), 9 deletions(-)
Kumar Gala - Oct. 3, 2008, 9:55 p.m.
On Oct 3, 2008, at 2:40 PM, Anton Vorontsov wrote:

> Specifying user-selectable option in the qe_lib/Kconfig was a bad idea
> because the qe_lib/Kconfig is included into the top level Kconfig, and
> thus the QE_GPIO option appears at the top level menu.
>
> This patch effectively moves the QE_GPIO option under the platform  
> menu
> instead.
>
> Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
> ---
>
> On Fri, Oct 03, 2008 at 12:48:31PM -0500, Kumar Gala wrote:
> [...]
>> I want to leave the "hidden" options in qe_lib/Kconfig.. just move  
>> the
>> user selectable one (QE_GPIO) in to platforms/Kconfig
>
> Here it is.
>
> arch/powerpc/platforms/Kconfig     |    9 +++++++++
> arch/powerpc/sysdev/qe_lib/Kconfig |    9 ---------
> 2 files changed, 9 insertions(+), 9 deletions(-)

applied

- k

Patch

diff --git a/arch/powerpc/platforms/Kconfig b/arch/powerpc/platforms/Kconfig
index 8871185..71845d7 100644
--- a/arch/powerpc/platforms/Kconfig
+++ b/arch/powerpc/platforms/Kconfig
@@ -249,6 +249,15 @@  config QUICC_ENGINE
 	  Selecting this option means that you wish to build a kernel
 	  for a machine with a QE coprocessor.
 
+config QE_GPIO
+	bool "QE GPIO support"
+	depends on QUICC_ENGINE
+	select GENERIC_GPIO
+	select ARCH_REQUIRE_GPIOLIB
+	help
+	  Say Y here if you're going to use hardware that connects to the
+	  QE GPIOs.
+
 config CPM2
 	bool "Enable support for the CPM2 (Communications Processor Module)"
 	depends on MPC85xx || 8260
diff --git a/arch/powerpc/sysdev/qe_lib/Kconfig b/arch/powerpc/sysdev/qe_lib/Kconfig
index 1ce5464..76ffbc4 100644
--- a/arch/powerpc/sysdev/qe_lib/Kconfig
+++ b/arch/powerpc/sysdev/qe_lib/Kconfig
@@ -24,12 +24,3 @@  config QE_USB
 	bool
 	help
 	  QE USB Host Controller support
-
-config QE_GPIO
-	bool "QE GPIO support"
-	depends on QUICC_ENGINE
-	select GENERIC_GPIO
-	select ARCH_REQUIRE_GPIOLIB
-	help
-	  Say Y here if you're going to use hardware that connects to the
-	  QE GPIOs.