Patchwork powerpc: don't disable SATA interrupts on Freescale MPC8610 HPCD

login
register
mail settings
Submitter Timur Tabi
Date April 20, 2009, 3:54 p.m.
Message ID <1240242875-3247-1-git-send-email-timur@freescale.com>
Download mbox | patch
Permalink /patch/26199/
State Accepted
Headers show

Comments

Timur Tabi - April 20, 2009, 3:54 p.m.
The ULI 1575 PCI quirk function for the Freescale MPC8610 HPCD was disabling
the SATA INTx interrupt, even when SATA support was enabled.  This was safe,
because the SATA driver re-enabled it.  But with commit a5bfc471 ("ahci: drop
intx manipulation on msi enable"), the driver no longer does this, and so SATA
support on the 8610 HPCD is broken.

The original quirk function disabled INTx because it caused some other
interrupt problem during early development on this board, but no one remembers
any more what that problem was, and it doesn't seem to occur any more.

Signed-off-by: Timur Tabi <timur@freescale.com>
---
 arch/powerpc/platforms/fsl_uli1575.c |    5 -----
 1 files changed, 0 insertions(+), 5 deletions(-)
Kumar Gala - April 21, 2009, 8:35 p.m.
On Apr 20, 2009, at 10:54 AM, Timur Tabi wrote:

> The ULI 1575 PCI quirk function for the Freescale MPC8610 HPCD was  
> disabling
> the SATA INTx interrupt, even when SATA support was enabled.  This  
> was safe,
> because the SATA driver re-enabled it.  But with commit a5bfc471  
> ("ahci: drop
> intx manipulation on msi enable"), the driver no longer does this,  
> and so SATA
> support on the 8610 HPCD is broken.
>
> The original quirk function disabled INTx because it caused some other
> interrupt problem during early development on this board, but no one  
> remembers
> any more what that problem was, and it doesn't seem to occur any more.
>
> Signed-off-by: Timur Tabi <timur@freescale.com>
> ---
> arch/powerpc/platforms/fsl_uli1575.c |    5 -----
> 1 files changed, 0 insertions(+), 5 deletions(-)


applied to merge.

- k

Patch

diff --git a/arch/powerpc/platforms/fsl_uli1575.c b/arch/powerpc/platforms/fsl_uli1575.c
index 1db6b9e..65a35f3 100644
--- a/arch/powerpc/platforms/fsl_uli1575.c
+++ b/arch/powerpc/platforms/fsl_uli1575.c
@@ -275,11 +275,6 @@  static void __devinit hpcd_quirk_uli5288(struct pci_dev *dev)
 	if (!machine_is(mpc86xx_hpcd))
 		return;
 
-	/* Interrupt Disable, Needed when SATA disabled */
-	pci_read_config_word(dev, PCI_COMMAND, &temp);
-	temp |= 1<<10;
-	pci_write_config_word(dev, PCI_COMMAND, temp);
-
 	pci_read_config_byte(dev, 0x83, &c);
 	c |= 0x80;
 	pci_write_config_byte(dev, 0x83, c);