Patchwork [net-next] be2net: don't use dev_err when AER enabling fails

login
register
mail settings
Submitter Ivan Vecera
Date July 25, 2013, 2:10 p.m.
Message ID <1374761455-28193-1-git-send-email-ivecera@redhat.com>
Download mbox | patch
Permalink /patch/261704/
State Accepted
Delegated to: David Miller
Headers show

Comments

Ivan Vecera - July 25, 2013, 2:10 p.m.
The driver uses dev_err when enabling of AER fails (e.g. PCIe AER is not
supported). The dev_info is more appropriate to avoid console pollution.

Cc: sathya.perla@emulex.com
Cc: subbu.seetharaman@emulex.com
Cc: ajit.khaparde@emulex.com
Signed-off-by: Ivan Vecera <ivecera@redhat.com>
---
 drivers/net/ethernet/emulex/benet/be_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
David Miller - July 30, 2013, 7 a.m.
From: Ivan Vecera <ivecera@redhat.com>
Date: Thu, 25 Jul 2013 16:10:55 +0200

> The driver uses dev_err when enabling of AER fails (e.g. PCIe AER is not
> supported). The dev_info is more appropriate to avoid console pollution.
> 
> Cc: sathya.perla@emulex.com
> Cc: subbu.seetharaman@emulex.com
> Cc: ajit.khaparde@emulex.com
> Signed-off-by: Ivan Vecera <ivecera@redhat.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/net/ethernet/emulex/benet/be_main.c b/drivers/net/ethernet/emulex/benet/be_main.c
index 67deb21..3df1503 100644
--- a/drivers/net/ethernet/emulex/benet/be_main.c
+++ b/drivers/net/ethernet/emulex/benet/be_main.c
@@ -4232,7 +4232,7 @@  static int be_probe(struct pci_dev *pdev, const struct pci_device_id *pdev_id)
 
 	status = pci_enable_pcie_error_reporting(pdev);
 	if (status)
-		dev_err(&pdev->dev, "Could not use PCIe error reporting\n");
+		dev_info(&pdev->dev, "Could not use PCIe error reporting\n");
 
 	status = be_ctrl_init(adapter);
 	if (status)