Patchwork e100: dump small buffers via %*phC

login
register
mail settings
Submitter Andy Shevchenko
Date July 25, 2013, 11:24 a.m.
Message ID <1374751459-17994-1-git-send-email-andriy.shevchenko@linux.intel.com>
Download mbox | patch
Permalink /patch/261673/
State Awaiting Upstream
Delegated to: David Miller
Headers show

Comments

Andy Shevchenko - July 25, 2013, 11:24 a.m.
There is nice specifier in kernel that allows us to print small buffers easily.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/net/ethernet/intel/e100.c | 15 ++++++---------
 1 file changed, 6 insertions(+), 9 deletions(-)
Jeff Kirsher - July 26, 2013, 11:12 a.m.
On Thu, 2013-07-25 at 14:24 +0300, Andy Shevchenko wrote:
> There is nice specifier in kernel that allows us to print small
> buffers easily.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  drivers/net/ethernet/intel/e100.c | 15 ++++++---------
>  1 file changed, 6 insertions(+), 9 deletions(-) 

Thanks, I appreciate you sending this again...

I already have this patch queued up for upstream and it will be in the
next series I send.
Andy Shevchenko - July 31, 2013, 12:20 p.m.
On Fri, 2013-07-26 at 04:12 -0700, Jeff Kirsher wrote: 
> On Thu, 2013-07-25 at 14:24 +0300, Andy Shevchenko wrote:
> > There is nice specifier in kernel that allows us to print small
> > buffers easily.
> > 
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > ---
> >  drivers/net/ethernet/intel/e100.c | 15 ++++++---------
> >  1 file changed, 6 insertions(+), 9 deletions(-) 
> 
> Thanks, I appreciate you sending this again...
> 
> I already have this patch queued up for upstream and it will be in the
> next series I send.

Oh, sorry for resending.
I cleared up my queue after rebasing to recent linux-next, where the
patch is not appeared yet, that's why duplicate was created.
Jeff Kirsher - July 31, 2013, 12:32 p.m.
On Wed, 2013-07-31 at 15:20 +0300, Andy Shevchenko wrote:
> On Fri, 2013-07-26 at 04:12 -0700, Jeff Kirsher wrote: 
> > On Thu, 2013-07-25 at 14:24 +0300, Andy Shevchenko wrote:
> > > There is nice specifier in kernel that allows us to print small
> > > buffers easily.
> > > 
> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > > ---
> > >  drivers/net/ethernet/intel/e100.c | 15 ++++++---------
> > >  1 file changed, 6 insertions(+), 9 deletions(-) 
> > 
> > Thanks, I appreciate you sending this again...
> > 
> > I already have this patch queued up for upstream and it will be in
> the
> > next series I send.
> 
> Oh, sorry for resending.
> I cleared up my queue after rebasing to recent linux-next, where the
> patch is not appeared yet, that's why duplicate was created. 

No problem, sorry for the delay in getting it upstream and feel free to
ping me next time.

Patch

diff --git a/drivers/net/ethernet/intel/e100.c b/drivers/net/ethernet/intel/e100.c
index 5115ae7..0da5911 100644
--- a/drivers/net/ethernet/intel/e100.c
+++ b/drivers/net/ethernet/intel/e100.c
@@ -1175,15 +1175,12 @@  static int e100_configure(struct nic *nic, struct cb *cb, struct sk_buff *skb)
 		config->rx_discard_short_frames = 0x0;  /* 1=discard, 0=save */
 	}
 
-	netif_printk(nic, hw, KERN_DEBUG, nic->netdev,
-		     "[00-07]=%02X:%02X:%02X:%02X:%02X:%02X:%02X:%02X\n",
-		     c[0], c[1], c[2], c[3], c[4], c[5], c[6], c[7]);
-	netif_printk(nic, hw, KERN_DEBUG, nic->netdev,
-		     "[08-15]=%02X:%02X:%02X:%02X:%02X:%02X:%02X:%02X\n",
-		     c[8], c[9], c[10], c[11], c[12], c[13], c[14], c[15]);
-	netif_printk(nic, hw, KERN_DEBUG, nic->netdev,
-		     "[16-23]=%02X:%02X:%02X:%02X:%02X:%02X:%02X:%02X\n",
-		     c[16], c[17], c[18], c[19], c[20], c[21], c[22], c[23]);
+	netif_printk(nic, hw, KERN_DEBUG, nic->netdev, "[00-07]=%8phC\n",
+		     c + 0);
+	netif_printk(nic, hw, KERN_DEBUG, nic->netdev, "[08-15]=%8phC\n",
+		     c + 8);
+	netif_printk(nic, hw, KERN_DEBUG, nic->netdev, "[16-23]=%8phC\n",
+		     c + 16);
 	return 0;
 }