Patchwork [U-Boot,1/5] ARM: IGEP0033: Remove undef of CONFIG_CMD_MEMTEST

login
register
mail settings
Submitter Enric Balletbò i Serra
Date July 25, 2013, 7:27 a.m.
Message ID <1374737260-4268-2-git-send-email-eballetbo@gmail.com>
Download mbox | patch
Permalink /patch/261598/
State Accepted
Delegated to: Tom Rini
Headers show

Comments

Enric Balletbò i Serra - July 25, 2013, 7:27 a.m.
From: Enric Balletbo i Serra <eballetbo@iseebcn.com>

After commit:

  79cd2f814b1c75efd47161ac27f4cbebf768240f config_cmd_default.h: Remove CONFIG_CMD_MEMTEST

It's not necessary to undef the CONFIG_CMD_MEMTEST, so we can remove it from
configuration file.

Signed-off-by: Enric Balletbo i Serra <eballetbo@iseebcn.com>
---
 include/configs/igep0033.h | 7 -------
 1 file changed, 7 deletions(-)
Javier Martinez Canillas - Aug. 7, 2013, 3:59 p.m.
On Thu, Jul 25, 2013 at 9:27 AM, Enric Balletbo i Serra
<eballetbo@gmail.com> wrote:
> From: Enric Balletbo i Serra <eballetbo@iseebcn.com>
>
> After commit:
>
>   79cd2f814b1c75efd47161ac27f4cbebf768240f config_cmd_default.h: Remove CONFIG_CMD_MEMTEST
>
> It's not necessary to undef the CONFIG_CMD_MEMTEST, so we can remove it from
> configuration file.
>
> Signed-off-by: Enric Balletbo i Serra <eballetbo@iseebcn.com>
> ---
>  include/configs/igep0033.h | 7 -------
>  1 file changed, 7 deletions(-)
>
> diff --git a/include/configs/igep0033.h b/include/configs/igep0033.h
> index 12f28f8..41c083e 100644
> --- a/include/configs/igep0033.h
> +++ b/include/configs/igep0033.h
> @@ -59,13 +59,6 @@
>  #define CONFIG_CMD_UBI
>  #define CONFIG_CMD_UBIFS
>
> -/*
> - * Because the issues explained in doc/README.memory-test, the "mtest command
> - * is considered deprecated. It should not be enabled in most normal ports of
> - * U-Boot.
> - */
> -#undef CONFIG_CMD_MEMTEST
> -
>  #define CONFIG_BOOTDELAY               1       /* negative for no autoboot */
>  #define CONFIG_ENV_VARS_UBOOT_CONFIG
>  #define CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG
> --
> 1.8.1.2
>

Reviewed-by: Javier Martinez Canillas <javier@dowhile0.org>

Patch

diff --git a/include/configs/igep0033.h b/include/configs/igep0033.h
index 12f28f8..41c083e 100644
--- a/include/configs/igep0033.h
+++ b/include/configs/igep0033.h
@@ -59,13 +59,6 @@ 
 #define CONFIG_CMD_UBI
 #define CONFIG_CMD_UBIFS
 
-/*
- * Because the issues explained in doc/README.memory-test, the "mtest command
- * is considered deprecated. It should not be enabled in most normal ports of
- * U-Boot.
- */
-#undef CONFIG_CMD_MEMTEST
-
 #define CONFIG_BOOTDELAY		1	/* negative for no autoboot */
 #define CONFIG_ENV_VARS_UBOOT_CONFIG
 #define CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG