Patchwork [V3,net-next,0/2] pch_gbe: Add MinnowBoard support

login
register
mail settings
Submitter Darren Hart
Date July 25, 2013, 5:10 a.m.
Message ID <cover.1374728627.git.dvhart@linux.intel.com>
Download mbox
Permalink /patch/261584/
State Changes Requested
Delegated to: David Miller
Headers show

Pull-request

git://git.infradead.org/users/dvhart/linux-2.6.git minnow/net-next

Comments

Darren Hart - July 25, 2013, 5:10 a.m.
Add support for the MinnowBoard in the pch_gbe driver. This was
originally sent to LKML as part of the MinnowBoard support series. That
is now partially merged and this version of the patch has been isolated
from those changes and is now completely self-contained.

Thanks to everyone on Cc for their time in reviewing, the patch series
is better for it.

V2:
  Whitespace cleanup
  Remove trailing period in messages
  Comment formatting (added a colon)
  Use devm_gpio_request_one
  Fix missing adapter->pdata NULL check in PHY
  Use netdev style comment blocks
  Use kernel_ulong_t for driver_data cast
  Use unsigned for gpio and unsigned long for flags
V3:
  Restore /** comment start for file consistency per Joe Perches
    following his checkpatch.pl patch
  Make pch_gbe_phy_tx_clk_delay() static per David Miller

I have included patch 1/2 as it was also marked with "Changes Requested"
in patchwork. Hopefully resending is the preferred method.

The following changes since commit 18afa4b028b46f8b45ca64f94aefe717c297b07d:

  net: Make devnet_rename_seq static (2013-07-24 17:57:26 -0700)

are available in the git repository at:

  git://git.infradead.org/users/dvhart/linux-2.6.git minnow/net-next
  ssh://git.infradead.org/srv/git/users/dvhart/linux-2.6.git minnow/net-next

and browsable here:

  http://git.infradead.org/users/dvhart/linux-2.6.git/shortlog/refs/heads/minnow/net-next

Darren Hart (2):
  pch_gbe: Use PCH_GBE_PHY_REGS_LEN instead of 32
  pch_gbe: Add MinnowBoard support

 drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe.h    | 15 ++++
 .../net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c   | 52 +++++++++++-
 .../net/ethernet/oki-semi/pch_gbe/pch_gbe_phy.c    | 98 ++++++++++++++++++++++
 .../net/ethernet/oki-semi/pch_gbe/pch_gbe_phy.h    |  1 +
 4 files changed, 165 insertions(+), 1 deletion(-)
Darren Hart - July 25, 2013, 2:04 p.m.
Andy Shevchenko caught a couple minor errors in V3. I've incorporated
his feedback and sent V4. Please disregard V3.

Thanks,

Darren Hart

On Wed, 2013-07-24 at 22:10 -0700, Darren Hart wrote:
> Add support for the MinnowBoard in the pch_gbe driver. This was
> originally sent to LKML as part of the MinnowBoard support series. That
> is now partially merged and this version of the patch has been isolated
> from those changes and is now completely self-contained.
> 
> Thanks to everyone on Cc for their time in reviewing, the patch series
> is better for it.
> 
> V2:
>   Whitespace cleanup
>   Remove trailing period in messages
>   Comment formatting (added a colon)
>   Use devm_gpio_request_one
>   Fix missing adapter->pdata NULL check in PHY
>   Use netdev style comment blocks
>   Use kernel_ulong_t for driver_data cast
>   Use unsigned for gpio and unsigned long for flags
> V3:
>   Restore /** comment start for file consistency per Joe Perches
>     following his checkpatch.pl patch
>   Make pch_gbe_phy_tx_clk_delay() static per David Miller
> 
> I have included patch 1/2 as it was also marked with "Changes Requested"
> in patchwork. Hopefully resending is the preferred method.
> 
> The following changes since commit 18afa4b028b46f8b45ca64f94aefe717c297b07d:
> 
>   net: Make devnet_rename_seq static (2013-07-24 17:57:26 -0700)
> 
> are available in the git repository at:
> 
>   git://git.infradead.org/users/dvhart/linux-2.6.git minnow/net-next
>   ssh://git.infradead.org/srv/git/users/dvhart/linux-2.6.git minnow/net-next
> 
> and browsable here:
> 
>   http://git.infradead.org/users/dvhart/linux-2.6.git/shortlog/refs/heads/minnow/net-next
> 
> Darren Hart (2):
>   pch_gbe: Use PCH_GBE_PHY_REGS_LEN instead of 32
>   pch_gbe: Add MinnowBoard support
> 
>  drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe.h    | 15 ++++
>  .../net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c   | 52 +++++++++++-
>  .../net/ethernet/oki-semi/pch_gbe/pch_gbe_phy.c    | 98 ++++++++++++++++++++++
>  .../net/ethernet/oki-semi/pch_gbe/pch_gbe_phy.h    |  1 +
>  4 files changed, 165 insertions(+), 1 deletion(-)
>
David Miller - July 28, 2013, 5:13 a.m.
From: Darren Hart <dvhart@linux.intel.com>
Date: Thu, 25 Jul 2013 07:04:36 -0700

> Andy Shevchenko caught a couple minor errors in V3. I've incorporated
> his feedback and sent V4. Please disregard V3.

I've pulled V4 into net-next, thanks a lot.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html