Patchwork ext4: extents: len and lblock may be used uninitialized

login
register
mail settings
Submitter Andi Shyti
Date July 25, 2013, 12:33 a.m.
Message ID <1374712385-6691-1-git-send-email-andi@etezian.org>
Download mbox | patch
Permalink /patch/261567/
State Accepted
Headers show

Comments

Andi Shyti - July 25, 2013, 12:33 a.m.
if ext_debugging is enabled and path[depth].p_ext is NULL, len
and lblock are printed non initialized

Signed-off-by: Andi Shyti <andi@etezian.org>
---
 fs/ext4/extents.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
Theodore Ts'o - Aug. 28, 2013, 6:20 p.m.
On Thu, Jul 25, 2013 at 02:33:05AM +0200, Andi Shyti wrote:
> if ext_debugging is enabled and path[depth].p_ext is NULL, len
> and lblock are printed non initialized
> 
> Signed-off-by: Andi Shyti <andi@etezian.org>

Thanks, applied.

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
index a618738..acaf53c 100644
--- a/fs/ext4/extents.c
+++ b/fs/ext4/extents.c
@@ -2195,8 +2195,8 @@  ext4_ext_put_gap_in_cache(struct inode *inode, struct ext4_ext_path *path,
 				ext4_lblk_t block)
 {
 	int depth = ext_depth(inode);
-	unsigned long len;
-	ext4_lblk_t lblock;
+	unsigned long len = 0;
+	ext4_lblk_t lblock = 0;
 	struct ext4_extent *ex;
 
 	ex = path[depth].p_ext;
@@ -2233,7 +2233,6 @@  ext4_ext_put_gap_in_cache(struct inode *inode, struct ext4_ext_path *path,
 			ext4_es_insert_extent(inode, lblock, len, ~0,
 					      EXTENT_STATUS_HOLE);
 	} else {
-		lblock = len = 0;
 		BUG();
 	}