From patchwork Wed Jul 24 07:22:58 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas De Schampheleire X-Patchwork-Id: 261296 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from silver.osuosl.org (silver.osuosl.org [140.211.166.136]) by ozlabs.org (Postfix) with ESMTP id 3D5162C0098 for ; Wed, 24 Jul 2013 17:26:11 +1000 (EST) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 45D65328EE; Wed, 24 Jul 2013 07:26:09 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id U+IirgbDcSDi; Wed, 24 Jul 2013 07:26:07 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by silver.osuosl.org (Postfix) with ESMTP id 6384E31298; Wed, 24 Jul 2013 07:26:07 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from whitealder.osuosl.org (whitealder.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id BB5B41C2D98 for ; Wed, 24 Jul 2013 07:26:14 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 565A28D684 for ; Wed, 24 Jul 2013 07:26:04 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9roAtwNvPZND for ; Wed, 24 Jul 2013 07:26:03 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-ee0-f51.google.com (mail-ee0-f51.google.com [74.125.83.51]) by whitealder.osuosl.org (Postfix) with ESMTPS id 7DD248D5C4 for ; Wed, 24 Jul 2013 07:26:03 +0000 (UTC) Received: by mail-ee0-f51.google.com with SMTP id c1so34874eek.38 for ; Wed, 24 Jul 2013 00:26:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:content-type:mime-version:content-transfer-encoding:subject :x-mercurial-node:message-id:in-reply-to:references:user-agent:date :from:to; bh=7d2XTM8Ew7xlJ2D6v7XL1QnirXI8JxgJw1zfFPD17Mg=; b=pXOmiWhYd7sMejE7Vo1Zn3wdVorsaq4RjvP5hWI7eHwasFw0dekQ3NK5q3A+08/0pT fl4eZ4r3sjnTOcdBNFYXrdCG2tcfvTrI3LULW1UUy+OcGBLN7I8gpdg6J3jABHXyZTZ6 wo5xtojSQdaM5n3RCOzC1vN1AzORsjygnTLN/V+kWBVGqmUV0tZrVB48Yi/h0QA9I/r5 7O+7VPIM2OPQfWErtMJSwvJ0/MucMP3y2kz6qZ5ZleoUQAOcBzuOSbZ6puStyEbqagOf tRR1SAYVuQwUKHzfJR6bxdOUi5FW+6JWRAHPyulPGtQpKYs30jqTKFgy3o2LyjtgN6Vh Yzsg== X-Received: by 10.14.204.137 with SMTP id h9mr36591404eeo.13.1374650761878; Wed, 24 Jul 2013 00:26:01 -0700 (PDT) Received: from [127.0.1.1] (d54C62EEB.access.telenet.be. [84.198.46.235]) by mx.google.com with ESMTPSA id i2sm63958851eeu.4.2013.07.24.00.26.00 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 24 Jul 2013 00:26:01 -0700 (PDT) MIME-Version: 1.0 X-Mercurial-Node: 2942a6d3dd9f0f3fd8641f9c26b2c34bf34c2c99 Message-Id: <2942a6d3dd9f0f3fd864.1374650578@BEANTN0L019720> In-Reply-To: References: User-Agent: Mercurial-patchbomb/2.2.2 Date: Wed, 24 Jul 2013 09:22:58 +0200 From: Thomas De Schampheleire To: buildroot@busybox.net Subject: [Buildroot] [PATCH 1 of 6 v2] Config.in.legacy: update description X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: buildroot-bounces@busybox.net Sender: buildroot-bounces@busybox.net The existing comments in Config.in.legacy are not entirely in-line with current practice. The comments implies that BR2_LEGACY should not be set when the conversion from old-to-new symbol can be done automatically using the appropriate 'select' statements. However, none of the existing legacy options does it this way. Moreover, I think it's intentional that the user is notified of the change, so that the removal of the legacy options in later buildroot versions no longer poses a problem. Additionally, I have added an example of how to handle the renaming of a string config option. Because a string option cannot 'select' something else, a wrapper symbol is needed of type bool. Signed-off-by: Thomas De Schampheleire Acked-by: Arnout Vandecappelle (Essensium/Mind) --- (v2): new patch in this series Config.in.legacy | 22 +++++++++++++++++----- 1 files changed, 17 insertions(+), 5 deletions(-) diff --git a/Config.in.legacy b/Config.in.legacy --- a/Config.in.legacy +++ b/Config.in.legacy @@ -3,11 +3,10 @@ # # When an existing Config.in symbol is removed, it should be added again in this # file, and take appropriate action to approximate backward compatibility. If -# there is an equivalent (set of) new symbols, these can just be select'ed by -# the old symbol. This makes sure that running 'make oldconfig' will make things -# "just work" when upgrading to a new buildroot version. If the change is too -# fundamental and cannot be fixed by a simple select, then the old symbol should -# select BR2_LEGACY. If that symbol is set, the build will issue an error. +# there is an equivalent (set of) new symbols, these should be select'ed by +# the old symbol. This will make the transition for the user more convenient. +# The old symbol should select BR2_LEGACY, so that the user is informed at +# build-time about selected legacy options. # # When adding legacy symbols to this file, add them to the front. The oldest # symbols will be removed again after about two years. @@ -15,6 +14,19 @@ # The symbol should be copied as-is from the place where it was previously # defined, but the help text should be removed or replaced with something that # explains how to fix it. +# If the old symbol is of type string, and the symbol has been renamed, you +# should add it as a bool with another name (BR2__WRAP), that defaults +# to y if the old string is not set at its default value. For example: +# config BR2_FOO_STRING +# string "Some foo string" +# would become: +# config BR2_FOO_STRING_WRAP +# bool "Foo string option has been renamed." +# default y if BR2_FOO_STRING != "" +# depends on BR2_LEGACY +# help +# +# config BR2_LEGACY bool