| Message ID | 1374607359-20024-1-git-send-email-f.fainelli@gmail.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
From: "Florian Fainelli" <f.fainelli@gmail.com> Date: Tue, 23 Jul 2013 20:22:39 +0100 > build_skb() specifies that the data parameter must come from a kmalloc'd > area, this is only true if frag_size equals 0, because then build_skb() > will use kzsize(data) to figure out the actual data size. Update the > comment to reflect that special condition. > > Signed-off-by: Florian Fainelli <f.fainelli@gmail.com> Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/core/skbuff.c b/net/core/skbuff.c index 20e02d2..3df4d4c 100644 --- a/net/core/skbuff.c +++ b/net/core/skbuff.c @@ -309,7 +309,8 @@ EXPORT_SYMBOL(__alloc_skb); * @frag_size: size of fragment, or 0 if head was kmalloced * * Allocate a new &sk_buff. Caller provides space holding head and - * skb_shared_info. @data must have been allocated by kmalloc() + * skb_shared_info. @data must have been allocated by kmalloc() only if + * @frag_size is 0, otherwise data should come from the page allocator. * The return is the new skb buffer. * On a failure the return is %NULL, and @data is not freed. * Notes :
build_skb() specifies that the data parameter must come from a kmalloc'd area, this is only true if frag_size equals 0, because then build_skb() will use kzsize(data) to figure out the actual data size. Update the comment to reflect that special condition. Signed-off-by: Florian Fainelli <f.fainelli@gmail.com> --- Changes since v1: - explain the case where frag_size != 0 net/core/skbuff.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)