| Submitter | Wolfram Sang |
|---|---|
| Date | July 23, 2013, 6:01 p.m. |
| Message ID | <1374602524-3398-12-git-send-email-wsa@the-dreams.de> |
| Download | mbox | patch |
| Permalink | /patch/261167/ |
| State | New |
| Headers | show |
Comments
On Tue, Jul 23, 2013 at 3:01 PM, Wolfram Sang <wsa@the-dreams.de> wrote: > devm_ioremap_resource does sanity checks on the given resource. No need to > duplicate this in the driver. > > Signed-off-by: Wolfram Sang <wsa@the-dreams.de> I have already submitted such change: http://patchwork.ozlabs.org/patch/260537/
Patch
diff --git a/drivers/mtd/nand/mxc_nand.c b/drivers/mtd/nand/mxc_nand.c index 07e5784..d1feb97 100644 --- a/drivers/mtd/nand/mxc_nand.c +++ b/drivers/mtd/nand/mxc_nand.c @@ -1446,8 +1446,6 @@ static int mxcnd_probe(struct platform_device *pdev) if (host->devtype_data->needs_ip) { res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (!res) - return -ENODEV; host->regs_ip = devm_ioremap_resource(&pdev->dev, res); if (IS_ERR(host->regs_ip)) return PTR_ERR(host->regs_ip); @@ -1457,9 +1455,6 @@ static int mxcnd_probe(struct platform_device *pdev) res = platform_get_resource(pdev, IORESOURCE_MEM, 0); } - if (!res) - return -ENODEV; - host->base = devm_ioremap_resource(&pdev->dev, res); if (IS_ERR(host->base)) return PTR_ERR(host->base);
devm_ioremap_resource does sanity checks on the given resource. No need to duplicate this in the driver. Signed-off-by: Wolfram Sang <wsa@the-dreams.de> --- Please apply via the subsystem-tree. drivers/mtd/nand/mxc_nand.c | 5 ----- 1 file changed, 5 deletions(-)