| Message ID | 4961229.bXDGvH0dpz@al |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
Hello. On 23-07-2013 13:55, Peter Wu wrote: > This message was added in commit a7154cb8 (June 2004) and is printed Please also specify that commit's summary line in parens. > every ten seconds when no cable is connected. > Signed-off-by: Peter Wu <lekensteyn@gmail.com> WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, 23 Jul 2013 11:55:57 +0200 Peter Wu <lekensteyn@gmail.com> wrote: > This message was added in commit a7154cb8 (June 2004) and is printed > every ten seconds when no cable is connected. > > Signed-off-by: Peter Wu <lekensteyn@gmail.com> > --- > Using ethtool to silence *all* link warnings is still a manual > operation, in my opinion not acceptable so let's remove this message. > > The r8169 constantly resets the device when no link is connected, > contrary the r8168 vendor driver which only resets the link when some > PCI config fields have been modified. As the current reset logic in r8168 > seems to work for broken device (which I do not have have and therefore > cannot test), I did not attempt to "clean this up". > --- > drivers/net/ethernet/realtek/r8169.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c > index 880015c..63f04af 100644 > --- a/drivers/net/ethernet/realtek/r8169.c > +++ b/drivers/net/ethernet/realtek/r8169.c > @@ -3689,8 +3689,6 @@ static void rtl_phy_work(struct rtl8169_private *tp) > if (tp->link_ok(ioaddr)) > return; > > - netif_warn(tp, link, tp->dev, "PHY reset until link up\n"); > - > tp->phy_reset_enable(tp); > > out_mod_timer: Why not implement netif msg flag to allow user to control this? -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tuesday 23 July 2013 08:54:36 Stephen Hemminger wrote: > On Tue, 23 Jul 2013 11:55:57 +0200 > > Peter Wu <lekensteyn@gmail.com> wrote: > > This message was added in commit a7154cb8 (June 2004) and is printed > > every ten seconds when no cable is connected. > > > > Signed-off-by: Peter Wu <lekensteyn@gmail.com> > > --- > > Using ethtool to silence *all* link warnings is still a manual > > operation, in my opinion not acceptable so let's remove this message. > > > > The r8169 constantly resets the device when no link is connected, > > contrary the r8168 vendor driver which only resets the link when some > > PCI config fields have been modified. As the current reset logic in r8168 > > seems to work for broken device (which I do not have have and therefore > > cannot test), I did not attempt to "clean this up". > > --- > > > > drivers/net/ethernet/realtek/r8169.c | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/drivers/net/ethernet/realtek/r8169.c > > b/drivers/net/ethernet/realtek/r8169.c index 880015c..63f04af 100644 > > --- a/drivers/net/ethernet/realtek/r8169.c > > +++ b/drivers/net/ethernet/realtek/r8169.c > > @@ -3689,8 +3689,6 @@ static void rtl_phy_work(struct rtl8169_private *tp) > > > > if (tp->link_ok(ioaddr)) > > > > return; > > > > - netif_warn(tp, link, tp->dev, "PHY reset until link up\n"); > > - > > > > tp->phy_reset_enable(tp); > > > > out_mod_timer: > Why not implement netif msg flag to allow user to control this? Which user wants to get log spam every ten seconds? I see no purpose except when a developer asks a user to turn this on, or except if you are a developer. This message was added almost ten years ago, Realtek must certainly have improved their hardware not to be so crappy? See also <http://marc.info/?l=linux-netdev&m=137452974325684&w=2> where David Miller wrote: > In every case where this issue has popped up, we have decided that > printing messages when the cable is simply unplugged is very > undesirable. Regards, Peter -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, 23 Jul 2013 18:07:15 +0200 Peter Wu <lekensteyn@gmail.com> wrote: > On Tuesday 23 July 2013 08:54:36 Stephen Hemminger wrote: > > On Tue, 23 Jul 2013 11:55:57 +0200 > > > > Peter Wu <lekensteyn@gmail.com> wrote: > > > This message was added in commit a7154cb8 (June 2004) and is printed > > > every ten seconds when no cable is connected. > > > > > > Signed-off-by: Peter Wu <lekensteyn@gmail.com> > > > --- > > > Using ethtool to silence *all* link warnings is still a manual > > > operation, in my opinion not acceptable so let's remove this message. > > > > > > The r8169 constantly resets the device when no link is connected, > > > contrary the r8168 vendor driver which only resets the link when some > > > PCI config fields have been modified. As the current reset logic in r8168 > > > seems to work for broken device (which I do not have have and therefore > > > cannot test), I did not attempt to "clean this up". > > > --- > > > > > > drivers/net/ethernet/realtek/r8169.c | 2 -- > > > 1 file changed, 2 deletions(-) > > > > > > diff --git a/drivers/net/ethernet/realtek/r8169.c > > > b/drivers/net/ethernet/realtek/r8169.c index 880015c..63f04af 100644 > > > --- a/drivers/net/ethernet/realtek/r8169.c > > > +++ b/drivers/net/ethernet/realtek/r8169.c > > > @@ -3689,8 +3689,6 @@ static void rtl_phy_work(struct rtl8169_private *tp) > > > > > > if (tp->link_ok(ioaddr)) > > > > > > return; > > > > > > - netif_warn(tp, link, tp->dev, "PHY reset until link up\n"); > > > - > > > > > > tp->phy_reset_enable(tp); > > > > > > out_mod_timer: > > Why not implement netif msg flag to allow user to control this? > > Which user wants to get log spam every ten seconds? I see no purpose except > when a developer asks a user to turn this on, or except if you are a > developer. This message was added almost ten years ago, Realtek must certainly > have improved their hardware not to be so crappy? > > See also <http://marc.info/?l=linux-netdev&m=137452974325684&w=2> where David > Miller wrote: > > In every case where this issue has popped up, we have decided that > > printing messages when the cable is simply unplugged is very > > undesirable. > > Regards, > Peter I meant the general link up/down message, not the silly polling message -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Peter Wu <lekensteyn@gmail.com> : [...] > Which user wants to get log spam every ten seconds ? In my world users - be they big workstations or runtime pm enabled laptops - may not even care about log [1]. > I see no purpose except when a developer asks a user to turn this on, > or except if you are a developer. Exactly. You'll easily guess which side I'm on with my load of problem reports that have no simple solution and slowly ages while bugfixes flow through -stable. > This message was added almost ten years ago, Realtek must > certainly have improved their hardware not to be so crappy ? With due respect to Realtek, git log or Realtek's own Release.txt file do not exactly paint the world as a faery of unicorns. (Realtek is not alone: manufacturers can be quite creative) [1] Linus is not a real user.
On Tuesday 23 July 2013 22:23:40 Francois Romieu wrote: > Peter Wu <lekensteyn@gmail.com> : > [...] > > > Which user wants to get log spam every ten seconds ? > > In my world users - be they big workstations or runtime pm enabled > laptops - may not even care about log [1]. So I am not a real user either because I keep journalctl open / tailf log files? I see what you are trying to note, but I doubt the usefulness of this specific message. This message appears if: (1) The device has just been brought up. (2) Has not been connected before while being up. (3) Is enabled all the time (runtime PM?) (4) No reset it pending. Only the last point cannot easily be determine from a log context, but these do not seem to appear on recent devices? (I've never experienced link issues with Realtek Ethernet cards, wireless is another thing) > > This message was added almost ten years ago, Realtek must > > certainly have improved their hardware not to be so crappy ? > > With due respect to Realtek, git log or Realtek's own Release.txt file > do not exactly paint the world as a faery of unicorns. Or even using the file header as revision log... anyway, you cannot make money by selling just crap right? There is enough competition on this market. Regards, Peter -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Peter Wu <lekensteyn@gmail.com> : [...] > Or even using the file header as revision log... anyway, you cannot make > money by selling just crap right ? Let's stop discussing this topic before it gets depressing, ok ? And, no, you are not a real user anymore. Get over it.
diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c index 880015c..63f04af 100644 --- a/drivers/net/ethernet/realtek/r8169.c +++ b/drivers/net/ethernet/realtek/r8169.c @@ -3689,8 +3689,6 @@ static void rtl_phy_work(struct rtl8169_private *tp) if (tp->link_ok(ioaddr)) return; - netif_warn(tp, link, tp->dev, "PHY reset until link up\n"); - tp->phy_reset_enable(tp); out_mod_timer:
This message was added in commit a7154cb8 (June 2004) and is printed every ten seconds when no cable is connected. Signed-off-by: Peter Wu <lekensteyn@gmail.com> --- Using ethtool to silence *all* link warnings is still a manual operation, in my opinion not acceptable so let's remove this message. The r8169 constantly resets the device when no link is connected, contrary the r8168 vendor driver which only resets the link when some PCI config fields have been modified. As the current reset logic in r8168 seems to work for broken device (which I do not have have and therefore cannot test), I did not attempt to "clean this up". --- drivers/net/ethernet/realtek/r8169.c | 2 -- 1 file changed, 2 deletions(-)