From patchwork Mon Jul 22 18:01:31 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: pchang9@cs.wisc.edu X-Patchwork-Id: 260782 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "localhost", Issuer "www.qmailtoaster.com" (not verified)) by ozlabs.org (Postfix) with ESMTPS id 771582C00A6 for ; Tue, 23 Jul 2013 04:02:16 +1000 (EST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:date:subject:from:to:mime-version:content-type :content-transfer-encoding; q=dns; s=default; b=DOmcr+2gBq9ZYVM7 DibYeBZFCSNgMHbNRR+NRKAvgh4xlXHyYXveR5TQ1Ml3qp6aPiGKqOQwh5YLsSg0 cwTI/XCB5e9sC73AZzH2aNpya1upOK1+TsvJq3vyqmQOe173NRQ8OMzrtMN/aTZC NeIQ1PleNhvQQmEgN7Ru/Er1doI= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:date:subject:from:to:mime-version:content-type :content-transfer-encoding; s=default; bh=zImb+pwxGVMzgDwLlgkKZw 8SedU=; b=ukGHTuMQZ35/c6QA7ggJAIj8HT8fRhAyHGZxCouCFqsn18bOxCuQ6t 8XEXzNrh32O/5SZOGwDFkhQd/fpgbPmsLwKgZ5ZCr706V7naKFFkxx15SCcTA8Cb EQrujTaqSppRujg6oCtC68nRAoofOd/da65Qg8/oJTU2fa8NRTrSo= Received: (qmail 7685 invoked by alias); 22 Jul 2013 18:02:10 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 7676 invoked by uid 89); 22 Jul 2013 18:02:09 -0000 X-Spam-SWARE-Status: No, score=-3.1 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_MED, RCVD_IN_HOSTKARMA_W, RDNS_NONE, SPF_HELO_PASS, SPF_PASS autolearn=ham version=3.3.1 Received: from Unknown (HELO sandstone.cs.wisc.edu) (128.105.6.39) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Mon, 22 Jul 2013 18:01:39 +0000 Received: from webmail.cs.wisc.edu (george.cs.wisc.edu [128.105.7.110]) by sandstone.cs.wisc.edu (8.14.1/8.14.1) with ESMTP id r6MI1Vlp022378 for ; Mon, 22 Jul 2013 13:01:31 -0500 Received: from 72.33.255.231 (SquirrelMail authenticated user pchang9) by webmail.cs.wisc.edu with HTTP; Mon, 22 Jul 2013 13:01:31 -0500 Message-ID: Date: Mon, 22 Jul 2013 13:01:31 -0500 Subject: [Patch, PR 57787] Wasted work in ix86_pad_returns() From: pchang9@cs.wisc.edu To: gcc-patches@gcc.gnu.org User-Agent: SquirrelMail/1.4.22 MIME-Version: 1.0 Hi, The problem appears in revision 201034 in version 4.9. I also reported this problem at http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57787. Bootstrap and regression-tested on x86_64-linux. In method "ix86_pad_returns()" in i386.c, the loop on line 35723 should break immediately after "replace" is set to "true". 2013-07-22 Chang * i386.c (ix86_pad_returns): Exit loop after setting replace. -Chang Index: gcc/config/i386/i386.c =================================================================== --- gcc/config/i386/i386.c (revision 201034) +++ gcc/config/i386/i386.c (working copy) @@ -35723,7 +35723,10 @@ FOR_EACH_EDGE (e, ei, bb->preds) if (EDGE_FREQUENCY (e) && e->src->index >= 0 && !(e->flags & EDGE_FALLTHRU)) - replace = true; + { + replace = true; + break; + } } if (!replace) {