Patchwork nand: mxc_nand: Remove unneeded check for platform_get_resource()

login
register
mail settings
Submitter Fabio Estevam
Date July 21, 2013, 5:52 p.m.
Message ID <1374429122-15514-1-git-send-email-festevam@gmail.com>
Download mbox | patch
Permalink /patch/260537/
State New
Headers show

Comments

Fabio Estevam - July 21, 2013, 5:52 p.m.
From: Fabio Estevam <fabio.estevam@freescale.com>

devm_ioremap_resource() checks its arguments, so there is no need for
explicitly checking the return value from platform_get_resource().

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 drivers/mtd/nand/mxc_nand.c | 5 -----
 1 file changed, 5 deletions(-)
Artem Bityutskiy - Aug. 2, 2013, 3:34 p.m.
On Sun, 2013-07-21 at 14:52 -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
> 
> devm_ioremap_resource() checks its arguments, so there is no need for
> explicitly checking the return value from platform_get_resource().
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>

Pushed to l2-mtd.git, thanks!

Patch

diff --git a/drivers/mtd/nand/mxc_nand.c b/drivers/mtd/nand/mxc_nand.c
index 18855ad..0581bd3 100644
--- a/drivers/mtd/nand/mxc_nand.c
+++ b/drivers/mtd/nand/mxc_nand.c
@@ -1446,8 +1446,6 @@  static int mxcnd_probe(struct platform_device *pdev)
 
 	if (host->devtype_data->needs_ip) {
 		res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-		if (!res)
-			return -ENODEV;
 		host->regs_ip = devm_ioremap_resource(&pdev->dev, res);
 		if (IS_ERR(host->regs_ip))
 			return PTR_ERR(host->regs_ip);
@@ -1457,9 +1455,6 @@  static int mxcnd_probe(struct platform_device *pdev)
 		res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
 	}
 
-	if (!res)
-		return -ENODEV;
-
 	host->base = devm_ioremap_resource(&pdev->dev, res);
 	if (IS_ERR(host->base))
 		return PTR_ERR(host->base);