diff mbox

[RFC,3/8] timer: make timers_state static

Message ID 1374396185-10870-4-git-send-email-pingfank@linux.vnet.ibm.com
State New
Headers show

Commit Message

pingfan liu July 21, 2013, 8:43 a.m. UTC 
Signed-off-by: Liu Ping Fan <pingfank@linux.vnet.ibm.com>
---
 cpus.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jan Kiszka July 22, 2013, 6:36 a.m. UTC | #1 
On 2013-07-21 10:43, Liu Ping Fan wrote:
> Signed-off-by: Liu Ping Fan <pingfank@linux.vnet.ibm.com>
> ---
>  cpus.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/cpus.c b/cpus.c
> index 61e86a8..4254ca9 100644
> --- a/cpus.c
> +++ b/cpus.c
> @@ -112,7 +112,7 @@ typedef struct TimersState {
>      int64_t dummy;
>  } TimersState;
>  
> -TimersState timers_state;
> +static TimersState timers_state;
>  
>  /* Return the virtual CPU time, based on the instruction counter.  */
>  int64_t cpu_get_icount(void)
> 

Could go in directly via trivial IMHO.

Reviewed-by: Jan Kiszka <jan.kiszka@siemens.com>
Michael Tokarev July 22, 2013, 5:40 p.m. UTC | #2 
22.07.2013 10:36, Jan Kiszka wrote:
> On 2013-07-21 10:43, Liu Ping Fan wrote:
>> -TimersState timers_state;
>> +static TimersState timers_state;

> Could go in directly via trivial IMHO.

It should not conflict with anything else.

Thanks, applied to the trivial patches queue.

/mjt
diff mbox

Patch

diff --git a/cpus.c b/cpus.c
index 61e86a8..4254ca9 100644
--- a/cpus.c
+++ b/cpus.c
@@ -112,7 +112,7 @@  typedef struct TimersState {
     int64_t dummy;
 } TimersState;
 
-TimersState timers_state;
+static TimersState timers_state;
 
 /* Return the virtual CPU time, based on the instruction counter.  */
 int64_t cpu_get_icount(void)