Patchwork [1/3] python-setuptools: bumped version to 0.8

login
register
mail settings
Submitter Rohan Fletcher
Date July 20, 2013, 10:27 a.m.
Message ID <1374316034-31973-1-git-send-email-rohfledev@gmail.com>
Download mbox | patch
Permalink /patch/260435/
State Superseded
Delegated to: Thomas Petazzoni
Headers show

Comments

Rohan Fletcher - July 20, 2013, 10:27 a.m.
Signed-off-by: Rohan Fletcher <rohfledev@gmail.com>
---
 package/python-setuptools/python-setuptools.mk | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
Thomas Petazzoni - Feb. 13, 2014, 9:12 p.m.
Dear Rohan Fletcher,

On Sat, 20 Jul 2013 22:27:12 +1200, Rohan Fletcher wrote:
> 
> Signed-off-by: Rohan Fletcher <rohfledev@gmail.com>
> ---
>  package/python-setuptools/python-setuptools.mk | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

I have integrated this patch (after adjusting it to bump to the latest
setuptools version) into a patch series that I posted at:

  http://patchwork.ozlabs.org/patch/260435/

However, regarding your patches 2/3 and 3/3, we discussed during the
Buildroot Developers Meeting, and the general opinion is that we don't
really like tools such as "pip", because they completely circumvent the
Buildroot logic, which has a number of drawbacks:

 * It does not take care of native dependencies, and quite a few Python
   modules have such dependencies.

 * It does not go through the Buildroot download infrastructure, which
   means that "make external-deps", "make source" do not work for the
   Python modules downloaded by pip.

 * It does not integrate with the Buildroot licensing infrastructure,
   which makes it more complicated to maintain an up-to-date list of
   the components installed in the generated system.

For Perl, Fran├žois Perrad has written a script that given a Perl CPAN
package creates all the necessary Buildroot packages. Such an approach
was accepted by the Buildroot developers, and maybe we should look at
having something similar for Python modules.

Best regards,

Thomas
Thomas Petazzoni - Feb. 13, 2014, 10:18 p.m.
Rohan, all,

On Thu, 13 Feb 2014 22:12:44 +0100, Thomas Petazzoni wrote:

> For Perl, Fran├žois Perrad has written a script that given a Perl CPAN
> package creates all the necessary Buildroot packages. Such an approach
> was accepted by the Buildroot developers, and maybe we should look at
> having something similar for Python modules.

I just tried this idea, see the attached (ugly) script.

Unfortunately, there are quite a few limitations:

  - The script is currently not able to guess the <pkg>_SETUP_TYPE,
    i.e whether the package should be built with distutils or
    setuptools.

  - The Pypi informations seem to very limited. A number of packages
    don't even give the URL of their tarball, the licensing
    informations are incomplete, there is no reference to the file
    containing the license text, etc.

If anyone wants to pursue this experimentation, feel free to pick up
the script and improve it.

Best regards,

Thomas

Patch

diff --git a/package/python-setuptools/python-setuptools.mk b/package/python-setuptools/python-setuptools.mk
index cd5ee4d..48b934b 100644
--- a/package/python-setuptools/python-setuptools.mk
+++ b/package/python-setuptools/python-setuptools.mk
@@ -9,9 +9,9 @@ 
 # switch back to it.
 # See http://pypi.python.org/packages/source/s/setuptools
 
-PYTHON_SETUPTOOLS_VERSION = 0.6.36
-PYTHON_SETUPTOOLS_SOURCE  = distribute-$(PYTHON_SETUPTOOLS_VERSION).tar.gz
-PYTHON_SETUPTOOLS_SITE    = http://pypi.python.org/packages/source/d/distribute
+PYTHON_SETUPTOOLS_VERSION = 0.8
+PYTHON_SETUPTOOLS_SOURCE  = setuptools-$(PYTHON_SETUPTOOLS_VERSION).tar.gz
+PYTHON_SETUPTOOLS_SITE    = http://pypi.python.org/packages/source/s/setuptools
 PYTHON_SETUPTOOLS_DEPENDENCIES = python
 
 define HOST_PYTHON_SETUPTOOLS_BUILD_CMDS