diff mbox

[V7,13/13] monitor: improve auto complete of "help" for single command in sub group

Message ID 1374284656-12025-14-git-send-email-xiawenc@linux.vnet.ibm.com
State New
Headers show

Commit Message

Wayne Xia July 20, 2013, 1:44 a.m. UTC 
Now special case "help *" in auto completion can work with sub commands,
such as "help info u*".

Signed-off-by: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
---
 monitor.c |    6 ++----
 1 files changed, 2 insertions(+), 4 deletions(-)

Comments

Eric Blake July 25, 2013, 4:51 p.m. UTC | #1 
On 07/19/2013 07:44 PM, Wenchao Xia wrote:
> Now special case "help *" in auto completion can work with sub commands,
> such as "help info u*".
> 
> Signed-off-by: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
> ---
>  monitor.c |    6 ++----
>  1 files changed, 2 insertions(+), 4 deletions(-)
> 

Reviewed-by: Eric Blake <eblake@redhat.com>
diff mbox

Patch

diff --git a/monitor.c b/monitor.c
index ea3ed96..95fa918 100644
--- a/monitor.c
+++ b/monitor.c
@@ -4314,10 +4314,8 @@  static void monitor_find_completion_by_table(Monitor *mon,
                     cmd_completion(mon, str, QKeyCode_lookup[i]);
                 }
             } else if (!strcmp(cmd->name, "help|?")) {
-                readline_set_completion_index(mon->rs, strlen(str));
-                for (cmd = cmd_table; cmd->name != NULL; cmd++) {
-                    cmd_completion(mon, str, cmd->name);
-                }
+                monitor_find_completion_by_table(mon, cmd_table,
+                                                 &args[1], nb_args - 1);
             }
             break;
         default: