Patchwork sysctl net: Keep tcp_syn_retries inside the boundary

login
register
mail settings
Submitter Michal Tesar
Date July 19, 2013, 10:47 a.m.
Message ID <1374230873-30070-1-git-send-email-mtesar@redhat.com>
Download mbox | patch
Permalink /patch/260238/
State Superseded
Delegated to: David Miller
Headers show

Comments

Michal Tesar - July 19, 2013, 10:47 a.m.
Limit the min/max value passed to the
/proc/sys/net/ipv4/tcp_syn_retries.

Signed-off-by: Michal Tesar <mtesar@redhat.com>
---
 net/ipv4/sysctl_net_ipv4.c |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)
Sergei Shtylyov - July 19, 2013, 2:08 p.m.
Hello.

On 19-07-2013 14:47, Michal Tesar wrote:

> Limit the min/max value passed to the
> /proc/sys/net/ipv4/tcp_syn_retries.

> Signed-off-by: Michal Tesar <mtesar@redhat.com>
> ---
>   net/ipv4/sysctl_net_ipv4.c |    6 +++++-
>   1 files changed, 5 insertions(+), 1 deletions(-)

> diff --git a/net/ipv4/sysctl_net_ipv4.c b/net/ipv4/sysctl_net_ipv4.c
> index b2c123c..fdc2a17 100644
> --- a/net/ipv4/sysctl_net_ipv4.c
> +++ b/net/ipv4/sysctl_net_ipv4.c
[...]
> @@ -332,7 +334,9 @@ static struct ctl_table ipv4_table[] = {
>   		.data		= &sysctl_tcp_syn_retries,
>   		.maxlen		= sizeof(int),
>   		.mode		= 0644,
> -		.proc_handler	= proc_dointvec
> +		.proc_handler	= proc_dointvec_minmax,
> +        .extra1     = &tcp_syn_retries_min,
> +        .extra2     = &tcp_syn_retries_max

    You should indent with tabs, not spaces.

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/net/ipv4/sysctl_net_ipv4.c b/net/ipv4/sysctl_net_ipv4.c
index b2c123c..fdc2a17 100644
--- a/net/ipv4/sysctl_net_ipv4.c
+++ b/net/ipv4/sysctl_net_ipv4.c
@@ -36,6 +36,8 @@  static int tcp_adv_win_scale_min = -31;
 static int tcp_adv_win_scale_max = 31;
 static int ip_ttl_min = 1;
 static int ip_ttl_max = 255;
+static int tcp_syn_retries_min = 1;
+static int tcp_syn_retries_max = MAX_TCP_SYNCNT;
 static int ip_ping_group_range_min[] = { 0, 0 };
 static int ip_ping_group_range_max[] = { GID_T_MAX, GID_T_MAX };
 
@@ -332,7 +334,9 @@  static struct ctl_table ipv4_table[] = {
 		.data		= &sysctl_tcp_syn_retries,
 		.maxlen		= sizeof(int),
 		.mode		= 0644,
-		.proc_handler	= proc_dointvec
+		.proc_handler	= proc_dointvec_minmax,
+        .extra1     = &tcp_syn_retries_min,
+        .extra2     = &tcp_syn_retries_max
 	},
 	{
 		.procname	= "tcp_synack_retries",