Patchwork ide: replace strict_strtol() with kstrtol()

login
register
mail settings
Submitter Jingoo Han
Date July 19, 2013, 7:01 a.m.
Message ID <000b01ce844d$c9735490$5c59fdb0$@samsung.com>
Download mbox | patch
Permalink /patch/260191/
State Accepted
Delegated to: David Miller
Headers show

Comments

Jingoo Han - July 19, 2013, 7:01 a.m.
The usage of strict_strtol() is not preferred, because
strict_strtol() is obsolete. Thus, kstrtol() should be
used.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
 drivers/ide/ide-park.c |    6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
David Miller - Sept. 5, 2013, 7:38 p.m.
From: Jingoo Han <jg1.han@samsung.com>
Date: Fri, 19 Jul 2013 16:01:26 +0900

> The usage of strict_strtol() is not preferred, because
> strict_strtol() is obsolete. Thus, kstrtol() should be
> used.
> 
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/ide/ide-park.c b/drivers/ide/ide-park.c
index 6ab9ab2..f41558a 100644
--- a/drivers/ide/ide-park.c
+++ b/drivers/ide/ide-park.c
@@ -116,8 +116,10 @@  ssize_t ide_park_store(struct device *dev, struct device_attribute *attr,
 	long int input;
 	int rc;
 
-	rc = strict_strtol(buf, 10, &input);
-	if (rc || input < -2)
+	rc = kstrtol(buf, 10, &input);
+	if (rc)
+		return rc;
+	if (input < -2)
 		return -EINVAL;
 	if (input > MAX_PARK_TIMEOUT) {
 		input = MAX_PARK_TIMEOUT;