Patchwork NET: pch_gbe depends on x86

login
register
mail settings
Submitter Jiri Slaby
Date July 19, 2013, 6:26 a.m.
Message ID <1374215169-28866-1-git-send-email-jslaby@suse.cz>
Download mbox | patch
Permalink /patch/260187/
State Accepted
Delegated to: David Miller
Headers show

Comments

Jiri Slaby - July 19, 2013, 6:26 a.m.
Since 4bb1667255a86360721291fe59991d033bbc2f2a (build some drivers only
when compile-testing), PTP_1588_CLOCK_PCH depends on (X86 ||
COMPILE_TEST). But PCH_GBE selects PTP_1588_CLOCK_PCH without
depending on x86. Fix this by adding the same dependency here.

Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Reported-by: <fengguang.wu@intel.com> [intel's build test robot]
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Ben Hutchings <ben@decadent.org.uk>
Cc: netdev@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: kbuild-all@01.org
---
 drivers/net/ethernet/oki-semi/pch_gbe/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
David Miller - July 22, 2013, 9:51 p.m.
From: Jiri Slaby <jslaby@suse.cz>
Date: Fri, 19 Jul 2013 08:26:09 +0200

> Since 4bb1667255a86360721291fe59991d033bbc2f2a (build some drivers only
> when compile-testing), PTP_1588_CLOCK_PCH depends on (X86 ||
> COMPILE_TEST). But PCH_GBE selects PTP_1588_CLOCK_PCH without
> depending on x86. Fix this by adding the same dependency here.
> 
> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
> Reported-by: <fengguang.wu@intel.com> [intel's build test robot]

Applied, thanks.

Please use lowercase "net: " not uppercase "NET: " in your commit
subject lines.  I fixed it for you this time.

Thank you.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/net/ethernet/oki-semi/pch_gbe/Kconfig b/drivers/net/ethernet/oki-semi/pch_gbe/Kconfig
index cb22341..a588ffd 100644
--- a/drivers/net/ethernet/oki-semi/pch_gbe/Kconfig
+++ b/drivers/net/ethernet/oki-semi/pch_gbe/Kconfig
@@ -4,7 +4,7 @@ 
 
 config PCH_GBE
 	tristate "OKI SEMICONDUCTOR IOH(ML7223/ML7831) GbE"
-	depends on PCI
+	depends on PCI && (X86 || COMPILE_TEST)
 	select MII
 	select PTP_1588_CLOCK_PCH
 	---help---