| Message ID | 51E7F220.4090308@gjlay.de |
|---|---|
| State | New |
| Headers | show |
On Jul 18, 2013, at 6:48 AM, Georg-Johann Lay <avr@gjlay.de> wrote: > running the cilk-plus.exp tests I get ~200 FAILs because the tests are not > written for 16-bit int or size_t platforms. > > As a quick tentative fix, the cilk-plus tests are skipped on such platforms. I think this patch is fine. Until such time until cilk can do better, I think this is a fine way to address the issue. The other possible way is to not spin up any support for cilk on such a platform in the first place. noconfigdir is one common way to do this.
> -----Original Message----- > From: Mike Stump [mailto:mikestump@comcast.net] > Sent: Thursday, July 18, 2013 2:14 PM > To: Georg-Johann Lay > Cc: gcc-patches@gcc.gnu.org; Iyer, Balaji V > Subject: Re: [patch,cilk-plus,testsuite] Skip int16 and size16 targets (too much > FAILs) > > On Jul 18, 2013, at 6:48 AM, Georg-Johann Lay <avr@gjlay.de> wrote: > > running the cilk-plus.exp tests I get ~200 FAILs because the tests are > > not written for 16-bit int or size_t platforms. > > > > As a quick tentative fix, the cilk-plus tests are skipped on such platforms. > > I think this patch is fine. Until such time until cilk can do better, I think this is a > fine way to address the issue. The other possible way is to not spin up any > support for cilk on such a platform in the first place. noconfigdir is one common > way to do this. Hi Mike, The changes we have committed thus far does not require the cilk runtime. Thanks, Balaji V. Iyer.
Index: lib/target-supports.exp =================================================================== --- lib/target-supports.exp (revision 200903) +++ lib/target-supports.exp (working copy) @@ -1132,6 +1132,24 @@ proc check_effective_target_static_libgf } "-static"] } +# Return 1 if cilk-plus is supported by the target, 0 otherwise. + +proc check_effective_target_cilkplus { } { + # Skip cilk-plus tests on int16 and size16 targets for now. + # The cilk-plus tests are not generic enough to cover these + # cases and would throw hundreds of FAILs. + if { [check_effective_target_int16] + || ![check_effective_target_size32plus] } { + return 0; + } + + # Skip AVR, its RAM is too small and too many tests would fail. + if { [istarget avr-*-*] } { + return 0; + } + return 1 +} + proc check_linker_plugin_available { } { return [check_no_compiler_messages_nocache linker_plugin executable { int main() { return 0; } Index: gcc.dg/cilk-plus/cilk-plus.exp =================================================================== --- gcc.dg/cilk-plus/cilk-plus.exp (revision 200903) +++ gcc.dg/cilk-plus/cilk-plus.exp (working copy) @@ -19,6 +19,10 @@ load_lib gcc-dg.exp +if { ![check_effective_target_cilkplus] } { + return; +} + dg-init dg-runtest [lsort [glob -nocomplain $srcdir/c-c++-common/cilk-plus/AN/*.c]] " -fcilkplus" " " dg-runtest [lsort [glob -nocomplain $srcdir/c-c++-common/cilk-plus/AN/*.c]] " -O0 -fcilkplus" " " Index: g++.dg/cilk-plus/cilk-plus.exp =================================================================== --- g++.dg/cilk-plus/cilk-plus.exp (revision 200903) +++ g++.dg/cilk-plus/cilk-plus.exp (working copy) @@ -19,6 +19,10 @@ load_lib g++-dg.exp +if { ![check_effective_target_cilkplus] } { + return; +} + dg-init dg-runtest [lsort [glob -nocomplain $srcdir/c-c++-common/cilk-plus/AN/*.c]] " -fcilkplus" " " dg-runtest [lsort [glob -nocomplain $srcdir/c-c++-common/cilk-plus/AN/*.c]] " -O0 -fcilkplus" " "