| Message ID | 1374152286-12955-1-git-send-email-u.kleine-koenig@pengutronix.de |
|---|---|
| State | New |
| Headers | show |
On Thu, Jul 18, 2013 at 02:58:06PM +0200, Uwe Kleine-König wrote: > Similar to commit > > 0e44b6e (gpio/mxc: add chained_irq_enter/exit() to mx3_gpio_irq_handler()) > > . It doesn't seem to be critical to make the irqs work, but still it is > more correct. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Acked-by: Shawn Guo <shawn.guo@linaro.org> You may need to send the patch to Linus Walleij <linus.walleij@linaro.org>, who seems to be collecting GPIO drive changes recently. Shawn
On Thu, Jul 18, 2013 at 2:58 PM, Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote: > Similar to commit > > 0e44b6e (gpio/mxc: add chained_irq_enter/exit() to mx3_gpio_irq_handler()) > > . It doesn't seem to be critical to make the irqs work, but still it is > more correct. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Patch is fine, but looks like this to me: Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" <linux-arm-kernel-bounces@lists.infradead.org> Errors-To: linux-arm-kernel-bounces+linus.walleij=linaro.org@lists.infradead.org U2ltaWxhciB0byBjb21taXQKCgkwZTQ0YjZlIChncGlvL214YzogYWRkIGNoYWluZWRfaXJxX2Vu dGVyL2V4aXQoKSB0byBteDNfZ3Bpb19pcnFfaGFuZGxlcigpKQoKLiBJdCBkb2Vzbid0IHNlZW0g dG8gYmUgY3JpdGljYWwgdG8gbWFrZSB0aGUgaXJxcyB3b3JrLCBidXQgc3RpbGwgaXQgaXMKbW9y ZSBjb3JyZWN0LgoKU2lnbmVkLW9mZi1ieTogVXdlIEtsZWluZS1Lw7ZuaWcgPHUua2xlaW5lLWtv ZW5pZ0BwZW5ndXRyb25peC5kZT4KLS0tCkhlbGxvLAoKbm90ZSB0aGlzIGlzIGNvbXBsZXRlbHkg dW50ZXN0ZWQuCgpVd2UKCiBkcml2ZXJzL2dwaW8vZ3Bpby1teGMuYyB8IDQgKysrKwogMSBmaWxl The encoding is what screw things up. Can you see if you can resend this without using base64? Yours, Linus Walleij
Hi Linus, On Mon, Jul 29, 2013 at 05:51:17PM +0200, Linus Walleij wrote: > On Thu, Jul 18, 2013 at 2:58 PM, Uwe Kleine-König > <u.kleine-koenig@pengutronix.de> wrote: > > > Similar to commit > > > > 0e44b6e (gpio/mxc: add chained_irq_enter/exit() to mx3_gpio_irq_handler()) > > > > . It doesn't seem to be critical to make the irqs work, but still it is > > more correct. > > > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > > Patch is fine, but looks like this to me: > > Content-Transfer-Encoding: base64 > > Sender: "linux-arm-kernel" <linux-arm-kernel-bounces@lists.infradead.org> > Errors-To: linux-arm-kernel-bounces+linus.walleij=linaro.org@lists.infradead.org > > U2ltaWxhciB0byBjb21taXQKCgkwZTQ0YjZlIChncGlvL214YzogYWRkIGNoYWluZWRfaXJxX2Vu > dGVyL2V4aXQoKSB0byBteDNfZ3Bpb19pcnFfaGFuZGxlcigpKQoKLiBJdCBkb2Vzbid0IHNlZW0g > dG8gYmUgY3JpdGljYWwgdG8gbWFrZSB0aGUgaXJxcyB3b3JrLCBidXQgc3RpbGwgaXQgaXMKbW9y > ZSBjb3JyZWN0LgoKU2lnbmVkLW9mZi1ieTogVXdlIEtsZWluZS1Lw7ZuaWcgPHUua2xlaW5lLWtv > ZW5pZ0BwZW5ndXRyb25peC5kZT4KLS0tCkhlbGxvLAoKbm90ZSB0aGlzIGlzIGNvbXBsZXRlbHkg > dW50ZXN0ZWQuCgpVd2UKCiBkcml2ZXJzL2dwaW8vZ3Bpby1teGMuYyB8IDQgKysrKwogMSBmaWxl > > The encoding is what screw things up. That means git is unable to apply base64 encoded mail? Hmm, testing with git 1.8.3.2 (from Debian) I can apply the base64 encoded patch. Does your git have 87ab799234639c26ea10de74782fa511cb3ca606 (i.e. is older than 1.5.1)? > Can you see if you can resend this without using base64? The version I got back via the kernel@pengutronix.de address has: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit and the content is readable just fine in an editor. My copy I got via the linux-arm-kernel subscription is base64 encoded, too. So a mail server on the way to you reencodes my mail. At gmane (http://article.gmane.org/gmane.linux.ports.arm.kernel/252948/raw) it's already base64. According to the Received: headers it can only be casper.infradead.org or merlin.infradead.org. I found http://mail.python.org/pipermail/mailman-users/2008-September/063286.html which is really annoying. I'll bounce you the original. Best regards Uwe
On Tue, Jul 30, 2013 at 9:39 AM, Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote: >> The encoding is what screw things up. > That means git is unable to apply base64 encoded mail? Hmm, testing with > git 1.8.3.2 (from Debian) I can apply the base64 encoded patch. > Does your git have 87ab799234639c26ea10de74782fa511cb3ca606 (i.e. is > older than 1.5.1)? Hm it works, I just never tried it ... nevermind. Patch applied with Shawn's ACK. Yours, Linus Walleij
diff --git a/drivers/gpio/gpio-mxc.c b/drivers/gpio/gpio-mxc.c index 7176743..832881c 100644 --- a/drivers/gpio/gpio-mxc.c +++ b/drivers/gpio/gpio-mxc.c @@ -291,6 +291,9 @@ static void mx2_gpio_irq_handler(u32 irq, struct irq_desc *desc) { u32 irq_msk, irq_stat; struct mxc_gpio_port *port; + struct irq_chip *chip = irq_get_chip(irq); + + chained_irq_enter(chip, desc); /* walk through all interrupt status registers */ list_for_each_entry(port, &mxc_gpio_ports, node) { @@ -302,6 +305,7 @@ static void mx2_gpio_irq_handler(u32 irq, struct irq_desc *desc) if (irq_stat) mxc_gpio_irq_handler(port, irq_stat); } + chained_irq_exit(chip, desc); } /*
Similar to commit 0e44b6e (gpio/mxc: add chained_irq_enter/exit() to mx3_gpio_irq_handler()) . It doesn't seem to be critical to make the irqs work, but still it is more correct. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> --- Hello, note this is completely untested. Uwe drivers/gpio/gpio-mxc.c | 4 ++++ 1 file changed, 4 insertions(+)