diff mbox

[U-Boot] Ethernet support broken for Wandboard Quad on master

Message ID CAOMZO5CXCmeDYTKT9LyznfL=NoBdBq5Pbxeamh3vhODfcuUFnw@mail.gmail.com
State Not Applicable
Headers show

Commit Message

Fabio Estevam July 18, 2013, 11:41 a.m. UTC 
On Thu, Jul 18, 2013 at 8:31 AM, Fabio Estevam <festevam@gmail.com> wrote:
> Hi Sascha,
>
> On Thu, Jul 18, 2013 at 6:07 AM, Sascha Silbe <t-uboot@infra-silbe.de> wrote:
>> Sascha Silbe <t-uboot@infra-silbe.de> writes:
>>
>>> I've started a git bisect run (booting via USB OTG), but it's going to
>>> take a while as git bisect is throwing lots of commits without Wandboard
>>> Quad support at me and seems to be only narrowing down the commits one
>>> by one rather than on a log-2 basis.
>>
>> A slightly more refined approach (cherry-picking the Wandboard Quad
>> support patch each time the build fails) enabled git bisect to track the
>> breakage down to:
>>
>> commit de1d786edf01035f60a87e1e0f917a4169dc6964
>> Author: Charles Coldwell <coldwell@gmail.com>
>> Date:   Thu Feb 21 08:25:52 2013 -0500
>>
>>     add support for Xilinx 1000BASE-X phy (GTX)
>>
>>     commit 39695029bc15041c809df3db4ba19bd729c447fa
>>     Author: Charles Coldwell <coldwell@ll.mit.edu>
>>     Date:   Tue Feb 19 08:27:33 2013 -0500
>>
>>         Changes to support the Xilinx 1000BASE-X phy (GTX/MGT)
>>
>>     Signed-off-by: Charles Coldwell <coldwell@ll.mit.edu>
>
> I confirm the same here: currently ethernet is broken in U-boot master
> and reverting such commit make it work again.

I have tried:


,but it still did not fix the issue.

Charles/Joe,

Any ideas?
diff mbox

Patch

--- a/drivers/net/phy/phy.c
+++ b/drivers/net/phy/phy.c
@@ -404,7 +404,7 @@  int genphy_config(struct phy_device *phydev)
                if (val & ESTATUS_1000_XFULL)
                        features |= SUPPORTED_1000baseX_Full;
                if (val & ESTATUS_1000_XHALF)
-                       features |= SUPPORTED_1000baseX_Full;
+                       features |= SUPPORTED_1000baseX_Half;
        }

        phydev->supported = features;