Patchwork [1/1] package/python-pyro: adding Pyro 3.14

login
register
mail settings
Submitter Fabien Marteau
Date July 18, 2013, 7:50 a.m.
Message ID <1374133806-9162-2-git-send-email-fabien.marteau@armadeus.com>
Download mbox | patch
Permalink /patch/260029/
State Superseded
Headers show

Comments

Fabien Marteau - July 18, 2013, 7:50 a.m.
Signed-off-by: Fabien Marteau <fabien.marteau@armadeus.com>
---
 package/python-pyro/Config.in      |    9 +++++++++
 package/python-pyro/python-pyro.mk |   17 +++++++++++++++++
 2 files changed, 26 insertions(+)
 create mode 100644 package/python-pyro/Config.in
 create mode 100644 package/python-pyro/python-pyro.mk
Peter Korsgaard - July 21, 2013, 10:17 p.m.
>>>>> "Fabien" == Fabien Marteau <fabien.marteau@armadeus.com> writes:

 Fabien> Signed-off-by: Fabien Marteau <fabien.marteau@armadeus.com>
 Fabien> ---
 Fabien>  package/python-pyro/Config.in      |    9 +++++++++
 Fabien>  package/python-pyro/python-pyro.mk |   17 +++++++++++++++++
 Fabien>  2 files changed, 26 insertions(+)
 Fabien>  create mode 100644 package/python-pyro/Config.in
 Fabien>  create mode 100644 package/python-pyro/python-pyro.mk

You seem to have forgotten to add it to package/Config.in, so it cannot
be used.

 Fabien> diff --git a/package/python-pyro/Config.in b/package/python-pyro/Config.in
 Fabien> new file mode 100644
 Fabien> index 0000000..b744c1c
 Fabien> --- /dev/null
 Fabien> +++ b/package/python-pyro/Config.in
 Fabien> @@ -0,0 +1,9 @@
 Fabien> +config BR2_PACKAGE_PYTHON_PYRO
 Fabien> +	bool "python-pyro"
 Fabien> +	depends on BR2_PACKAGE_PYTHON
 Fabien> +	help
 Fabien> +	  python-pyro is a Python library stands for PYthon Remote Objects.
 Fabien> +		It is an advanced and powerful Distributed Object Technology system
 Fabien> +		written entirely in Python, that is designed to be very easy to use..

Indentation of line 2/3 of the help text wrong (should be <tab><space><space>)

 Fabien> +++ b/package/python-pyro/python-pyro.mk
 Fabien> @@ -0,0 +1,17 @@
 Fabien> +#############################################################
 Fabien> +#
 Fabien> +# python-pyro
 Fabien> +#
 Fabien> +#############################################################

Minor nit: the #### lines should be 80 chars.

 Fabien> +
 Fabien> +PYTHON_PYRO_VERSION = 3.14
 Fabien> +PYTHON_PYRO_SOURCE  = Pyro-$(PYTHON_PYRO_VERSION).tar.gz
 Fabien> +PYTHON_PYRO_SITE    = https://pypi.python.org/packages/source/P/Pyro/

Please add LICENSE / LICENSE_FILES tags

Otherwise it looks good. Care to fix this issues and resend?
Fabien Marteau - July 22, 2013, 6:48 a.m.
Hi peter,

>
> Otherwise it looks good. Care to fix this issues and resend?
Ok I'm trying to do that today.

Regards,

Patch

diff --git a/package/python-pyro/Config.in b/package/python-pyro/Config.in
new file mode 100644
index 0000000..b744c1c
--- /dev/null
+++ b/package/python-pyro/Config.in
@@ -0,0 +1,9 @@ 
+config BR2_PACKAGE_PYTHON_PYRO
+	bool "python-pyro"
+	depends on BR2_PACKAGE_PYTHON
+	help
+	  python-pyro is a Python library stands for PYthon Remote Objects.
+		It is an advanced and powerful Distributed Object Technology system
+		written entirely in Python, that is designed to be very easy to use..
+
+	  https://pypi.python.org/pypi/Pyro/3.14
diff --git a/package/python-pyro/python-pyro.mk b/package/python-pyro/python-pyro.mk
new file mode 100644
index 0000000..1b3b904
--- /dev/null
+++ b/package/python-pyro/python-pyro.mk
@@ -0,0 +1,17 @@ 
+#############################################################
+#
+# python-pyro
+#
+#############################################################
+
+PYTHON_PYRO_VERSION = 3.14
+PYTHON_PYRO_SOURCE  = Pyro-$(PYTHON_PYRO_VERSION).tar.gz
+PYTHON_PYRO_SITE    = https://pypi.python.org/packages/source/P/Pyro/
+
+PYTHON_PYRO_DEPENDENCIES = python
+
+define PYTHON_PYRO_INSTALL_TARGET_CMDS
+	(cd $(@D); $(HOST_DIR)/usr/bin/python setup.py install --prefix=$(TARGET_DIR)/usr)
+endef
+
+$(eval $(generic-package))