From patchwork Wed Jul 17 21:20:33 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexey Khoroshilov X-Patchwork-Id: 259769 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 4E7F12C00AB for ; Thu, 18 Jul 2013 07:21:11 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757396Ab3GQVUx (ORCPT ); Wed, 17 Jul 2013 17:20:53 -0400 Received: from mail.ispras.ru ([83.149.199.45]:54098 "EHLO mail.ispras.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754879Ab3GQVUu (ORCPT ); Wed, 17 Jul 2013 17:20:50 -0400 Received: from localhost.localdomain (ppp91-77-199-253.pppoe.mtu-net.ru [91.77.199.253]) by mail.ispras.ru (Postfix) with ESMTPSA id 78B03540159; Thu, 18 Jul 2013 01:20:48 +0400 (MSK) From: Alexey Khoroshilov To: Wolfgang Grandegger , Marc Kleine-Budde Cc: Alexey Khoroshilov , Bernd Krumboeck , linux-can@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, ldv-project@linuxtesting.org Subject: [PATCH] can: usb_8dev: fix urb leak on failure path in usb_8dev_start() Date: Thu, 18 Jul 2013 01:20:33 +0400 Message-Id: <1374096033-28981-1-git-send-email-khoroshilov@ispras.ru> X-Mailer: git-send-email 1.8.1.2 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org If usb_8dev_start() fails to submit urb, it unanchors the urb but forgets to free it. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov --- drivers/net/can/usb/usb_8dev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/can/usb/usb_8dev.c b/drivers/net/can/usb/usb_8dev.c index cbd388e..8becd3d 100644 --- a/drivers/net/can/usb/usb_8dev.c +++ b/drivers/net/can/usb/usb_8dev.c @@ -779,6 +779,7 @@ static int usb_8dev_start(struct usb_8dev_priv *priv) usb_unanchor_urb(urb); usb_free_coherent(priv->udev, RX_BUFFER_SIZE, buf, urb->transfer_dma); + usb_free_urb(urb); break; }