Patchwork [U-Boot,1/1] ddr cfg: DRAM_RESET needs 0x00020030

login
register
mail settings
Submitter Troy Kisky
Date July 17, 2013, 7:46 p.m.
Message ID <1374090375-21216-1-git-send-email-troy.kisky@boundarydevices.com>
Download mbox | patch
Permalink /patch/259738/
State Accepted
Delegated to: Tom Rini
Headers show

Comments

Troy Kisky - July 17, 2013, 7:46 p.m.
The old value of 0x000e0030 will cause ethernet
timeout issues on the sabrelite and possibly other
boards using the KSZ9021.
I have no explanation as to why.

But this is a correct change, the TRM will be updated
to show that 00b is the only valid setting for bits
19-18 of DRAM_RESET.

My thanks go to Liu Hui(Jason) for this information.

Signed-off-by: Troy Kisky <troy.kisky@boundarydevices.com>
---
 board/boundary/nitrogen6x/ddr-setup.cfg | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Fabio Estevam - July 19, 2013, 9 p.m.
Hi Troy,

On Wed, Jul 17, 2013 at 4:46 PM, Troy Kisky
<troy.kisky@boundarydevices.com> wrote:
> The old value of 0x000e0030 will cause ethernet
> timeout issues on the sabrelite and possibly other
> boards using the KSZ9021.
> I have no explanation as to why.
>
> But this is a correct change, the TRM will be updated
> to show that 00b is the only valid setting for bits
> 19-18 of DRAM_RESET.
>
> My thanks go to Liu Hui(Jason) for this information.
>
> Signed-off-by: Troy Kisky <troy.kisky@boundarydevices.com>

Should this go into 2013.07?
Troy Kisky - July 19, 2013, 9:34 p.m.
On 7/19/2013 2:00 PM, Fabio Estevam wrote:
> Hi Troy,
>
> On Wed, Jul 17, 2013 at 4:46 PM, Troy Kisky
> <troy.kisky@boundarydevices.com> wrote:
>> The old value of 0x000e0030 will cause ethernet
>> timeout issues on the sabrelite and possibly other
>> boards using the KSZ9021.
>> I have no explanation as to why.
>>
>> But this is a correct change, the TRM will be updated
>> to show that 00b is the only valid setting for bits
>> 19-18 of DRAM_RESET.
>>
>> My thanks go to Liu Hui(Jason) for this information.
>>
>> Signed-off-by: Troy Kisky <troy.kisky@boundarydevices.com>
> Should this go into 2013.07?
>

If not too late. It only affect Nitrogen6x, at least until Sabrelite is 
combined with it.
And Sabrelite is already using this value.

Troy
Tom Rini - July 19, 2013, 9:50 p.m.
On Fri, Jul 19, 2013 at 02:34:55PM -0700, Troy Kisky wrote:
> On 7/19/2013 2:00 PM, Fabio Estevam wrote:
> >Hi Troy,
> >
> >On Wed, Jul 17, 2013 at 4:46 PM, Troy Kisky
> ><troy.kisky@boundarydevices.com> wrote:
> >>The old value of 0x000e0030 will cause ethernet
> >>timeout issues on the sabrelite and possibly other
> >>boards using the KSZ9021.
> >>I have no explanation as to why.
> >>
> >>But this is a correct change, the TRM will be updated
> >>to show that 00b is the only valid setting for bits
> >>19-18 of DRAM_RESET.
> >>
> >>My thanks go to Liu Hui(Jason) for this information.
> >>
> >>Signed-off-by: Troy Kisky <troy.kisky@boundarydevices.com>
> >Should this go into 2013.07?
> >
> 
> If not too late. It only affect Nitrogen6x, at least until Sabrelite
> is combined with it.
> And Sabrelite is already using this value.

Whose acks should I wait for on this?
Fabio Estevam - July 19, 2013, 9:54 p.m.
On Wed, Jul 17, 2013 at 4:46 PM, Troy Kisky
<troy.kisky@boundarydevices.com> wrote:
> The old value of 0x000e0030 will cause ethernet
> timeout issues on the sabrelite and possibly other
> boards using the KSZ9021.
> I have no explanation as to why.
>
> But this is a correct change, the TRM will be updated
> to show that 00b is the only valid setting for bits
> 19-18 of DRAM_RESET.
>
> My thanks go to Liu Hui(Jason) for this information.
>
> Signed-off-by: Troy Kisky <troy.kisky@boundarydevices.com>

Acked-by: Fabio Estevam <fabio.estevam@freescale.com>
Fabio Estevam - July 19, 2013, 10:04 p.m.
Hi Tom,

On Fri, Jul 19, 2013 at 6:50 PM, Tom Rini <trini@ti.com> wrote:
> On Fri, Jul 19, 2013 at 02:34:55PM -0700, Troy Kisky wrote:
>> On 7/19/2013 2:00 PM, Fabio Estevam wrote:
>> >Hi Troy,
>> >
>> >On Wed, Jul 17, 2013 at 4:46 PM, Troy Kisky
>> ><troy.kisky@boundarydevices.com> wrote:
>> >>The old value of 0x000e0030 will cause ethernet
>> >>timeout issues on the sabrelite and possibly other
>> >>boards using the KSZ9021.
>> >>I have no explanation as to why.
>> >>
>> >>But this is a correct change, the TRM will be updated
>> >>to show that 00b is the only valid setting for bits
>> >>19-18 of DRAM_RESET.
>> >>
>> >>My thanks go to Liu Hui(Jason) for this information.
>> >>
>> >>Signed-off-by: Troy Kisky <troy.kisky@boundarydevices.com>
>> >Should this go into 2013.07?
>> >
>>
>> If not too late. It only affect Nitrogen6x, at least until Sabrelite
>> is combined with it.
>> And Sabrelite is already using this value.
>
> Whose acks should I wait for on this?

Just realized I acked in the original message and you were not on Cc, so

Acked-by: Fabio Estevam <fabio.estevam@freescale.com>

As Jason Liu explained the mx6 reference manual will be updated to fix
the incorrect setting.

Thanks,

Fabio Estevam
Stefano Babic - July 20, 2013, 4:01 p.m.
Hi Tom,

Am 19/07/2013 23:50, schrieb Tom Rini:
> On Fri, Jul 19, 2013 at 02:34:55PM -0700, Troy Kisky wrote:

>> On 7/19/2013 2:00 PM, Fabio Estevam wrote:
>>> Hi Troy,
>>>
>>> On Wed, Jul 17, 2013 at 4:46 PM, Troy Kisky
>>> <troy.kisky@boundarydevices.com> wrote:
>>>> The old value of 0x000e0030 will cause ethernet
>>>> timeout issues on the sabrelite and possibly other
>>>> boards using the KSZ9021.
>>>> I have no explanation as to why.
>>>>
>>>> But this is a correct change, the TRM will be updated
>>>> to show that 00b is the only valid setting for bits
>>>> 19-18 of DRAM_RESET.
>>>>
>>>> My thanks go to Liu Hui(Jason) for this information.
>>>>
>>>> Signed-off-by: Troy Kisky <troy.kisky@boundarydevices.com>
>>> Should this go into 2013.07?
>>>
>>
>> If not too late. It only affect Nitrogen6x, at least until Sabrelite
>> is combined with it.
>> And Sabrelite is already using this value.
> 
> Whose acks should I wait for on this?

Acked-by: Stefano Babic <sbabic@denx.de>

From the i.MX point of view, the patch is a fix for the RAM
configuration and does not affects other boards but only the nitrogen. I
had merged this in u-boot-imx, but it is too late for PR. If it is not
too late, please merge it for release.

Many thanks,
Stefano
Tom Rini - July 20, 2013, 4:14 p.m.
On Sat, Jul 20, 2013 at 06:01:56PM +0200, Stefano Babic wrote:
> Hi Tom,
> 
> Am 19/07/2013 23:50, schrieb Tom Rini:
> > On Fri, Jul 19, 2013 at 02:34:55PM -0700, Troy Kisky wrote:
> 
> >> On 7/19/2013 2:00 PM, Fabio Estevam wrote:
> >>> Hi Troy,
> >>>
> >>> On Wed, Jul 17, 2013 at 4:46 PM, Troy Kisky
> >>> <troy.kisky@boundarydevices.com> wrote:
> >>>> The old value of 0x000e0030 will cause ethernet
> >>>> timeout issues on the sabrelite and possibly other
> >>>> boards using the KSZ9021.
> >>>> I have no explanation as to why.
> >>>>
> >>>> But this is a correct change, the TRM will be updated
> >>>> to show that 00b is the only valid setting for bits
> >>>> 19-18 of DRAM_RESET.
> >>>>
> >>>> My thanks go to Liu Hui(Jason) for this information.
> >>>>
> >>>> Signed-off-by: Troy Kisky <troy.kisky@boundarydevices.com>
> >>> Should this go into 2013.07?
> >>>
> >>
> >> If not too late. It only affect Nitrogen6x, at least until Sabrelite
> >> is combined with it.
> >> And Sabrelite is already using this value.
> > 
> > Whose acks should I wait for on this?
> 
> Acked-by: Stefano Babic <sbabic@denx.de>
> 
> From the i.MX point of view, the patch is a fix for the RAM
> configuration and does not affects other boards but only the nitrogen. I
> had merged this in u-boot-imx, but it is too late for PR. If it is not
> too late, please merge it for release.

Applied to u-boot/master, thanks!
Dirk Behme - July 22, 2013, 6:27 a.m.
On 17.07.2013 21:46, Troy Kisky wrote:
> The old value of 0x000e0030 will cause ethernet
> timeout issues on the sabrelite and possibly other
> boards using the KSZ9021.
> I have no explanation as to why.
>
> But this is a correct change, the TRM will be updated
> to show that 00b is the only valid setting for bits
> 19-18 of DRAM_RESET.
>
> My thanks go to Liu Hui(Jason) for this information.
>
> Signed-off-by: Troy Kisky <troy.kisky@boundarydevices.com>

Acked-by: Dirk Behme <dirk.behme@de.bosch.com>

Thanks

Dirk

> ---
>   board/boundary/nitrogen6x/ddr-setup.cfg | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/board/boundary/nitrogen6x/ddr-setup.cfg b/board/boundary/nitrogen6x/ddr-setup.cfg
> index c315812..e5f8add 100644
> --- a/board/boundary/nitrogen6x/ddr-setup.cfg
> +++ b/board/boundary/nitrogen6x/ddr-setup.cfg
> @@ -74,7 +74,7 @@ DATA 4, MX6_IOM_DRAM_RAS, 0x00020030
>   DATA 4, MX6_IOM_DRAM_SDCLK_0, 0x00020030
>   DATA 4, MX6_IOM_DRAM_SDCLK_1, 0x00020030
>
> -DATA 4, MX6_IOM_DRAM_RESET, 0x000e0030
> +DATA 4, MX6_IOM_DRAM_RESET, 0x00020030
>   DATA 4, MX6_IOM_DRAM_SDCKE0, 0x00003000
>   DATA 4, MX6_IOM_DRAM_SDCKE1, 0x00003000

Patch

diff --git a/board/boundary/nitrogen6x/ddr-setup.cfg b/board/boundary/nitrogen6x/ddr-setup.cfg
index c315812..e5f8add 100644
--- a/board/boundary/nitrogen6x/ddr-setup.cfg
+++ b/board/boundary/nitrogen6x/ddr-setup.cfg
@@ -74,7 +74,7 @@  DATA 4, MX6_IOM_DRAM_RAS, 0x00020030
 DATA 4, MX6_IOM_DRAM_SDCLK_0, 0x00020030
 DATA 4, MX6_IOM_DRAM_SDCLK_1, 0x00020030
 
-DATA 4, MX6_IOM_DRAM_RESET, 0x000e0030
+DATA 4, MX6_IOM_DRAM_RESET, 0x00020030
 DATA 4, MX6_IOM_DRAM_SDCKE0, 0x00003000
 DATA 4, MX6_IOM_DRAM_SDCKE1, 0x00003000