Patchwork [v2] powerpc: make Freescale QE support a selectable Kconfig option

login
register
mail settings
Submitter Timur Tabi
Date Oct. 3, 2008, 4:14 p.m.
Message ID <1223050450-32234-1-git-send-email-timur@freescale.com>
Download mbox | patch
Permalink /patch/2593/
State Accepted, archived
Commit 4e330bcf6b323fcff0e3224c5db77cbcca83a878
Delegated to: Kumar Gala
Headers show

Comments

Timur Tabi - Oct. 3, 2008, 4:14 p.m.
Modify the Kconfig so that Freescale QUICC Engine (QE) support is a selectable
option, thereby allowing users to compile kernels without any QE support.

The drawback is that QE support is now disabled by default on platforms that
have a QE, and so a defconfig is needed to enable QE and QE devices (like
UCC GETH).  Fortunately, all the current relevant defconfigs do that already.

Signed-off-by: Timur Tabi <timur@freescale.com>
---

This patch should be applied to Kumar's branch for 2.6.28 patches.

 arch/powerpc/platforms/83xx/Kconfig |    5 -----
 arch/powerpc/platforms/85xx/Kconfig |    1 -
 arch/powerpc/platforms/Kconfig      |    3 ++-
 3 files changed, 2 insertions(+), 7 deletions(-)
Kumar Gala - Oct. 3, 2008, 9:54 p.m.
On Oct 3, 2008, at 11:14 AM, Timur Tabi wrote:

> Modify the Kconfig so that Freescale QUICC Engine (QE) support is a  
> selectable
> option, thereby allowing users to compile kernels without any QE  
> support.
>
> The drawback is that QE support is now disabled by default on  
> platforms that
> have a QE, and so a defconfig is needed to enable QE and QE devices  
> (like
> UCC GETH).  Fortunately, all the current relevant defconfigs do that  
> already.
>
> Signed-off-by: Timur Tabi <timur@freescale.com>
> ---
>
> This patch should be applied to Kumar's branch for 2.6.28 patches.
>
> arch/powerpc/platforms/83xx/Kconfig |    5 -----
> arch/powerpc/platforms/85xx/Kconfig |    1 -
> arch/powerpc/platforms/Kconfig      |    3 ++-
> 3 files changed, 2 insertions(+), 7 deletions(-)

applied

- k
Timur Tabi - Oct. 3, 2008, 9:57 p.m.
Kumar Gala wrote:

> applied

I have a few other patches that I've sent you over the past couple weeks that
you haven't applied:

powerpc: fix conflict with Elo DMA driver in MPC8610 device tree
powerpc: remove CHRP and PMAC support from defconfigs, fix Kconfigs
powerpc: remove support for bootmem-allocated memory for the DIU driver
Kumar Gala - Oct. 3, 2008, 10:16 p.m.
On Oct 3, 2008, at 4:57 PM, Timur Tabi wrote:

> powerpc: fix conflict with Elo DMA driver in MPC8610 device tree

in my queue.

> powerpc: remove CHRP and PMAC support from defconfigs, fix Kconfigs

For BenH to look at.

> powerpc: remove support for bootmem-allocated memory for the DIU  
> driver

I'll take a look

- k

Patch

diff --git a/arch/powerpc/platforms/83xx/Kconfig b/arch/powerpc/platforms/83xx/Kconfig
index 6159c5d..83c664a 100644
--- a/arch/powerpc/platforms/83xx/Kconfig
+++ b/arch/powerpc/platforms/83xx/Kconfig
@@ -19,7 +19,6 @@  config MPC831x_RDB
 config MPC832x_MDS
 	bool "Freescale MPC832x MDS"
 	select DEFAULT_UIMAGE
-	select QUICC_ENGINE
 	select PPC_MPC832x
 	help
 	  This option enables support for the MPC832x MDS evaluation board.
@@ -27,7 +26,6 @@  config MPC832x_MDS
 config MPC832x_RDB
 	bool "Freescale MPC832x RDB"
 	select DEFAULT_UIMAGE
-	select QUICC_ENGINE
 	select PPC_MPC832x
 	help
 	  This option enables support for the MPC8323 RDB board.
@@ -57,15 +55,12 @@  config MPC834x_ITX
 config MPC836x_MDS
 	bool "Freescale MPC836x MDS"
 	select DEFAULT_UIMAGE
-	select QUICC_ENGINE
 	help
 	  This option enables support for the MPC836x MDS Processor Board.
 
 config MPC836x_RDK
 	bool "Freescale/Logic MPC836x RDK"
 	select DEFAULT_UIMAGE
-	select QUICC_ENGINE
-	select QE_GPIO
 	select FSL_GTM
 	select FSL_LBC
 	help
diff --git a/arch/powerpc/platforms/85xx/Kconfig b/arch/powerpc/platforms/85xx/Kconfig
index 291675b..b79dc71 100644
--- a/arch/powerpc/platforms/85xx/Kconfig
+++ b/arch/powerpc/platforms/85xx/Kconfig
@@ -33,7 +33,6 @@  config MPC85xx_CDS
 config MPC85xx_MDS
 	bool "Freescale MPC85xx MDS"
 	select DEFAULT_UIMAGE
-	select QUICC_ENGINE
 	select PHYLIB
 	help
 	  This option enables support for the MPC85xx MDS board
diff --git a/arch/powerpc/platforms/Kconfig b/arch/powerpc/platforms/Kconfig
index 9578c45..6cf517f 100644
--- a/arch/powerpc/platforms/Kconfig
+++ b/arch/powerpc/platforms/Kconfig
@@ -239,7 +239,8 @@  config TAU_AVERAGE
 	  If in doubt, say N here.
 
 config QUICC_ENGINE
-	bool
+	bool "Freescale QUICC Engine (QE) Support"
+	depends on FSL_SOC
 	select PPC_LIB_RHEAP
 	select CRC32
 	help