Patchwork [24/67] libglade: libglib2 requires threads

login
register
mail settings
Submitter Spenser Gilliland
Date July 15, 2013, 7:47 p.m.
Message ID <1373917670-30006-25-git-send-email-spenser@gillilanding.com>
Download mbox | patch
Permalink /patch/259200/
State Accepted
Headers show

Comments

Spenser Gilliland - July 15, 2013, 7:47 p.m.
Signed-off-by: Spenser Gilliland <spenser@gillilanding.com>
---
 package/libglade/Config.in | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
Thomas Petazzoni - July 16, 2013, 8:17 a.m.
Dear Spenser Gilliland,

On Mon, 15 Jul 2013 14:47:07 -0500, Spenser Gilliland wrote:
> 
> Signed-off-by: Spenser Gilliland <spenser@gillilanding.com>
> ---
>  package/libglade/Config.in | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/package/libglade/Config.in b/package/libglade/Config.in
> index f7a9a1c..d042517 100644
> --- a/package/libglade/Config.in
> +++ b/package/libglade/Config.in
> @@ -2,6 +2,7 @@ config BR2_PACKAGE_LIBGLADE
>  	bool "libglade"
>  	depends on BR2_PACKAGE_LIBGTK2
>  	depends on BR2_USE_WCHAR # glib2
> +	depends on BR2_TOOLCHAIN_HAS_THREADS # glib2
>  	select BR2_PACKAGE_LIBGLIB2
>  	select BR2_PACKAGE_ATK
>  	select BR2_PACKAGE_LIBXML2
> @@ -12,5 +13,6 @@ config BR2_PACKAGE_LIBGLADE
>  
>  	  http://ftp.gnome.org/pub/GNOME/sources/libglade/
>  
> -comment "libglade requires a toolchain with WCHAR support"
> -	depends on BR2_PACKAGE_LIBGTK2 && !BR2_USE_WCHAR
> +comment "libglade requires a toolchain with WCHAR and threading support"
> +	depends on BR2_PACKAGE_LIBGTK2 && \
> +		(!BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS)

I also believe this one is not needed, because there is already a
"depends on BR2_PACKAGE_LIBGTK2".

Thomas

Patch

diff --git a/package/libglade/Config.in b/package/libglade/Config.in
index f7a9a1c..d042517 100644
--- a/package/libglade/Config.in
+++ b/package/libglade/Config.in
@@ -2,6 +2,7 @@  config BR2_PACKAGE_LIBGLADE
 	bool "libglade"
 	depends on BR2_PACKAGE_LIBGTK2
 	depends on BR2_USE_WCHAR # glib2
+	depends on BR2_TOOLCHAIN_HAS_THREADS # glib2
 	select BR2_PACKAGE_LIBGLIB2
 	select BR2_PACKAGE_ATK
 	select BR2_PACKAGE_LIBXML2
@@ -12,5 +13,6 @@  config BR2_PACKAGE_LIBGLADE
 
 	  http://ftp.gnome.org/pub/GNOME/sources/libglade/
 
-comment "libglade requires a toolchain with WCHAR support"
-	depends on BR2_PACKAGE_LIBGTK2 && !BR2_USE_WCHAR
+comment "libglade requires a toolchain with WCHAR and threading support"
+	depends on BR2_PACKAGE_LIBGTK2 && \
+		(!BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS)