Patchwork [23/67] libgail: libglib2 requires threads

login
register
mail settings
Submitter Spenser Gilliland
Date July 15, 2013, 7:47 p.m.
Message ID <1373917670-30006-24-git-send-email-spenser@gillilanding.com>
Download mbox | patch
Permalink /patch/259199/
State Accepted
Headers show

Comments

Spenser Gilliland - July 15, 2013, 7:47 p.m.
Signed-off-by: Spenser Gilliland <spenser@gillilanding.com>
---
 package/libgail/Config.in | 6 ++++++
 1 file changed, 6 insertions(+)
Thomas Petazzoni - July 16, 2013, 8:16 a.m.
Dear Spenser Gilliland,

On Mon, 15 Jul 2013 14:47:06 -0500, Spenser Gilliland wrote:
> 
> Signed-off-by: Spenser Gilliland <spenser@gillilanding.com>
> ---
>  package/libgail/Config.in | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/package/libgail/Config.in b/package/libgail/Config.in
> index ba74795..3e1af62 100644
> --- a/package/libgail/Config.in
> +++ b/package/libgail/Config.in
> @@ -1,5 +1,7 @@
>  config BR2_PACKAGE_LIBGAIL
>  	bool "libgail"
> +	depends on BR2_USE_WCHAR # pango -> libglib2
> +	depends on BR2_TOOLCHAIN_HAS_THREADS # pango -> libglib2
>  	depends on BR2_PACKAGE_LIBGTK2
>  	select BR2_PACKAGE_PANGO
>  	help
> @@ -16,3 +18,7 @@ config BR2_PACKAGE_LIBGAIL
>  	  program.
>  
>  	  http://developer.gnome.org/projects/gap
> +
> +comment "libgail requires a toolchain with WCHAR and threading support"
> +	depends on BR2_PACKAGE_LIBGTK2 && \
> +		(!BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS)

This one doesn't seem useful: the libgail package already has a
dependency on libgtk2, so it can't be enabled if gtk2 is not enabled.
And gtk2 can only be enabled if wchar and threads are available.

So this patch is not useful.

Remember: propagation of "depends on" is needed from package A to
package B when package B selects package A. If package B depends on
package A, then there's no point in propagating the "depends on" of
package A to package B.

More aspirin? :-)

Thomas

Patch

diff --git a/package/libgail/Config.in b/package/libgail/Config.in
index ba74795..3e1af62 100644
--- a/package/libgail/Config.in
+++ b/package/libgail/Config.in
@@ -1,5 +1,7 @@ 
 config BR2_PACKAGE_LIBGAIL
 	bool "libgail"
+	depends on BR2_USE_WCHAR # pango -> libglib2
+	depends on BR2_TOOLCHAIN_HAS_THREADS # pango -> libglib2
 	depends on BR2_PACKAGE_LIBGTK2
 	select BR2_PACKAGE_PANGO
 	help
@@ -16,3 +18,7 @@  config BR2_PACKAGE_LIBGAIL
 	  program.
 
 	  http://developer.gnome.org/projects/gap
+
+comment "libgail requires a toolchain with WCHAR and threading support"
+	depends on BR2_PACKAGE_LIBGTK2 && \
+		(!BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS)