Patchwork [2/2] be2net: fix for default setting of pause auto-negotiation

login
register
mail settings
Submitter Ajit Khaparde
Date April 13, 2009, 8:17 a.m.
Message ID <20090413081705.GE6824@serverengines.com>
Download mbox | patch
Permalink /patch/25898/
State Accepted
Delegated to: David Miller
Headers show

Comments

Ajit Khaparde - April 13, 2009, 8:17 a.m.
Hi,
This patch fixes the default value of pause auto-negotiation supported by
PCS.

Thanks
Ajit





Signed-off-by: Ajit Khaparde <ajitk@serverengines.com>
----
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller - April 13, 2009, 10:40 p.m.
From: Ajit Khaparde <ajitk@serverengines.com>
Date: Mon, 13 Apr 2009 13:47:06 +0530

> This patch fixes the default value of pause auto-negotiation supported by
> PCS.
> 
> Thanks
> Ajit
> 
> 

[ Why so many spaces?  Please make your email more tidy, some
  people try to read emails using small screens... ]

> 
> 
> Signed-off-by: Ajit Khaparde <ajitk@serverengines.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/net/benet/be_ethtool.c b/drivers/net/benet/be_ethtool.c
index 04f4b73..9592f22 100644
--- a/drivers/net/benet/be_ethtool.c
+++ b/drivers/net/benet/be_ethtool.c
@@ -319,7 +319,7 @@  be_get_pauseparam(struct net_device *netdev, struct ethtool_pauseparam *ecmd)
 
 	be_cmd_get_flow_control(&adapter->ctrl, &ecmd->tx_pause,
 		&ecmd->rx_pause);
-	ecmd->autoneg = AUTONEG_ENABLE;
+	ecmd->autoneg = 0;
 }
 
 static int
@@ -328,7 +328,7 @@  be_set_pauseparam(struct net_device *netdev, struct ethtool_pauseparam *ecmd)
 	struct be_adapter *adapter = netdev_priv(netdev);
 	int status;
 
-	if (ecmd->autoneg != AUTONEG_ENABLE)
+	if (ecmd->autoneg != 0)
 		return -EINVAL;
 
 	status = be_cmd_set_flow_control(&adapter->ctrl, ecmd->tx_pause,