Patchwork [FWTS-TEST] klog-0002: rename "Common" label prefix to "Klog" to keep in sync with fwts

login
register
mail settings
Submitter Colin King
Date July 15, 2013, 9:46 a.m.
Message ID <1373881573-9890-1-git-send-email-colin.king@canonical.com>
Download mbox | patch
Permalink /patch/258976/
State Accepted
Headers show

Comments

Colin King - July 15, 2013, 9:46 a.m.
From: Colin Ian King <colin.king@canonical.com>

Commit 5b37a9d8ac122a5c1c4d7d00c21f5964ac904cfa removed the common test
and merged these into the klog test. However, the labels are still prefixed
with "Common" and should be renamed to "Klog".

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 klog-0002/klog-0001.log | 32 ++++++++++++++++----------------
 1 file changed, 16 insertions(+), 16 deletions(-)
Ivan Hu - July 16, 2013, 8:53 a.m.
On 07/15/2013 05:46 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Commit 5b37a9d8ac122a5c1c4d7d00c21f5964ac904cfa removed the common test
> and merged these into the klog test. However, the labels are still prefixed
> with "Common" and should be renamed to "Klog".
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>   klog-0002/klog-0001.log | 32 ++++++++++++++++----------------
>   1 file changed, 16 insertions(+), 16 deletions(-)
>
> diff --git a/klog-0002/klog-0001.log b/klog-0002/klog-0001.log
> index bb8ed1c..10fd3eb 100644
> --- a/klog-0002/klog-0001.log
> +++ b/klog-0002/klog-0001.log
> @@ -1,74 +1,74 @@
>   klog            klog: Scan kernel log for errors and warnings.
>   klog            ----------------------------------------------------------
>   klog            Test 1 of 1: Kernel log error check.
> -klog            FAILED [CRITICAL] CommonThermalOverrun: Test 1, CRITICAL
> +klog            FAILED [CRITICAL] KlogThermalOverrun: Test 1, CRITICAL
>   klog            Kernel message: [ 0.408874] CPU1: Temperature above
>   klog            threshold, cpu clock throttled (total events = 1)
>   klog
>   klog            ADVICE: Test caused CPU temperature above critical
>   klog            threshold. Insufficient cooling?
>   klog
> -klog            FAILED [CRITICAL] CommonBiosIrqRoutingBug: Test 1,
> -klog            CRITICAL Kernel message: [ 0.728985] Disabling IRQ #15
> +klog            FAILED [CRITICAL] KlogBiosIrqRoutingBug: Test 1, CRITICAL
> +klog            Kernel message: [ 0.728985] Disabling IRQ #15
>   klog
>   klog            ADVICE: The kernel detected an irq storm. This is most
>   klog            probably an IRQ routing bug.
>   klog
> -klog            FAILED [CRITICAL] CommonBiosIrqRoutingBug: Test 1,
> -klog            CRITICAL Kernel message: [ 0.734767] Disabling IRQ #11
> +klog            FAILED [CRITICAL] KlogBiosIrqRoutingBug: Test 1, CRITICAL
> +klog            Kernel message: [ 0.734767] Disabling IRQ #11
>   klog
>   klog            ADVICE: The kernel detected an irq storm. This is most
>   klog            probably an IRQ routing bug.
>   klog
> -klog            FAILED [CRITICAL] CommonThermalOverrun: Test 1, CRITICAL
> +klog            FAILED [CRITICAL] KlogThermalOverrun: Test 1, CRITICAL
>   klog            Kernel message: [ 0.768555] CPU3: Temperature above
>   klog            threshold, cpu clock throttled (total events = 1)
>   klog
>   klog            ADVICE: Test caused CPU temperature above critical
>   klog            threshold. Insufficient cooling?
>   klog
> -klog            FAILED [CRITICAL] CommonThermalOverrun: Test 1, CRITICAL
> +klog            FAILED [CRITICAL] KlogThermalOverrun: Test 1, CRITICAL
>   klog            Kernel message: [ 1.128275] CPU5: Temperature above
>   klog            threshold, cpu clock throttled (total events = 1)
>   klog
>   klog            ADVICE: Test caused CPU temperature above critical
>   klog            threshold. Insufficient cooling?
>   klog
> -klog            FAILED [CRITICAL] CommonThermalOverrun: Test 1, CRITICAL
> +klog            FAILED [CRITICAL] KlogThermalOverrun: Test 1, CRITICAL
>   klog            Kernel message: [ 1.487778] CPU7: Temperature above
>   klog            threshold, cpu clock throttled (total events = 1)
>   klog
>   klog            ADVICE: Test caused CPU temperature above critical
>   klog            threshold. Insufficient cooling?
>   klog
> -klog            FAILED [CRITICAL] CommonBiosIrqRoutingBug: Test 1,
> -klog            CRITICAL Kernel message: [ 2.131632] Disabling IRQ #16
> +klog            FAILED [CRITICAL] KlogBiosIrqRoutingBug: Test 1, CRITICAL
> +klog            Kernel message: [ 2.131632] Disabling IRQ #16
>   klog
>   klog            ADVICE: The kernel detected an irq storm. This is most
>   klog            probably an IRQ routing bug.
>   klog
> -klog            FAILED [CRITICAL] CommonBiosIrqRoutingBug: Test 1,
> -klog            CRITICAL Kernel message: [ 3.220411] Disabling IRQ #18
> +klog            FAILED [CRITICAL] KlogBiosIrqRoutingBug: Test 1, CRITICAL
> +klog            Kernel message: [ 3.220411] Disabling IRQ #18
>   klog
>   klog            ADVICE: The kernel detected an irq storm. This is most
>   klog            probably an IRQ routing bug.
>   klog
> -klog            FAILED [CRITICAL] CommonThermalOverrun: Test 1, CRITICAL
> +klog            FAILED [CRITICAL] KlogThermalOverrun: Test 1, CRITICAL
>   klog            Kernel message: [ 10.027255] CPU0: Temperature above
>   klog            threshold, cpu clock throttled (total events = 1)
>   klog
>   klog            ADVICE: Test caused CPU temperature above critical
>   klog            threshold. Insufficient cooling?
>   klog
> -klog            FAILED [CRITICAL] CommonThermalOverrun: Test 1, CRITICAL
> +klog            FAILED [CRITICAL] KlogThermalOverrun: Test 1, CRITICAL
>   klog            Kernel message: [ 11.592319] CPU1: Temperature above
>   klog            threshold, cpu clock throttled (total events = 2)
>   klog
>   klog            ADVICE: Test caused CPU temperature above critical
>   klog            threshold. Insufficient cooling?
>   klog
> -klog            FAILED [CRITICAL] CommonBiosIrqRoutingBug: Test 1,
> -klog            CRITICAL Kernel message: [ 17.353310] Disabling IRQ #10
> +klog            FAILED [CRITICAL] KlogBiosIrqRoutingBug: Test 1, CRITICAL
> +klog            Kernel message: [ 17.353310] Disabling IRQ #10
>   klog
>   klog            ADVICE: The kernel detected an irq storm. This is most
>   klog            probably an IRQ routing bug.
>
Acked-by: Ivan Hu <ivan.hu@canonical.com>
Keng-Yu Lin - July 26, 2013, 4:05 a.m.
On Mon, Jul 15, 2013 at 5:46 PM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Commit 5b37a9d8ac122a5c1c4d7d00c21f5964ac904cfa removed the common test
> and merged these into the klog test. However, the labels are still prefixed
> with "Common" and should be renamed to "Klog".
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  klog-0002/klog-0001.log | 32 ++++++++++++++++----------------
>  1 file changed, 16 insertions(+), 16 deletions(-)
>
> diff --git a/klog-0002/klog-0001.log b/klog-0002/klog-0001.log
> index bb8ed1c..10fd3eb 100644
> --- a/klog-0002/klog-0001.log
> +++ b/klog-0002/klog-0001.log
> @@ -1,74 +1,74 @@
>  klog            klog: Scan kernel log for errors and warnings.
>  klog            ----------------------------------------------------------
>  klog            Test 1 of 1: Kernel log error check.
> -klog            FAILED [CRITICAL] CommonThermalOverrun: Test 1, CRITICAL
> +klog            FAILED [CRITICAL] KlogThermalOverrun: Test 1, CRITICAL
>  klog            Kernel message: [ 0.408874] CPU1: Temperature above
>  klog            threshold, cpu clock throttled (total events = 1)
>  klog
>  klog            ADVICE: Test caused CPU temperature above critical
>  klog            threshold. Insufficient cooling?
>  klog
> -klog            FAILED [CRITICAL] CommonBiosIrqRoutingBug: Test 1,
> -klog            CRITICAL Kernel message: [ 0.728985] Disabling IRQ #15
> +klog            FAILED [CRITICAL] KlogBiosIrqRoutingBug: Test 1, CRITICAL
> +klog            Kernel message: [ 0.728985] Disabling IRQ #15
>  klog
>  klog            ADVICE: The kernel detected an irq storm. This is most
>  klog            probably an IRQ routing bug.
>  klog
> -klog            FAILED [CRITICAL] CommonBiosIrqRoutingBug: Test 1,
> -klog            CRITICAL Kernel message: [ 0.734767] Disabling IRQ #11
> +klog            FAILED [CRITICAL] KlogBiosIrqRoutingBug: Test 1, CRITICAL
> +klog            Kernel message: [ 0.734767] Disabling IRQ #11
>  klog
>  klog            ADVICE: The kernel detected an irq storm. This is most
>  klog            probably an IRQ routing bug.
>  klog
> -klog            FAILED [CRITICAL] CommonThermalOverrun: Test 1, CRITICAL
> +klog            FAILED [CRITICAL] KlogThermalOverrun: Test 1, CRITICAL
>  klog            Kernel message: [ 0.768555] CPU3: Temperature above
>  klog            threshold, cpu clock throttled (total events = 1)
>  klog
>  klog            ADVICE: Test caused CPU temperature above critical
>  klog            threshold. Insufficient cooling?
>  klog
> -klog            FAILED [CRITICAL] CommonThermalOverrun: Test 1, CRITICAL
> +klog            FAILED [CRITICAL] KlogThermalOverrun: Test 1, CRITICAL
>  klog            Kernel message: [ 1.128275] CPU5: Temperature above
>  klog            threshold, cpu clock throttled (total events = 1)
>  klog
>  klog            ADVICE: Test caused CPU temperature above critical
>  klog            threshold. Insufficient cooling?
>  klog
> -klog            FAILED [CRITICAL] CommonThermalOverrun: Test 1, CRITICAL
> +klog            FAILED [CRITICAL] KlogThermalOverrun: Test 1, CRITICAL
>  klog            Kernel message: [ 1.487778] CPU7: Temperature above
>  klog            threshold, cpu clock throttled (total events = 1)
>  klog
>  klog            ADVICE: Test caused CPU temperature above critical
>  klog            threshold. Insufficient cooling?
>  klog
> -klog            FAILED [CRITICAL] CommonBiosIrqRoutingBug: Test 1,
> -klog            CRITICAL Kernel message: [ 2.131632] Disabling IRQ #16
> +klog            FAILED [CRITICAL] KlogBiosIrqRoutingBug: Test 1, CRITICAL
> +klog            Kernel message: [ 2.131632] Disabling IRQ #16
>  klog
>  klog            ADVICE: The kernel detected an irq storm. This is most
>  klog            probably an IRQ routing bug.
>  klog
> -klog            FAILED [CRITICAL] CommonBiosIrqRoutingBug: Test 1,
> -klog            CRITICAL Kernel message: [ 3.220411] Disabling IRQ #18
> +klog            FAILED [CRITICAL] KlogBiosIrqRoutingBug: Test 1, CRITICAL
> +klog            Kernel message: [ 3.220411] Disabling IRQ #18
>  klog
>  klog            ADVICE: The kernel detected an irq storm. This is most
>  klog            probably an IRQ routing bug.
>  klog
> -klog            FAILED [CRITICAL] CommonThermalOverrun: Test 1, CRITICAL
> +klog            FAILED [CRITICAL] KlogThermalOverrun: Test 1, CRITICAL
>  klog            Kernel message: [ 10.027255] CPU0: Temperature above
>  klog            threshold, cpu clock throttled (total events = 1)
>  klog
>  klog            ADVICE: Test caused CPU temperature above critical
>  klog            threshold. Insufficient cooling?
>  klog
> -klog            FAILED [CRITICAL] CommonThermalOverrun: Test 1, CRITICAL
> +klog            FAILED [CRITICAL] KlogThermalOverrun: Test 1, CRITICAL
>  klog            Kernel message: [ 11.592319] CPU1: Temperature above
>  klog            threshold, cpu clock throttled (total events = 2)
>  klog
>  klog            ADVICE: Test caused CPU temperature above critical
>  klog            threshold. Insufficient cooling?
>  klog
> -klog            FAILED [CRITICAL] CommonBiosIrqRoutingBug: Test 1,
> -klog            CRITICAL Kernel message: [ 17.353310] Disabling IRQ #10
> +klog            FAILED [CRITICAL] KlogBiosIrqRoutingBug: Test 1, CRITICAL
> +klog            Kernel message: [ 17.353310] Disabling IRQ #10
>  klog
>  klog            ADVICE: The kernel detected an irq storm. This is most
>  klog            probably an IRQ routing bug.
> --
> 1.8.1.2
>

Acked-by: Keng-Yu Lin <kengyu@canonical.com>

Patch

diff --git a/klog-0002/klog-0001.log b/klog-0002/klog-0001.log
index bb8ed1c..10fd3eb 100644
--- a/klog-0002/klog-0001.log
+++ b/klog-0002/klog-0001.log
@@ -1,74 +1,74 @@ 
 klog            klog: Scan kernel log for errors and warnings.
 klog            ----------------------------------------------------------
 klog            Test 1 of 1: Kernel log error check.
-klog            FAILED [CRITICAL] CommonThermalOverrun: Test 1, CRITICAL
+klog            FAILED [CRITICAL] KlogThermalOverrun: Test 1, CRITICAL
 klog            Kernel message: [ 0.408874] CPU1: Temperature above
 klog            threshold, cpu clock throttled (total events = 1)
 klog            
 klog            ADVICE: Test caused CPU temperature above critical
 klog            threshold. Insufficient cooling?
 klog            
-klog            FAILED [CRITICAL] CommonBiosIrqRoutingBug: Test 1,
-klog            CRITICAL Kernel message: [ 0.728985] Disabling IRQ #15
+klog            FAILED [CRITICAL] KlogBiosIrqRoutingBug: Test 1, CRITICAL
+klog            Kernel message: [ 0.728985] Disabling IRQ #15
 klog            
 klog            ADVICE: The kernel detected an irq storm. This is most
 klog            probably an IRQ routing bug.
 klog            
-klog            FAILED [CRITICAL] CommonBiosIrqRoutingBug: Test 1,
-klog            CRITICAL Kernel message: [ 0.734767] Disabling IRQ #11
+klog            FAILED [CRITICAL] KlogBiosIrqRoutingBug: Test 1, CRITICAL
+klog            Kernel message: [ 0.734767] Disabling IRQ #11
 klog            
 klog            ADVICE: The kernel detected an irq storm. This is most
 klog            probably an IRQ routing bug.
 klog            
-klog            FAILED [CRITICAL] CommonThermalOverrun: Test 1, CRITICAL
+klog            FAILED [CRITICAL] KlogThermalOverrun: Test 1, CRITICAL
 klog            Kernel message: [ 0.768555] CPU3: Temperature above
 klog            threshold, cpu clock throttled (total events = 1)
 klog            
 klog            ADVICE: Test caused CPU temperature above critical
 klog            threshold. Insufficient cooling?
 klog            
-klog            FAILED [CRITICAL] CommonThermalOverrun: Test 1, CRITICAL
+klog            FAILED [CRITICAL] KlogThermalOverrun: Test 1, CRITICAL
 klog            Kernel message: [ 1.128275] CPU5: Temperature above
 klog            threshold, cpu clock throttled (total events = 1)
 klog            
 klog            ADVICE: Test caused CPU temperature above critical
 klog            threshold. Insufficient cooling?
 klog            
-klog            FAILED [CRITICAL] CommonThermalOverrun: Test 1, CRITICAL
+klog            FAILED [CRITICAL] KlogThermalOverrun: Test 1, CRITICAL
 klog            Kernel message: [ 1.487778] CPU7: Temperature above
 klog            threshold, cpu clock throttled (total events = 1)
 klog            
 klog            ADVICE: Test caused CPU temperature above critical
 klog            threshold. Insufficient cooling?
 klog            
-klog            FAILED [CRITICAL] CommonBiosIrqRoutingBug: Test 1,
-klog            CRITICAL Kernel message: [ 2.131632] Disabling IRQ #16
+klog            FAILED [CRITICAL] KlogBiosIrqRoutingBug: Test 1, CRITICAL
+klog            Kernel message: [ 2.131632] Disabling IRQ #16
 klog            
 klog            ADVICE: The kernel detected an irq storm. This is most
 klog            probably an IRQ routing bug.
 klog            
-klog            FAILED [CRITICAL] CommonBiosIrqRoutingBug: Test 1,
-klog            CRITICAL Kernel message: [ 3.220411] Disabling IRQ #18
+klog            FAILED [CRITICAL] KlogBiosIrqRoutingBug: Test 1, CRITICAL
+klog            Kernel message: [ 3.220411] Disabling IRQ #18
 klog            
 klog            ADVICE: The kernel detected an irq storm. This is most
 klog            probably an IRQ routing bug.
 klog            
-klog            FAILED [CRITICAL] CommonThermalOverrun: Test 1, CRITICAL
+klog            FAILED [CRITICAL] KlogThermalOverrun: Test 1, CRITICAL
 klog            Kernel message: [ 10.027255] CPU0: Temperature above
 klog            threshold, cpu clock throttled (total events = 1)
 klog            
 klog            ADVICE: Test caused CPU temperature above critical
 klog            threshold. Insufficient cooling?
 klog            
-klog            FAILED [CRITICAL] CommonThermalOverrun: Test 1, CRITICAL
+klog            FAILED [CRITICAL] KlogThermalOverrun: Test 1, CRITICAL
 klog            Kernel message: [ 11.592319] CPU1: Temperature above
 klog            threshold, cpu clock throttled (total events = 2)
 klog            
 klog            ADVICE: Test caused CPU temperature above critical
 klog            threshold. Insufficient cooling?
 klog            
-klog            FAILED [CRITICAL] CommonBiosIrqRoutingBug: Test 1,
-klog            CRITICAL Kernel message: [ 17.353310] Disabling IRQ #10
+klog            FAILED [CRITICAL] KlogBiosIrqRoutingBug: Test 1, CRITICAL
+klog            Kernel message: [ 17.353310] Disabling IRQ #10
 klog            
 klog            ADVICE: The kernel detected an irq storm. This is most
 klog            probably an IRQ routing bug.