From patchwork Mon Jul 15 09:42:34 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xu Wang X-Patchwork-Id: 258974 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id B056C2C00BE for ; Mon, 15 Jul 2013 19:46:19 +1000 (EST) Received: from localhost ([::1]:41185 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UyfMH-00040n-1C for incoming@patchwork.ozlabs.org; Mon, 15 Jul 2013 05:46:17 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44972) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UyfJe-0000Cb-FF for qemu-devel@nongnu.org; Mon, 15 Jul 2013 05:43:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UyfJa-0002u5-0n for qemu-devel@nongnu.org; Mon, 15 Jul 2013 05:43:34 -0400 Received: from mail-pb0-x22a.google.com ([2607:f8b0:400e:c01::22a]:61588) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UyfJZ-0002tp-Pj for qemu-devel@nongnu.org; Mon, 15 Jul 2013 05:43:29 -0400 Received: by mail-pb0-f42.google.com with SMTP id un1so11134345pbc.15 for ; Mon, 15 Jul 2013 02:43:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; bh=aUTNJyd5KcR8grUF2MhqGIvTL6mo3fEvvyCeqY4eaWM=; b=Kr0V8g1WvPrVuDxDdbvJGXhJychTiwLsnp5arswGAqUZwRPbaH43dbTZZfkBCsJLVA h/1wRR6xG+Nteg8RMPB6UzLVTtngh+1/fe9ap6hf4RqLThKacd+lfhTga4ibMn5jrRyu G/qSwcgIF5fW7T/41BTlDYo2nVzmvVHGqTRdXTDnmbaExSjqB1fb9JMMtFgyJWhDSDk4 kKAZa+pRaaK8NymKltNUMjkaERN0zmQntfmEBdZdMR1sJi1iOQUaE/upN95A7bUsSzSK WK35J09m1eaS1HB4EVKb8FxbY3XweoVUj1T48hQZ7clVZ7JvwpmQ+gz2Fa9tEPx/D6xC zing== X-Received: by 10.66.217.195 with SMTP id pa3mr54678810pac.120.1373881409019; Mon, 15 Jul 2013 02:43:29 -0700 (PDT) Received: from localhost.localdomain ([202.108.130.194]) by mx.google.com with ESMTPSA id py4sm16734218pbc.14.2013.07.15.02.43.26 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Mon, 15 Jul 2013 02:43:28 -0700 (PDT) From: Xu Wang To: qemu-devel@nongnu.org Date: Mon, 15 Jul 2013 05:42:34 -0400 Message-Id: <1373881356-3294-6-git-send-email-cngesaint@gmail.com> X-Mailer: git-send-email 1.8.1.4 In-Reply-To: <1373881356-3294-1-git-send-email-cngesaint@gmail.com> References: <1373881356-3294-1-git-send-email-cngesaint@gmail.com> X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:400e:c01::22a Cc: kwolf@redhat.com, famz@redhat.com, stefanha@gmail.com, wdongxu@linux.vnet.ibm.com, Xu Wang , xiawenc@linux.vnet.ibm.com Subject: [Qemu-devel] [PATCH V3 5/7] block: Add infinite loop check in drive_init() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Backing file should be checked if there is a loop in it during image boot. Becase if there is loop qemu would no response for a long time and segment fault occured. So this patch would check backing file chain if there is loop in it before open image. Signed-off-by: Xu Wang --- blockdev.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/blockdev.c b/blockdev.c index b3a57e0..b5f063f 100644 --- a/blockdev.c +++ b/blockdev.c @@ -695,6 +695,12 @@ DriveInfo *drive_init(QemuOpts *all_opts, BlockInterfaceType block_default_type) error_report("warning: disabling copy_on_read on readonly drive"); } + /* Add backing file loop check */ + if (bdrv_backing_file_loop_check(file, drv ? drv->format_name : NULL, + NULL, NULL)) { + goto err; + } + ret = bdrv_open(dinfo->bdrv, file, bs_opts, bdrv_flags, drv); bs_opts = NULL;