Patchwork data: klog.json: rename "Common" label prefix to "Klog", (LP: #1201311)

login
register
mail settings
Submitter Colin King
Date July 15, 2013, 8:26 a.m.
Message ID <1373876789-9644-1-git-send-email-colin.king@canonical.com>
Download mbox | patch
Permalink /patch/258959/
State Accepted
Headers show

Comments

Colin King - July 15, 2013, 8:26 a.m.
From: Colin Ian King <colin.king@canonical.com>

Commit 5b37a9d8ac122a5c1c4d7d00c21f5964ac904cfa removed the common test
and merged these into the klog test. However, the labels are still prefixed
with "Common" and should be renamed to "Klog".

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 data/klog.json | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)
Ivan Hu - July 16, 2013, 8:53 a.m.
On 07/15/2013 04:26 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Commit 5b37a9d8ac122a5c1c4d7d00c21f5964ac904cfa removed the common test
> and merged these into the klog test. However, the labels are still prefixed
> with "Common" and should be renamed to "Klog".
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>   data/klog.json | 18 +++++++++---------
>   1 file changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/data/klog.json b/data/klog.json
> index d7920a2..7169999 100644
> --- a/data/klog.json
> +++ b/data/klog.json
> @@ -7,7 +7,7 @@
>      "tag": "FWTS_TAG_BIOS_THERMAL",
>      "pattern": "Temperature above threshold, cpu clock throttled",
>      "advice": "Test caused CPU temperature above critical threshold. Insufficient cooling?",
> -   "label": "CommonThermalOverrun"
> +   "label": "KlogThermalOverrun"
>     },
>     {
>      "compare_mode": "string",
> @@ -15,7 +15,7 @@
>      "tag": "FWTS_TAG_BIOS",
>      "pattern": "BIOS never enumerated boot CPU",
>      "advice": "The boot processor is not enumerated!",
> -   "label": "CommonBiosBootCpuNotEnumerated"
> +   "label": "KlogBiosBootCpuNotEnumerated"
>     },
>     {
>      "compare_mode": "regex",
> @@ -23,7 +23,7 @@
>      "tag": "FWTS_TAG_ACPI_HOTPLUG",
>      "pattern": "acpi_shpchprm.*_HPP fail",
>      "advice": "Hotplug _HPP method failed",
> -   "label": "CommonAcpiHppMethodFailed"
> +   "label": "KlogAcpiHppMethodFailed"
>     },
>     {
>      "compare_mode": "regex",
> @@ -31,7 +31,7 @@
>      "tag": "FWTS_TAG_ACPI_HOTPLUG",
>      "pattern": "shpchp.*acpi_pciehprm.*OSHP fail",
>      "advice": "ACPI Hotplug OSHP method failed",
> -   "label": "CommonAcpiHotplugOshpMethodFailed"
> +   "label": "KlogAcpiHotplugOshpMethodFailed"
>     },
>     {
>      "compare_mode": "regex",
> @@ -39,7 +39,7 @@
>      "tag": "FWTS_TAG_ACPI_HOTPLUG",
>      "pattern": "shpchp.*acpi_shpchprm.*evaluate _BBN fail",
>      "advice": "Hotplug _BBN method is missing",
> -   "label": "CommonAcpiHotPlugBbnMissing"
> +   "label": "KlogAcpiHotPlugBbnMissing"
>     },
>     {
>      "compare_mode": "string",
> @@ -47,7 +47,7 @@
>      "tag": "FWTS_TAG_ACPI",
>      "pattern": "Error while parsing _PSD domain information",
>      "advice": "_PSD domain information is corrupt!",
> -   "label": "CommonAcpiPsdParsingError"
> +   "label": "KlogAcpiPsdParsingError"
>     },
>     {
>      "compare_mode": "string",
> @@ -55,7 +55,7 @@
>      "tag": "FWTS_TAG_ACPI",
>      "pattern": "Wrong _BBN value, reboot and use option 'pci=noacpi'",
>      "advice": "The BIOS has wrong _BBN value, which will make PCI root bridge have wrong bus number",
> -   "label": "CommonAcpiWrongBbnValue"
> +   "label": "KlogAcpiWrongBbnValue"
>     },
>     {
>      "compare_mode": "regex",
> @@ -63,7 +63,7 @@
>      "tag": "FWTS_TAG_ACPI_APIC",
>      "pattern": "ACPI.*apic on CPU.* stops in C2",
>      "advice": "The local apic timer incorrectly stops during C2 idle state.The ACPI specification forbids this and Linux needs the local APIC timer to work. The most likely cause of this is that the firmware uses a hardware C3 or C4 state that is mapped to the ACPI C2 state.",
> -   "label": "CommonAcpiApicStopsInC2"
> +   "label": "KlogAcpiApicStopsInC2"
>     },
>     {
>      "compare_mode": "string",
> @@ -71,7 +71,7 @@
>      "tag": "FWTS_TAG_BIOS_IRQ",
>      "pattern": "Disabling IRQ",
>      "advice": "The kernel detected an irq storm. This is most probably an IRQ routing bug.",
> -   "label": "CommonBiosIrqRoutingBug"
> +   "label": "KlogBiosIrqRoutingBug"
>     },
>     {
>       "compare_mode": "regex",
>
Acked-by: Ivan Hu <ivan.hu@canonical.com>
Keng-Yu Lin - July 26, 2013, 4:04 a.m.
On Mon, Jul 15, 2013 at 4:26 PM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Commit 5b37a9d8ac122a5c1c4d7d00c21f5964ac904cfa removed the common test
> and merged these into the klog test. However, the labels are still prefixed
> with "Common" and should be renamed to "Klog".
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  data/klog.json | 18 +++++++++---------
>  1 file changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/data/klog.json b/data/klog.json
> index d7920a2..7169999 100644
> --- a/data/klog.json
> +++ b/data/klog.json
> @@ -7,7 +7,7 @@
>     "tag": "FWTS_TAG_BIOS_THERMAL",
>     "pattern": "Temperature above threshold, cpu clock throttled",
>     "advice": "Test caused CPU temperature above critical threshold. Insufficient cooling?",
> -   "label": "CommonThermalOverrun"
> +   "label": "KlogThermalOverrun"
>    },
>    {
>     "compare_mode": "string",
> @@ -15,7 +15,7 @@
>     "tag": "FWTS_TAG_BIOS",
>     "pattern": "BIOS never enumerated boot CPU",
>     "advice": "The boot processor is not enumerated!",
> -   "label": "CommonBiosBootCpuNotEnumerated"
> +   "label": "KlogBiosBootCpuNotEnumerated"
>    },
>    {
>     "compare_mode": "regex",
> @@ -23,7 +23,7 @@
>     "tag": "FWTS_TAG_ACPI_HOTPLUG",
>     "pattern": "acpi_shpchprm.*_HPP fail",
>     "advice": "Hotplug _HPP method failed",
> -   "label": "CommonAcpiHppMethodFailed"
> +   "label": "KlogAcpiHppMethodFailed"
>    },
>    {
>     "compare_mode": "regex",
> @@ -31,7 +31,7 @@
>     "tag": "FWTS_TAG_ACPI_HOTPLUG",
>     "pattern": "shpchp.*acpi_pciehprm.*OSHP fail",
>     "advice": "ACPI Hotplug OSHP method failed",
> -   "label": "CommonAcpiHotplugOshpMethodFailed"
> +   "label": "KlogAcpiHotplugOshpMethodFailed"
>    },
>    {
>     "compare_mode": "regex",
> @@ -39,7 +39,7 @@
>     "tag": "FWTS_TAG_ACPI_HOTPLUG",
>     "pattern": "shpchp.*acpi_shpchprm.*evaluate _BBN fail",
>     "advice": "Hotplug _BBN method is missing",
> -   "label": "CommonAcpiHotPlugBbnMissing"
> +   "label": "KlogAcpiHotPlugBbnMissing"
>    },
>    {
>     "compare_mode": "string",
> @@ -47,7 +47,7 @@
>     "tag": "FWTS_TAG_ACPI",
>     "pattern": "Error while parsing _PSD domain information",
>     "advice": "_PSD domain information is corrupt!",
> -   "label": "CommonAcpiPsdParsingError"
> +   "label": "KlogAcpiPsdParsingError"
>    },
>    {
>     "compare_mode": "string",
> @@ -55,7 +55,7 @@
>     "tag": "FWTS_TAG_ACPI",
>     "pattern": "Wrong _BBN value, reboot and use option 'pci=noacpi'",
>     "advice": "The BIOS has wrong _BBN value, which will make PCI root bridge have wrong bus number",
> -   "label": "CommonAcpiWrongBbnValue"
> +   "label": "KlogAcpiWrongBbnValue"
>    },
>    {
>     "compare_mode": "regex",
> @@ -63,7 +63,7 @@
>     "tag": "FWTS_TAG_ACPI_APIC",
>     "pattern": "ACPI.*apic on CPU.* stops in C2",
>     "advice": "The local apic timer incorrectly stops during C2 idle state.The ACPI specification forbids this and Linux needs the local APIC timer to work. The most likely cause of this is that the firmware uses a hardware C3 or C4 state that is mapped to the ACPI C2 state.",
> -   "label": "CommonAcpiApicStopsInC2"
> +   "label": "KlogAcpiApicStopsInC2"
>    },
>    {
>     "compare_mode": "string",
> @@ -71,7 +71,7 @@
>     "tag": "FWTS_TAG_BIOS_IRQ",
>     "pattern": "Disabling IRQ",
>     "advice": "The kernel detected an irq storm. This is most probably an IRQ routing bug.",
> -   "label": "CommonBiosIrqRoutingBug"
> +   "label": "KlogBiosIrqRoutingBug"
>    },
>    {
>      "compare_mode": "regex",
> --
> 1.8.1.2
>
Acked-by: Keng-Yu Lin <kengyu@canonical.com>

Patch

diff --git a/data/klog.json b/data/klog.json
index d7920a2..7169999 100644
--- a/data/klog.json
+++ b/data/klog.json
@@ -7,7 +7,7 @@ 
    "tag": "FWTS_TAG_BIOS_THERMAL",
    "pattern": "Temperature above threshold, cpu clock throttled",
    "advice": "Test caused CPU temperature above critical threshold. Insufficient cooling?",
-   "label": "CommonThermalOverrun"
+   "label": "KlogThermalOverrun"
   },
   {
    "compare_mode": "string",
@@ -15,7 +15,7 @@ 
    "tag": "FWTS_TAG_BIOS",
    "pattern": "BIOS never enumerated boot CPU",
    "advice": "The boot processor is not enumerated!",
-   "label": "CommonBiosBootCpuNotEnumerated"
+   "label": "KlogBiosBootCpuNotEnumerated"
   },
   {
    "compare_mode": "regex",
@@ -23,7 +23,7 @@ 
    "tag": "FWTS_TAG_ACPI_HOTPLUG",
    "pattern": "acpi_shpchprm.*_HPP fail",
    "advice": "Hotplug _HPP method failed",
-   "label": "CommonAcpiHppMethodFailed"
+   "label": "KlogAcpiHppMethodFailed"
   },
   {
    "compare_mode": "regex",
@@ -31,7 +31,7 @@ 
    "tag": "FWTS_TAG_ACPI_HOTPLUG",
    "pattern": "shpchp.*acpi_pciehprm.*OSHP fail",
    "advice": "ACPI Hotplug OSHP method failed",
-   "label": "CommonAcpiHotplugOshpMethodFailed"
+   "label": "KlogAcpiHotplugOshpMethodFailed"
   },
   {
    "compare_mode": "regex",
@@ -39,7 +39,7 @@ 
    "tag": "FWTS_TAG_ACPI_HOTPLUG",
    "pattern": "shpchp.*acpi_shpchprm.*evaluate _BBN fail",
    "advice": "Hotplug _BBN method is missing",
-   "label": "CommonAcpiHotPlugBbnMissing"
+   "label": "KlogAcpiHotPlugBbnMissing"
   },
   {
    "compare_mode": "string",
@@ -47,7 +47,7 @@ 
    "tag": "FWTS_TAG_ACPI",
    "pattern": "Error while parsing _PSD domain information",
    "advice": "_PSD domain information is corrupt!",
-   "label": "CommonAcpiPsdParsingError"
+   "label": "KlogAcpiPsdParsingError"
   },
   {
    "compare_mode": "string",
@@ -55,7 +55,7 @@ 
    "tag": "FWTS_TAG_ACPI",
    "pattern": "Wrong _BBN value, reboot and use option 'pci=noacpi'",
    "advice": "The BIOS has wrong _BBN value, which will make PCI root bridge have wrong bus number",
-   "label": "CommonAcpiWrongBbnValue"
+   "label": "KlogAcpiWrongBbnValue"
   },
   {
    "compare_mode": "regex",
@@ -63,7 +63,7 @@ 
    "tag": "FWTS_TAG_ACPI_APIC",
    "pattern": "ACPI.*apic on CPU.* stops in C2",
    "advice": "The local apic timer incorrectly stops during C2 idle state.The ACPI specification forbids this and Linux needs the local APIC timer to work. The most likely cause of this is that the firmware uses a hardware C3 or C4 state that is mapped to the ACPI C2 state.",
-   "label": "CommonAcpiApicStopsInC2"
+   "label": "KlogAcpiApicStopsInC2"
   },
   {
    "compare_mode": "string",
@@ -71,7 +71,7 @@ 
    "tag": "FWTS_TAG_BIOS_IRQ",
    "pattern": "Disabling IRQ",
    "advice": "The kernel detected an irq storm. This is most probably an IRQ routing bug.",
-   "label": "CommonBiosIrqRoutingBug"
+   "label": "KlogBiosIrqRoutingBug"
   },
   {
     "compare_mode": "regex",