Patchwork Minor Cygwin patches

login
register
mail settings
Submitter JonY
Date July 15, 2013, 1:15 a.m.
Message ID <51E34D2F.6070804@gmail.com>
Download mbox | patch
Permalink /patch/258919/
State New
Headers show

Comments

JonY - July 15, 2013, 1:15 a.m.
On 7/15/2013 06:02, Kai Tietz wrote:
> 2013/7/13 JonY <10walls@gmail.com>:
>> On 7/10/2013 20:43, JonY wrote:
>>> Hi,
>>>
>>> Attached are some minor patches, comments?
>>>
>>
>> Kai, ping?
> 
> 
> Please sent each patch as separate mail, and please add ChangeLogs for
> them too.  Additionally it would be fine to read some lines about
> cause for those patches.
> 
> Kai
> 

Changelog

2013-03-08  Yaakov Selkowitz <yselkowitz@users.sourceforge.net>

    * (gcc/testsuite/gcc.target/i386/pr25993.c): Skip unsupported test.
Marek Polacek - July 15, 2013, 1:20 a.m.
On Mon, Jul 15, 2013 at 09:15:27AM +0800, JonY wrote:
> On 7/15/2013 06:02, Kai Tietz wrote:
> > 2013/7/13 JonY <10walls@gmail.com>:
> >> On 7/10/2013 20:43, JonY wrote:
> >>> Hi,
> >>>
> >>> Attached are some minor patches, comments?
> >>>
> >>
> >> Kai, ping?
> > 
> > 
> > Please sent each patch as separate mail, and please add ChangeLogs for
> > them too.  Additionally it would be fine to read some lines about
> > cause for those patches.
> > 
> > Kai
> > 
> 
> Changelog
> 
> 2013-03-08  Yaakov Selkowitz <yselkowitz@users.sourceforge.net>
> 
>     * (gcc/testsuite/gcc.target/i386/pr25993.c): Skip unsupported test.
> 

That seems wrong.  Better would be:

	* gcc.target/i386/pr25993.c: Skip unsupported test.

and put this into gcc/testsuite/ChangeLog.
And two spaces between the name and the e-mail address.

	Marek
Yaakov (Cygwin/X) - July 19, 2013, 7:21 a.m.
On 2013-07-14 20:15, JonY wrote:
> 2013-03-08  Yaakov Selkowitz <yselkowitz@users.sourceforge.net>
>
>      * (gcc/testsuite/gcc.target/i386/pr25993.c): Skip unsupported test.

This patch was Dave Korn's.


Yaakov
JonY - July 23, 2013, 1:33 p.m.
On 7/19/2013 15:21, Yaakov (Cygwin/X) wrote:
> On 2013-07-14 20:15, JonY wrote:
>> 2013-03-08  Yaakov Selkowitz <yselkowitz@users.sourceforge.net>
>>
>>      * (gcc/testsuite/gcc.target/i386/pr25993.c): Skip unsupported test.
> 
> This patch was Dave Korn's.
> 
> 

OK.

Changelog

2013-03-08  Dave Korn  <dave.korn.cygwin@googlemail.com>

    * (gcc/testsuite/gcc.target/i386/pr25993.c): Skip unsupported test.

Patch

--- origsrc/gcc-4.5.0/gcc/testsuite/gcc.target/i386/pr25993.c	2008-02-26 01:38:34.000000000 +0000
+++ src/gcc-4.5.0/gcc/testsuite/gcc.target/i386/pr25993.c	2010-04-25 16:17:21.703125000 +0100
@@ -1,5 +1,5 @@ 
 /* { dg-do assemble } */
-/* { dg-skip-if "" { "*-*-darwin*" "*-*-mingw*" } { "*" } { "" } } */
+/* { dg-skip-if "" { "*-*-darwin*" "*-*-mingw*" "*-*-cygwin*" } { "*" } { "" } } */
 /* { dg-options "-std=c99 -x assembler-with-cpp" } */
 
 #ifndef __ASSEMBLER__